dw-xdata: Use str_write_read() in dw_xdata_start() and dw_xdata_perf()
Subsystems (3)
PATCH 1/1 dw-xdata: Use str_write_read() in dw_xdata_start() and dw_xdata_perf()
Remove hard-coded strings by using the str_write_read() helper function and silence the following two Coccinelle/coccicheck warnings reported by string_choices.cocci:
opportunity for str_write_read(write)
opportunity for str_write_read(write)
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/misc/dw-xdata-pcie.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/misc/dw-xdata-pcie.c +3 -2
@@ -16,6 +16,7 @@#include <linux/mutex.h> #include <linux/delay.h> #include <linux/pci.h> +#include <linux/string_choices.h> #define DW_XDATA_DRIVER_NAME "dw-xdata-pcie"
@@ -132,7 +133,7 @@ static void dw_xdata_start(struct dw_xdata *dw, bool write)if (!(status &STATUS_DONE ))dev_dbg (dev,"xData: started %s direction\n" , - write ?"write" :"read" ); +str_write_read (write)); }static void dw_xdata_perf_meas (struct dw_xdata *dw,u64 *data,bool write)
@@ -195,7 +196,7 @@ static void dw_xdata_perf(struct dw_xdata *dw, u64 *rate, bool write)mutex_unlock (&dw->mutex);dev_dbg (dev,"xData: time=%llu us, %s=%llu MB/s\n" , - diff, write ?"write" :"read" , *rate); + diff,str_write_read (write), *rate); }static struct dw_xdata *misc_dev_to_dw (struct miscdevice *misc_dev)
Signature · 1 line
2.50.1