add basic PSP encryption for TCP connections
Subsystems (12)
Daniel Zahka
maintainercover add basic PSP encryption for TCP connections
This is v7 of the PSP RFC [1] posted by Jakub Kicinski one year ago. General developments since v1 include a fork of packetdrill [2] with support for PSP added, as well as some test cases, and an implementation of PSP key exchange and connection upgrade [3] integrated into the fbthrift RPC library. Both [2] and [3] have been tested on server platforms with PSP-capable CX7 NICs. Below is the cover letter from the original RFC:
Add support for PSP encryption of TCP connections.
PSP is a protocol out of Google:
https://github.com/google/psp/blob/main/doc/PSP_Arch_Spec.pdf
which shares some similarities with IPsec. I added some more info in the first patch so I'll keep it short here.
The protocol can work in multiple modes including tunneling. But I'm mostly interested in using it as TLS replacement because of its superior offload characteristics. So this patch does three things:
- it adds "core" PSP code
PSP is offload-centric, and requires some additional care and feeding, so first chunk of the code exposes device info. This part can be reused by PSP implementations in xfrm, tunneling etc.
- TCP integration TLS style
Reuse some of the existing concepts from TLS offload, such as attaching crypto state to a socket, marking skbs as "decrypted", egress validation. PSP does not prescribe key exchange protocols. To use PSP as a more efficient TLS offload we intend to perform a TLS handshake ("inline" in the same TCP connection) and negotiate switching to PSP based on capabilities of both endpoints. This is also why I'm not including a software implementation. Nobody would use it in production, software TLS is faster, it has larger crypto records.
- mlx5 implementation
That's mostly other people's work, not 100% sure those folks consider it ready hence the RFC in the title. But it works :)
Not posted, queued a branch [4] are follow up pieces:
- standard stats
- netdevsim implementation and tests
[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://github.com/danieldzahka/packetdrill
[3] https://github.com/danieldzahka/fbthrift/tree/dzahka/psp
[4] https://github.com/kuba-moo/linux/tree/psp
Comments we intend to defer to future series:
- we prefer to keep the version field in the tx-assoc netlink request, because it makes parsing keys require less state early on, but we are willing to change in the next version of this series.
- using a static branch to wrap psp_enqueue_set_decrypted() and other functions called from tcp.
- using INDIRECT_CALL for tls/psp in sk_validate_xmit_skb(). We prefer to address this in a dedicated patch series, so that this series does not need to modify the way tls_validate_xmit_skb() is declared and stubbed out.
CHANGES:
v7:
- use flexible array declaration instead of 0-length array declaration in struct mlx5_ifc_psp_gen_spi_out_bits
- check that 31 LSBs of the SPI are non-zero in psp_nl_parse_key()
- add details about GRO and TCP coalescing in commit message of fourth patch.
- add comment explaining use of xa_store()/xa_erase() in psp_dev_unregister()/psp_dev_destroy().
v6: https://lore.kernel.org/netdev/[email protected]/
- make psp_sk_overhead() add 40B of encapsulation overhead.
- use PSP_CMD_KEY_ROTATE_NTF instead of PSP_CMD_KEY_ROTATE as arg to genl_info_init_ntf()
- fix errors reported by static analysis
v5: https://lore.kernel.org/netdev/[email protected]/
- rebase series
v4: https://lore.kernel.org/netdev/[email protected]/
- rename psp_rcv() to psp_dev_rcv()
- add strip_icv param psp_dev_rcv() to make trailer stripping optional
- replace memcpy in mlx5e_psp_set_state()
- rename psp_encapsulate() to psp_dev_encapsulate()
- delete unused struct mlx5e_psp_sa_entry declaration
- use psp_key_size() instead of pas->key_sz in mlx5e_psp_assoc_add()
- remove unneeded psp.c/psp.h files in mlx5
- remove unneeded struct psp_key_spi usage in mlx5
- fix EXPORT_IPV6_MOD_GPL(psp_reply_set_decrypted) semicolon
- remove version from netlink rx-assoc reply
- remove key_sz field from struct psp_assoc
- rename psd_get_for_sock() to psp_dev_get_for_sock()
- use sk_is_tcp() to check sock in psp_assoc_device_get_locked()
- add comment to tcp_timewait_state_process() explaining TCP_TW_SYN case.
- psp_twsk_init() accepts const pointer, so caller does not need to cast const away.
- add missing psp_twsk_rx_policy_check() to TCP_TW_SYN case of do_timewait in tcp_v4_rcv().
- remove unused PSP_KEY_V0/PSP_KEY_V1 defines
v3: https://lore.kernel.org/netdev/[email protected]/
- move psp_rcv() and psp_encapsulate() driver helpers into psp_main.c
- lift pse/pas comparison code into new function:
psp_pse_matches_pas()
- explicitly mark rcu critical section psp_reply_set_decrypted()
- use rcu_dereference_proteced() instead of rcu_read_lock() in psp_sk_assoc_free() and psp_twsk_assoc_free()
- rename psp_is_nondata() to psp_is_allowed_nondata()
- psp_reply_set_decrypted() should not call psp_sk_assoc(). Call psp_sk_get_assoc_rcu() instead.
- lift common code from timewait and regular socks into new function psp_sk_get_assoc_rcu()
- export symbols in psp_sock.c with EXPORT_IPV6_MOD_GPL()
- check for sk_is_inet() before casting to inet_twsk() in sk_validate_xmit() and in psp_get_assoc_rcu()
- psp_reply_set_decrypted() does not use stuct sock* arg. Drop it.
- reword driver requirement about double rotating keys when the device supports requesting arbitrary spi key pairs.
v2: https://lore.kernel.org/netdev/[email protected]/
- add pas->dev_id == pse->dev_id to policy checks
- __psp_sk_rx_policy_check() now allows pure ACKs, FINs, and RSTs to be non-psp authenticated before "PSP Full" state.
- assign tw_validate_skb funtion during psp_twsk_init()
- psp_skb_get_rcu() also checks if sk is a tcp timewait sock when looking for psp assocs.
- scan ofo queue non-psp data during psp_sock_recv_queue_check()
- add tcp_write_collapse_fence() to psp_sock_assoc_set_tx()
- Add psp_reply_set_decrypted() to encapsulate ACKs, FINs, and RSTs sent from control socks on behalf of full or timewait socks with PSP state.
- Add dev_id field to psp_skb_ext
- Move psp_assoc from struct tcp_timewait_sock to struct inet_timewait_sock
- Move psp_sk_assoc_free() from sk_common_release() to inet_sock_destruct()
- add documentation about MITM deletion attack, and expectation from userspace
- add information about accepting clear text ACKs, RSTs, and FINs to Securing Connections section.
v1: https://lore.kernel.org/netdev/[email protected]/
Daniel Zahka (2):
net: move sk_validate_xmit_skb() to net/core/dev.c
net: tcp: allow tcp_timewait_sock to validate skbs before handing to
device
Jakub Kicinski (8):
psp: add documentation
psp: base PSP device support
net: modify core data structures for PSP datapath support
tcp: add datapath logic for PSP with inline key exchange
psp: add op for rotation of device key
net: psp: add socket security association code
net: psp: update the TCP MSS to reflect PSP packet overhead
psp: track generations of device key
Raed Salem (9):
net/mlx5e: Support PSP offload functionality net/mlx5e: Implement PSP operations .assoc_add and .assoc_del
psp: provide encapsulation helper for drivers net/mlx5e: Implement PSP Tx data path
net/mlx5e: Add PSP steering in local NIC RX net/mlx5e: Configure PSP Rx flow steering rules
psp: provide decapsulation and receive helper for drivers net/mlx5e: Add Rx data path offload
net/mlx5e: Implement PSP key_rotate operation
Documentation/netlink/specs/psp.yaml | 187 +++++ Documentation/networking/index.rst | 1 + Documentation/networking/psp.rst | 183 +++++ .../net/ethernet/mellanox/mlx5/core/Kconfig | 11 + .../net/ethernet/mellanox/mlx5/core/Makefile | 3 + drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 +- .../net/ethernet/mellanox/mlx5/core/en/fs.h | 2 +- .../ethernet/mellanox/mlx5/core/en/params.c | 4 +- .../mellanox/mlx5/core/en_accel/en_accel.h | 50 +- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 2 +- .../mellanox/mlx5/core/en_accel/psp.c | 195 +++++ .../mellanox/mlx5/core/en_accel/psp.h | 49 ++ .../mellanox/mlx5/core/en_accel/psp_fs.c | 736 ++++++++++++++++++ .../mellanox/mlx5/core/en_accel/psp_fs.h | 30 + .../mellanox/mlx5/core/en_accel/psp_offload.c | 44 ++ .../mellanox/mlx5/core/en_accel/psp_rxtx.c | 200 +++++ .../mellanox/mlx5/core/en_accel/psp_rxtx.h | 121 +++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 9 + .../net/ethernet/mellanox/mlx5/core/en_rx.c | 49 +- .../net/ethernet/mellanox/mlx5/core/en_tx.c | 10 +- drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 + .../ethernet/mellanox/mlx5/core/lib/crypto.h | 1 + .../net/ethernet/mellanox/mlx5/core/main.c | 1 + .../mellanox/mlx5/core/steering/hws/definer.c | 2 +- include/linux/mlx5/device.h | 4 + include/linux/mlx5/mlx5_ifc.h | 95 ++- include/linux/netdevice.h | 4 + include/linux/skbuff.h | 3 + include/net/dropreason-core.h | 6 + include/net/inet_timewait_sock.h | 8 + include/net/psp.h | 12 + include/net/psp/functions.h | 206 +++++ include/net/psp/types.h | 184 +++++ include/net/sock.h | 26 +- include/uapi/linux/psp.h | 66 ++ net/Kconfig | 1 + net/Makefile | 1 + net/core/dev.c | 32 + net/core/gro.c | 2 + net/core/skbuff.c | 4 + net/ipv4/af_inet.c | 2 + net/ipv4/inet_timewait_sock.c | 6 +- net/ipv4/ip_output.c | 5 +- net/ipv4/tcp.c | 2 + net/ipv4/tcp_ipv4.c | 18 +- net/ipv4/tcp_minisocks.c | 20 + net/ipv4/tcp_output.c | 17 +- net/ipv6/ipv6_sockglue.c | 6 +- net/ipv6/tcp_ipv6.c | 17 +- net/psp/Kconfig | 15 + net/psp/Makefile | 5 + net/psp/psp-nl-gen.c | 119 +++ net/psp/psp-nl-gen.h | 39 + net/psp/psp.h | 54 ++ net/psp/psp_main.c | 278 +++++++ net/psp/psp_nl.c | 505 ++++++++++++ net/psp/psp_sock.c | 302 +++++++ tools/net/ynl/Makefile.deps | 1 + 58 files changed, 3905 insertions(+), 62 deletions(-) create mode 100644 Documentation/netlink/specs/psp.yaml create mode 100644 Documentation/networking/psp.rst create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_offload.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h create mode 100644 include/net/psp.h create mode 100644 include/net/psp/functions.h create mode 100644 include/net/psp/types.h create mode 100644 include/uapi/linux/psp.h create mode 100644 net/psp/Kconfig create mode 100644 net/psp/Makefile create mode 100644 net/psp/psp-nl-gen.c create mode 100644 net/psp/psp-nl-gen.h create mode 100644 net/psp/psp.h create mode 100644 net/psp/psp_main.c create mode 100644 net/psp/psp_nl.c create mode 100644 net/psp/psp_sock.c
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 1/19 psp: add documentation
From: Jakub Kicinski <[email protected]>
Add documentation of things which belong in the docs rather than commit messages.
---
Notes:
v3:
- reword driver requirement about double rotating keys when the device supports requesting arbitrary spi key pairs.
v2:
- add note about MITM deletion attack, and expectation from userspace
- add information about accepting clear text ACKs, RSTs, and FINs to Securing Connections section.
v1:
- https://lore.kernel.org/netdev/[email protected]/
Documentation/networking/index.rst | 1 + Documentation/networking/psp.rst | 183 +++++++++++++++++++++++++++++ 2 files changed, 184 insertions(+) create mode 100644 Documentation/networking/psp.rst
Documentation/networking/index.rst +1 -0
@@ -101,6 +101,7 @@ Contents: ppp_generic proc_net_tcp pse-pd/index + psp radiotap-headers rds regulatory
Documentation/networking/psp.rst new file +183 -0
183 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 2/19 psp: base PSP device support
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
Add a netlink family for PSP and allow drivers to register support.
The "PSP device" is its own object. This allows us to perform more flexible reference counting / lifetime control than if PSP information was part of net_device. In the future we should also be able to "delegate" PSP access to software devices, such as *vlan, veth or netkit more easily.
---
Notes:
v7:
- add comment explaining use of xa_store()/xa_erase() in
psp_dev_unregister()/psp_dev_destroy().
v4:
- remove unused PSP_KEY_V0/PSP_KEY_V1 defines
v1:
- https://lore.kernel.org/netdev/[email protected]/Documentation/netlink/specs/psp.yaml | 96 ++++++++++++ include/linux/netdevice.h | 4 + include/net/psp.h | 12 ++ include/net/psp/functions.h | 14 ++ include/net/psp/types.h | 100 ++++++++++++ include/uapi/linux/psp.h | 42 +++++ net/Kconfig | 1 + net/Makefile | 1 + net/psp/Kconfig | 13 ++ net/psp/Makefile | 5 + net/psp/psp-nl-gen.c | 65 ++++++++ net/psp/psp-nl-gen.h | 30 ++++ net/psp/psp.h | 31 ++++ net/psp/psp_main.c | 139 +++++++++++++++++ net/psp/psp_nl.c | 223 +++++++++++++++++++++++++++ tools/net/ynl/Makefile.deps | 1 + 16 files changed, 777 insertions(+) create mode 100644 Documentation/netlink/specs/psp.yaml create mode 100644 include/net/psp.h create mode 100644 include/net/psp/functions.h create mode 100644 include/net/psp/types.h create mode 100644 include/uapi/linux/psp.h create mode 100644 net/psp/Kconfig create mode 100644 net/psp/Makefile create mode 100644 net/psp/psp-nl-gen.c create mode 100644 net/psp/psp-nl-gen.h create mode 100644 net/psp/psp.h create mode 100644 net/psp/psp_main.c create mode 100644 net/psp/psp_nl.c
Documentation/netlink/specs/psp.yaml new file +96 -0
@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) +--- +name: psp + +doc: + PSP Security Protocol Generic Netlink family. + +definitions: + - + type: enum + name: version + entries: [hdr0-aes-gcm-128, hdr0-aes-gcm-256, + hdr0-aes-gmac-128, hdr0-aes-gmac-256] + +attribute-sets: + - + name: dev + attributes: + - + name: id + doc: PSP device ID. + type: u32 + checks: + min: 1 + - + name: ifindex + doc: ifindex of the main netdevice linked to the PSP device. + type: u32 + - + name: psp-versions-cap + doc: Bitmask of PSP versions supported by the device. + type: u32 + enum: version + enum-as-flags: true + - + name: psp-versions-ena + doc: Bitmask of currently enabled (accepted on Rx) PSP versions. + type: u32 + enum: version + enum-as-flags: true + +operations: + list: + - + name: dev-get + doc: Get / dump information about PSP capable devices on the system. + attribute-set: dev + do: + request: + attributes: + - id + reply: &dev-all + attributes: + - id + - ifindex + - psp-versions-cap + - psp-versions-ena + pre: psp-device-get-locked + post: psp-device-unlock + dump: + reply: *dev-all + - + name: dev-add-ntf + doc: Notification about device appearing. + notify: dev-get + mcgrp: mgmt + - + name: dev-del-ntf + doc: Notification about device disappearing. + notify: dev-get + mcgrp: mgmt + - + name: dev-set + doc: Set the configuration of a PSP device. + attribute-set: dev + do: + request: + attributes: + - id + - psp-versions-ena + reply: + attributes: [] + pre: psp-device-get-locked + post: psp-device-unlock + - + name: dev-change-ntf + doc: Notification about device configuration being changed. + notify: dev-get + mcgrp: mgmt + +mcast-groups: + list: + - + name: mgmt + +...
include/linux/netdevice.h +4 -0
@@ -1906,6 +1906,7 @@ enum netdev_reg_state {* device struct * @mpls_ptr: mpls_dev struct pointer * @mctp_ptr: MCTP specific data +* @psp_dev: PSP crypto device registered for this netdev * * @dev_addr: Hw address (before bcast, * because most packets are unicast)
@@ -2310,6 +2311,9 @@ struct net_device {#if IS_ENABLED (CONFIG_MCTP )struct mctp_dev __rcu *mctp_ptr;#endif +#if IS_ENABLED (CONFIG_INET_PSP ) +struct psp_dev __rcu *psp_dev; +#endif /* * Cache lines mostly used on receive path (including eth_type_trans())
include/net/psp.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __NET_PSP_ALL_H +#define __NET_PSP_ALL_H + +#include <uapi/linux/psp.h> +#include <net/psp/functions.h> +#include <net/psp/types.h> + +/* Do not add any code here. Put it in the sub-headers instead. */ + +#endif /* __NET_PSP_ALL_H */
include/net/psp/functions.h new file +14 -0
@@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __NET_PSP_HELPERS_H +#define __NET_PSP_HELPERS_H + +#include <net/psp/types.h> + +/* Driver-facing API */ +struct psp_dev * +psp_dev_create (struct net_device *netdev,struct psp_dev_ops *psd_ops, +struct psp_dev_caps *psd_caps,void *priv_ptr); +void psp_dev_unregister (struct psp_dev *psd); + +#endif /* __NET_PSP_HELPERS_H */
include/net/psp/types.h new file +100 -0
100 lines not on this page · raw message
include/uapi/linux/psp.h new file +42 -0
42 lines not on this page · raw message
net/Kconfig +1 -0
@@ -82,6 +82,7 @@ config NET_CRC32C menu "Networking options" source "net/packet/Kconfig" +source "net/psp/Kconfig" source "net/unix/Kconfig" source "net/tls/Kconfig" source "net/xfrm/Kconfig"
net/Makefile +1 -0
@@ -18,6 +18,7 @@ obj-$(CONFIG_INET) += ipv4/ obj-$(CONFIG_TLS) += tls/ obj-$(CONFIG_XFRM) += xfrm/ obj-$(CONFIG_UNIX) += unix/ +obj-$(CONFIG_INET_PSP) += psp/ obj-y += ipv6/ obj-$(CONFIG_PACKET) += packet/ obj-$(CONFIG_NET_KEY) += key/
net/psp/Kconfig new file +13 -0
@@ -0,0 +1,13 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# PSP configuration +# +config INET_PSP + bool "PSP Security Protocol support" + depends on INET + help + Enable kernel support for the PSP protocol. + For more information see: + https://raw.githubusercontent.com/google/psp/main/doc/PSP_Arch_Spec.pdf + + If unsure, say N.
net/psp/Makefile new file +5 -0
@@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_INET_PSP) += psp.o + +psp-y := psp_main.o psp_nl.o psp-nl-gen.o
net/psp/psp-nl-gen.c new file +65 -0
65 lines not on this page · raw message
net/psp/psp-nl-gen.h new file +30 -0
@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */ +/* Do not edit directly, auto-generated from: */ +/* Documentation/netlink/specs/psp.yaml */ +/* YNL-GEN kernel header */ + +#ifndef _LINUX_PSP_GEN_H +#define _LINUX_PSP_GEN_H + +#include <net/netlink.h> +#include <net/genetlink.h> + +#include <uapi/linux/psp.h> + +int psp_device_get_locked (const struct genl_split_ops *ops, +struct sk_buff *skb,struct genl_info *info); +void +psp_device_unlock (const struct genl_split_ops *ops,struct sk_buff *skb, +struct genl_info *info); + +int psp_nl_dev_get_doit (struct sk_buff *skb,struct genl_info *info); +int psp_nl_dev_get_dumpit (struct sk_buff *skb,struct netlink_callback *cb); +int psp_nl_dev_set_doit (struct sk_buff *skb,struct genl_info *info); + +enum { +PSP_NLGRP_MGMT , +}; + +extern struct genl_family psp_nl_family; + +#endif /* _LINUX_PSP_GEN_H */
net/psp/psp.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __PSP_PSP_H +#define __PSP_PSP_H + +#include <linux/list.h> +#include <linux/mutex.h> +#include <net/netns/generic.h> +#include <net/psp.h> +#include <net/sock.h> + +extern struct xarray psp_devs; +extern struct mutex psp_devs_lock; + +void psp_dev_destroy (struct psp_dev *psd); +int psp_dev_check_access (struct psp_dev *psd,struct net *net); + +void psp_nl_notify_dev (struct psp_dev *psd,u32 cmd); + +static inline void psp_dev_get (struct psp_dev *psd) +{ +refcount_inc (&psd->refcnt); +} + +static inline void psp_dev_put (struct psp_dev *psd) +{ +if (refcount_dec_and_test (&psd->refcnt)) +psp_dev_destroy (psd); +} + +#endif /* __PSP_PSP_H */
net/psp/psp_main.c new file +139 -0
139 lines not on this page · raw message
net/psp/psp_nl.c new file +223 -0
223 lines not on this page · raw message
tools/net/ynl/Makefile.deps +1 -0
@@ -31,6 +31,7 @@ CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h) CFLAGS_ovs_datapath:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h) CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h) CFLAGS_ovs_vport:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h) +CFLAGS_psp:=$(call get_hdr_inc,_LINUX_PSP_H,psp.h) CFLAGS_rt-addr:=$(call get_hdr_inc,__LINUX_RTNETLINK_H,rtnetlink.h) \ $(call get_hdr_inc,__LINUX_IF_ADDR_H,if_addr.h) CFLAGS_rt-link:=$(call get_hdr_inc,__LINUX_RTNETLINK_H,rtnetlink.h) \
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 3/19 net: modify core data structures for PSP datapath support
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
Add pointers to psp data structures to core networking structs, and an SKB extension to carry the PSP information from the drivers to the socket layer.
---
Notes:
v2:
- Add dev_id field to psp_skb_ext
- Move psp_assoc from struct tcp_timewait_sock to struct inet_timewait_sock
- Move psp_sk_assoc_free() from sk_common_release() to inet_sock_destruct()
v1:
- https://lore.kernel.org/netdev/[email protected]/
include/linux/skbuff.h | 3 +++ include/net/inet_timewait_sock.h | 3 +++ include/net/psp/functions.h | 6 ++++++ include/net/psp/types.h | 7 +++++++ include/net/sock.h | 4 ++++ net/core/skbuff.c | 4 ++++ net/ipv4/af_inet.c | 2 ++ net/ipv4/tcp_minisocks.c | 2 ++ 8 files changed, 31 insertions(+)
include/linux/skbuff.h +3 -0
@@ -4899,6 +4899,9 @@ enum skb_ext_id {#endif #if IS_ENABLED (CONFIG_MCTP_FLOWS ) SKB_EXT_MCTP, +#endif +#if IS_ENABLED (CONFIG_INET_PSP ) +SKB_EXT_PSP , #endif SKB_EXT_NUM, /* must be last */ };
include/net/inet_timewait_sock.h +3 -0
@@ -81,6 +81,9 @@ struct inet_timewait_sock {struct timer_list tw_timer;struct inet_bind_bucket *tw_tb;struct inet_bind2_bucket *tw_tb2; +#if IS_ENABLED (CONFIG_INET_PSP ) +struct psp_assoc __rcu *psp_assoc; +#endif };#define tw_tclass tw_tos
include/net/psp/functions.h +6 -0
@@ -5,10 +5,16 @@#include <net/psp/types.h> +struct inet_timewait_sock ; +/* Driver-facing API */ struct psp_dev *psp_dev_create (struct net_device *netdev,struct psp_dev_ops *psd_ops,struct psp_dev_caps *psd_caps,void *priv_ptr);void psp_dev_unregister (struct psp_dev *psd); +/* Kernel-facing API */ +static inline void psp_sk_assoc_free (struct sock *sk) { } +static inline void psp_twsk_assoc_free (struct inet_timewait_sock *tw) { } +#endif /* __NET_PSP_HELPERS_H */
include/net/psp/types.h +7 -0
@@ -84,6 +84,13 @@ struct psp_dev_caps {#define PSP_MAX_KEY 32 +struct psp_skb_ext { +__be32 spi; +u16 dev_id; +u8 generation; +u8 version; +}; +/** * struct psp_dev_ops - netdev driver facing PSP callbacks */
include/net/sock.h +4 -0
@@ -249,6 +249,7 @@ struct sk_filter;* @sk_dst_cache: destination cache * @sk_dst_pending_confirm: need to confirm neighbour * @sk_policy: flow policy +* @psp_assoc: PSP association, if socket is PSP-secured * @sk_receive_queue: incoming packets * @sk_wmem_alloc: transmit queue bytes committed * @sk_tsq_flags: TCP Small Queues flags
@@ -446,6 +447,9 @@ struct sock {struct mem_cgroup *sk_memcg;#ifdef CONFIG_XFRM struct xfrm_policy __rcu *sk_policy[2 ]; +#endif +#if IS_ENABLED (CONFIG_INET_PSP ) +struct psp_assoc __rcu *psp_assoc;#endif __cacheline_group_end (sock_read_rxtx);
net/core/skbuff.c +4 -0
@@ -79,6 +79,7 @@#include <net/mptcp.h> #include <net/mctp.h> #include <net/page_pool/helpers.h> +#include <net/psp/types.h> #include <net/dropreason.h> #include <linux/uaccess.h>
@@ -5060,6 +5061,9 @@ static const u8 skb_ext_type_len[] = {#if IS_ENABLED (CONFIG_MCTP_FLOWS ) [SKB_EXT_MCTP] = SKB_EXT_CHUNKSIZEOF(struct mctp_flow), #endif +#if IS_ENABLED(CONFIG_INET_PSP) + [SKB_EXT_PSP] = SKB_EXT_CHUNKSIZEOF(struct psp_skb_ext), +#endif }; static __always_inline unsigned int skb_ext_total_length(void)
net/ipv4/af_inet.c +2 -0
@@ -102,6 +102,7 @@#include <net/gro.h> #include <net/gso.h> #include <net/tcp.h> +#include <net/psp.h> #include <net/udp.h> #include <net/udplite.h> #include <net/ping.h>
@@ -158,6 +159,7 @@ void inet_sock_destruct(struct sock *sk)kfree (rcu_dereference_protected (inet->inet_opt,1 ));dst_release (rcu_dereference_protected (sk->sk_dst_cache,1 ));dst_release (rcu_dereference_protected (sk->sk_rx_dst,1 )); +psp_sk_assoc_free (sk); }EXPORT_SYMBOL (inet_sock_destruct);
net/ipv4/tcp_minisocks.c +2 -0
@@ -23,6 +23,7 @@#include <net/xfrm.h> #include <net/busy_poll.h> #include <net/rstreason.h> +#include <net/psp.h> static bool tcp_in_window (u32 seq,u32 end_seq,u32 s_win,u32 e_win) {
@@ -400,6 +401,7 @@ void tcp_twsk_destructor(struct sock *sk) }#endif tcp_ao_destroy_sock (sk, true); +psp_twsk_assoc_free (inet_twsk (sk)); }EXPORT_IPV6_MOD_GPL (tcp_twsk_destructor);
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 4/19 tcp: add datapath logic for PSP with inline key exchange
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
Add validation points and state propagation to support PSP key exchange inline, on TCP connections. The expectation is that application will use some well established mechanism like TLS handshake to establish a secure channel over the connection and if both endpoints are PSP-capable - exchange and install PSP keys. Because the connection can existing in PSP-unsecured and PSP-secured state we need to make sure that there are no race conditions or retransmission leaks.
On Tx - mark packets with the skb->decrypted bit when PSP key is at the enqueue time. Drivers should only encrypt packets with this bit set. This prevents retransmissions getting encrypted when original transmission was not. Similarly to TLS, we'll use sk->sk_validate_xmit_skb to make sure PSP skbs can't "escape" via a PSP-unaware device without being encrypted.
On Rx - validation is done under socket lock. This moves the validation point later than xfrm, for example. Please see the documentation patch for more details on the flow of securing a connection, but for the purpose of this patch what's important is that we want to enforce the invariant that once connection is secured any skb in the receive queue has been encrypted with PSP.
Add GRO and coalescing checks to prevent PSP authenticated data from being combined with cleartext data, or data with non-matching PSP state. On Rx, check skb's with psp_skb_coalesce_diff() at points before psp_sk_rx_policy_check(). After skb's are policy checked and on the socket receive queue, skb_cmp_decrypted() is sufficient for checking for coalescable PSP state. On Tx, tcp_write_collapse_fence() should be called when transitioning a socket into PSP Tx state to prevent data sent as cleartext from being coalesced with PSP encapsulated data.
This change only adds the validation points, for ease of review. Subsequent change will add the ability to install keys, and flesh the enforcement logic out
---
Notes:
v7:
- add comments about GRO and TCP coalescing to the commit message. v4:
- add comment to tcp_timewait_state_process() explaining TCP_TW_SYN case.
- psp_twsk_init() accepts const pointer, so caller does not need to cast const away.
- add missing psp_twsk_rx_policy_check() to TCP_TW_SYN case of do_timewait in tcp_v4_rcv().
v3:
- psp_reply_set_decrypted() does not use stuct sock* arg. Drop it. v2:
- Add psp_reply_set_decrypted() to encapsulate ACKs, FINs, and RSTs sent from control socks on behalf of full or timewait socks with PSP state.
v1:
- https://lore.kernel.org/netdev/[email protected]/
include/net/dropreason-core.h | 6 +++ include/net/psp/functions.h | 77 +++++++++++++++++++++++++++++++++++ net/core/gro.c | 2 + net/ipv4/inet_timewait_sock.c | 3 +- net/ipv4/ip_output.c | 5 ++- net/ipv4/tcp.c | 2 + net/ipv4/tcp_ipv4.c | 14 ++++++- net/ipv4/tcp_minisocks.c | 18 ++++++++ net/ipv4/tcp_output.c | 17 +++++--- net/ipv6/tcp_ipv6.c | 11 +++++ net/psp/Kconfig | 1 + 11 files changed, 147 insertions(+), 9 deletions(-)
include/net/dropreason-core.h +6 -0
@@ -127,6 +127,8 @@ FN(CANXL_RX_INVALID_FRAME) \ FN(PFMEMALLOC) \ FN(DUALPI2_STEP_DROP) \ + FN(PSP_INPUT) \ + FN(PSP_OUTPUT) \ FNe(MAX)/**
@@ -610,6 +612,10 @@ enum skb_drop_reason {* threshold of DualPI2 qdisc. */ SKB_DROP_REASON_DUALPI2_STEP_DROP , +/** @SKB_DROP_REASON_PSP_INPUT: PSP input checks failed */ +SKB_DROP_REASON_PSP_INPUT , +/** @SKB_DROP_REASON_PSP_OUTPUT: PSP output checks failed */ + SKB_DROP_REASON_PSP_OUTPUT,/** * @SKB_DROP_REASON_MAX: the maximum of core drop reasons, which * shouldn't be used as a real 'reason' - only for tracing code gen
include/net/psp/functions.h +77 -0
90 lines not on this page · raw message
net/core/gro.c +2 -0
@@ -1,4 +1,5 @@// SPDX-License-Identifier: GPL-2.0-or-later +#include <net/psp.h> #include <net/gro.h> #include <net/dst_metadata.h> #include <net/busy_poll.h>
@@ -376,6 +377,7 @@ static void gro_list_prepare(const struct list_head *head, diffs |=skb_get_nfct (p) ^skb_get_nfct (skb); diffs |=gro_list_prepare_tc_ext (skb, p, diffs); + diffs |=__psp_skb_coalesce_diff (skb, p, diffs); }NAPI_GRO_CB (p)->same_flow = !diffs;
net/ipv4/inet_timewait_sock.c +2 -1
@@ -15,7 +15,7 @@#include <net/inet_hashtables.h> #include <net/inet_timewait_sock.h> #include <net/ip.h> - +#include <net/psp.h> /** * inet_twsk_bind_unhash - unhash a timewait socket from bind hash
@@ -218,6 +218,7 @@ struct inet_timewait_sock *inet_twsk_alloc(const struct sock *sk,refcount_set (&tw->tw_refcnt,0 );__module_get (tw->tw_prot->owner); +psp_twsk_init (tw, sk); }return tw;
net/ipv4/ip_output.c +4 -1
@@ -83,6 +83,7 @@#include <linux/netfilter_bridge.h> #include <linux/netlink.h> #include <linux/tcp.h> +#include <net/psp.h> static int ip_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
@@ -1664,8 +1665,10 @@ void ip_send_unicast_reply(struct sock *sk, const struct sock *orig_sk, arg->csumoffset) = csum_fold(csum_add(nskb->csum, arg->csum)); nskb->ip_summed =CHECKSUM_NONE ; -if (orig_sk) +if (orig_sk) {skb_set_owner_edemux (nskb, (struct sock *)orig_sk); +psp_reply_set_decrypted (nskb); + }if (transmit_time) nskb->tstamp_type =SKB_CLOCK_MONOTONIC ;if (txhash)
net/ipv4/tcp.c +2 -0
@@ -275,6 +275,7 @@#include <net/proto_memory.h> #include <net/xfrm.h> #include <net/ip.h> +#include <net/psp.h> #include <net/sock.h> #include <net/rstreason.h>
@@ -687,6 +688,7 @@ void tcp_skb_entail(struct sock *sk, struct sk_buff *skb) tcb->seq = tcb->end_seq = tp->write_seq; tcb->tcp_flags =TCPHDR_ACK ;__skb_header_release (skb); +psp_enqueue_set_decrypted (sk, skb);tcp_add_write_queue_tail (sk, skb);sk_wmem_queued_add (sk, skb->truesize);sk_mem_charge (sk, skb->truesize);
net/ipv4/tcp_ipv4.c +13 -1
@@ -74,6 +74,7 @@#include <net/secure_seq.h> #include <net/busy_poll.h> #include <net/rstreason.h> +#include <net/psp.h> #include <linux/inet.h> #include <linux/ipv6.h>
@@ -1907,6 +1908,10 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)enum skb_drop_reason reason;struct sock *rsk; + reason =psp_sk_rx_policy_check (sk, skb); +if (reason) + goto err_discard; +if (sk->sk_state ==TCP_ESTABLISHED ) {/* Fast path */ struct dst_entry *dst;
@@ -1968,6 +1973,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb) reason =SKB_DROP_REASON_TCP_CSUM ;trace_tcp_bad_csum (skb);TCP_INC_STATS (sock_net (sk),TCP_MIB_CSUMERRORS ); +err_discard:TCP_INC_STATS (sock_net (sk),TCP_MIB_INERRS ); goto discard; }
@@ -2070,7 +2076,9 @@ bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb, (TCPHDR_ECE | TCPHDR_CWR | TCPHDR_AE)) || !tcp_skb_can_collapse_rx (tail, skb) || thtail->doff != th->doff || - memcmp(thtail + 1, th + 1, hdrlen - sizeof(*th))) +memcmp (thtail +1 , th +1 , hdrlen -sizeof (*th)) || +/* prior to PSP Rx policy check, retain exact PSP metadata */ + psp_skb_coalesce_diff(tail, skb)) goto no_coalesce;__skb_pull (skb, hdrlen);
@@ -2441,6 +2449,10 @@ int tcp_v4_rcv(struct sk_buff *skb)__this_cpu_write (tcp_tw_isn, isn); goto process; } + + drop_reason =psp_twsk_rx_policy_check (inet_twsk (sk), skb); +if (drop_reason) +break ; }/* to ACK */ fallthrough;
net/ipv4/tcp_minisocks.c +18 -0
@@ -104,9 +104,16 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,struct tcp_timewait_sock *tcptw =tcp_twsk ((struct sock *)tw);u32 rcv_nxt =READ_ONCE (tcptw->tw_rcv_nxt);struct tcp_options_received tmp_opt; +enum skb_drop_reason psp_drop;bool paws_reject = false;int ts_recent_stamp; +/* Instead of dropping immediately, wait to see what value is +* returned. We will accept a non psp-encapsulated syn in the +* case where TCP_TW_SYN is returned. +*/ + psp_drop =psp_twsk_rx_policy_check (tw, skb); + tmp_opt.saw_tstamp =0 ; ts_recent_stamp =READ_ONCE (tcptw->tw_ts_recent_stamp);if (th->doff > (sizeof (*th) >>2 ) && ts_recent_stamp) {
@@ -124,6 +131,9 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, if (READ_ONCE(tw->tw_substate) == TCP_FIN_WAIT2) { /* Just repeat all the checks of tcp_rcv_state_process() */ + if (psp_drop) + goto out_put; + /* Out of window, send ACK */ if (paws_reject || !tcp_in_window(TCP_SKB_CB(skb)->seq, TCP_SKB_CB(skb)->end_seq,
@@ -194,6 +204,9 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, (TCP_SKB_CB(skb)->seq == TCP_SKB_CB(skb)->end_seq || th->rst))) {/* In window segment, it may be only reset or bare ack. */ +if (psp_drop) + goto out_put; +if (th->rst) {/* This is TIME_WAIT assassination, in two flavors. * Oh well... nobody has a sufficient solution to this
@@ -247,6 +260,9 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,return TCP_TW_SYN ; } +if (psp_drop) + goto out_put; +if (paws_reject) { *drop_reason =SKB_DROP_REASON_TCP_RFC7323_TW_PAWS ;__NET_INC_STATS (twsk_net (tw),LINUX_MIB_PAWS_TW_REJECTED );
@@ -265,6 +281,8 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,return tcp_timewait_check_oow_rate_limit ( tw, skb,LINUX_MIB_TCPACKSKIPPEDTIMEWAIT ); } + +out_put:inet_twsk_put (tw);return TCP_TW_SUCCESS ; }
net/ipv4/tcp_output.c +11 -6
@@ -40,6 +40,7 @@#include <net/tcp.h> #include <net/mptcp.h> #include <net/proto_memory.h> +#include <net/psp.h> #include <linux/compiler.h> #include <linux/gfp.h>
@@ -403,13 +404,15 @@ static void tcp_ecn_send(struct sock *sk, struct sk_buff *skb,/* Constructs common control bits of non-data skb. If SYN/FIN is present, * auto increment end seqno. */ -static void tcp_init_nondata_skb (struct sk_buff *skb,u32 seq,u16 flags) +static void tcp_init_nondata_skb (struct sk_buff *skb,struct sock *sk, +u32 seq,u16 flags) { skb->ip_summed =CHECKSUM_PARTIAL ;TCP_SKB_CB (skb)->tcp_flags = flags;tcp_skb_pcount_set (skb,1 ); +psp_enqueue_set_decrypted (sk, skb);TCP_SKB_CB (skb)->seq = seq;if (flags & (TCPHDR_SYN |TCPHDR_FIN ))
@@ -1510,6 +1513,7 @@ static void tcp_queue_skb(struct sock *sk, struct sk_buff *skb)/* Advance write_seq and place onto the write_queue. */ WRITE_ONCE (tp->write_seq,TCP_SKB_CB (skb)->end_seq);__skb_header_release (skb); +psp_enqueue_set_decrypted (sk, skb);tcp_add_write_queue_tail (sk, skb);sk_wmem_queued_add (sk, skb->truesize);sk_mem_charge (sk, skb->truesize);
@@ -3625,7 +3629,7 @@ void tcp_send_fin(struct sock *sk)skb_reserve (skb,MAX_TCP_HEADER );sk_forced_mem_schedule (sk, skb->truesize);/* FIN eats a sequence byte, write_seq advanced by tcp_queue_skb(). */ -tcp_init_nondata_skb (skb, tp->write_seq, +tcp_init_nondata_skb (skb, sk, tp->write_seq,TCPHDR_ACK |TCPHDR_FIN );tcp_queue_skb (sk, skb); }
@@ -3653,7 +3657,7 @@ void tcp_send_active_reset(struct sock *sk, gfp_t priority,/* Reserve space for headers and prepare control bits. */ skb_reserve (skb,MAX_TCP_HEADER ); -tcp_init_nondata_skb (skb,tcp_acceptable_seq (sk), +tcp_init_nondata_skb (skb, sk,tcp_acceptable_seq (sk),TCPHDR_ACK |TCPHDR_RST );tcp_mstamp_refresh (tcp_sk (sk));/* Send it off. */
@@ -4148,7 +4152,7 @@ int tcp_connect(struct sock *sk)/* SYN eats a sequence byte, write_seq updated by * tcp_connect_queue_skb(). */ -tcp_init_nondata_skb (buff, tp->write_seq,TCPHDR_SYN ); +tcp_init_nondata_skb (buff, sk, tp->write_seq,TCPHDR_SYN );tcp_mstamp_refresh (tp); tp->retrans_stamp =tcp_time_stamp_ts (tp);tcp_connect_queue_skb (sk, buff);
@@ -4273,7 +4277,8 @@ void __tcp_send_ack(struct sock *sk, u32 rcv_nxt, u16 flags)/* Reserve space for headers and prepare control bits. */ skb_reserve (buff,MAX_TCP_HEADER ); -tcp_init_nondata_skb (buff,tcp_acceptable_seq (sk),TCPHDR_ACK | flags); +tcp_init_nondata_skb (buff, sk, +tcp_acceptable_seq (sk),TCPHDR_ACK | flags);/* We do not want pure acks influencing TCP Small Queues or fq/pacing * too much.
@@ -4319,7 +4324,7 @@ static int tcp_xmit_probe_skb(struct sock *sk, int urgent, int mib)* end to send an ack. Don't queue or clone SKB, just * send it. */ -tcp_init_nondata_skb (skb, tp->snd_una - !urgent,TCPHDR_ACK ); +tcp_init_nondata_skb (skb, sk, tp->snd_una - !urgent,TCPHDR_ACK );NET_INC_STATS (sock_net (sk), mib);return tcp_transmit_skb (sk, skb,0 , (__force gfp_t )0 ); }
net/ipv6/tcp_ipv6.c +11 -0
@@ -62,6 +62,7 @@#include <net/hotdata.h> #include <net/busy_poll.h> #include <net/rstreason.h> +#include <net/psp.h> #include <linux/proc_fs.h> #include <linux/seq_file.h>
@@ -973,6 +974,7 @@ static void tcp_v6_send_response(const struct sock *sk, struct sk_buff *skb, u32if (sk) {/* unconstify the socket only to attach it to buff with care. */ skb_set_owner_edemux (buff, (struct sock *)sk); +psp_reply_set_decrypted (buff);if (sk->sk_state ==TCP_TIME_WAIT ) mark =inet_twsk (sk)->tw_mark;
@@ -1608,6 +1610,10 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)if (skb->protocol ==htons (ETH_P_IP ))return tcp_v4_do_rcv (sk, skb); + reason =psp_sk_rx_policy_check (sk, skb); +if (reason) + goto err_discard; +/* * socket locking is here for SMP purposes as backlog rcv * is currently called with bh processing disabled.
@@ -1687,6 +1693,7 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) reason =SKB_DROP_REASON_TCP_CSUM ;trace_tcp_bad_csum (skb);TCP_INC_STATS (sock_net (sk),TCP_MIB_CSUMERRORS ); +err_discard:TCP_INC_STATS (sock_net (sk),TCP_MIB_INERRS ); goto discard;
@@ -1992,6 +1999,10 @@ INDIRECT_CALLABLE_SCOPE int tcp_v6_rcv(struct sk_buff *skb)__this_cpu_write (tcp_tw_isn, isn); goto process; } + + drop_reason =psp_twsk_rx_policy_check (inet_twsk (sk), skb); +if (drop_reason) +break ; }/* to ACK */ fallthrough;
net/psp/Kconfig +1 -0
@@ -5,6 +5,7 @@ config INET_PSP bool "PSP Security Protocol support" depends on INET + select SKB_DECRYPTED help Enable kernel support for the PSP protocol. For more information see:
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 5/19 psp: add op for rotation of device key
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
Rotating the device key is a key part of the PSP protocol design. Some external daemon needs to do it once a day, or so. Add a netlink op to perform this operation.
Add a notification group for informing users that key has been rotated and they should rekey (next rotation will cut them off).
---
Notes:
v6:
- use PSP_CMD_KEY_ROTATE_NTF instead of PSP_CMD_KEY_ROTATE as arg to genl_info_init_ntf()
v1:
- https://lore.kernel.org/netdev/[email protected]/
Documentation/netlink/specs/psp.yaml | 21 +++++++++++++++ include/net/psp/types.h | 5 ++++ include/uapi/linux/psp.h | 3 +++ net/psp/psp-nl-gen.c | 15 +++++++++++ net/psp/psp-nl-gen.h | 2 ++ net/psp/psp_main.c | 3 ++- net/psp/psp_nl.c | 40 ++++++++++++++++++++++++++++ 7 files changed, 88 insertions(+), 1 deletion(-)
Documentation/netlink/specs/psp.yaml +21 -0
@@ -88,9 +88,30 @@ operations: notify: dev-get mcgrp: mgmt + - + name: key-rotate + doc: Rotate the device key. + attribute-set: dev + do: + request: + attributes: + - id + reply: + attributes: + - id + pre: psp-device-get-locked + post: psp-device-unlock + - + name: key-rotate-ntf + doc: Notification about device key getting rotated. + notify: key-rotate + mcgrp: use + mcast-groups: list: - name: mgmt + - + name: use ...
include/net/psp/types.h +5 -0
@@ -102,6 +102,11 @@ struct psp_dev_ops {*/ int (*set_config)(struct psp_dev *psd,struct psp_dev_config *conf,struct netlink_ext_ack *extack); + +/** +* @key_rotate: rotate the device key +*/ + int (*key_rotate)(struct psp_dev *psd, struct netlink_ext_ack *extack); };#endif /* __NET_PSP_H */
include/uapi/linux/psp.h +3 -0
@@ -32,11 +32,14 @@ enum {PSP_CMD_DEV_DEL_NTF ,PSP_CMD_DEV_SET ,PSP_CMD_DEV_CHANGE_NTF , +PSP_CMD_KEY_ROTATE , +PSP_CMD_KEY_ROTATE_NTF , __PSP_CMD_MAX,PSP_CMD_MAX = (__PSP_CMD_MAX -1 ) };#define PSP_MCGRP_MGMT "mgmt" +#define PSP_MCGRP_USE "use"#endif /* _UAPI_LINUX_PSP_H */
net/psp/psp-nl-gen.c +15 -0
@@ -21,6 +21,11 @@ static const struct nla_policy psp_dev_set_nl_policy[PSP_A_DEV_PSP_VERSIONS_ENA [PSP_A_DEV_PSP_VERSIONS_ENA] = NLA_POLICY_MASK(NLA_U32, 0xf), }; +/* PSP_CMD_KEY_ROTATE - do */ +static const struct nla_policy psp_key_rotate_nl_policy[PSP_A_DEV_ID +1 ] = { + [PSP_A_DEV_ID ] =NLA_POLICY_MIN (NLA_U32 ,1 ), +}; +/* Ops table for psp */ static const struct genl_split_ops psp_nl_ops[] = { {
@@ -46,10 +51,20 @@ static const struct genl_split_ops psp_nl_ops[] = { .maxattr = PSP_A_DEV_PSP_VERSIONS_ENA, .flags = GENL_CMD_CAP_DO, }, + { + .cmd = PSP_CMD_KEY_ROTATE, + .pre_doit = psp_device_get_locked, + .doit = psp_nl_key_rotate_doit, + .post_doit = psp_device_unlock, + .policy = psp_key_rotate_nl_policy, + .maxattr = PSP_A_DEV_ID, + .flags = GENL_CMD_CAP_DO, + }, };static const struct genl_multicast_group psp_nl_mcgrps[] = { [PSP_NLGRP_MGMT ] = {"mgmt" , }, + [PSP_NLGRP_USE ] = {"use" , }, };struct genl_family psp_nl_family__ro_after_init = {
net/psp/psp-nl-gen.h +2 -0
@@ -20,9 +20,11 @@ psp_device_unlock(const struct genl_split_ops *ops, struct sk_buff *skb,int psp_nl_dev_get_doit (struct sk_buff *skb,struct genl_info *info);int psp_nl_dev_get_dumpit (struct sk_buff *skb,struct netlink_callback *cb);int psp_nl_dev_set_doit (struct sk_buff *skb,struct genl_info *info); +int psp_nl_key_rotate_doit (struct sk_buff *skb,struct genl_info *info);enum {PSP_NLGRP_MGMT , +PSP_NLGRP_USE , };extern struct genl_family psp_nl_family;
net/psp/psp_main.c +2 -1
@@ -54,7 +54,8 @@ psp_dev_create(struct net_device *netdev,int err;if (WARN_ON (!psd_caps->versions || - !psd_ops->set_config)) + !psd_ops->set_config || + !psd_ops->key_rotate))return ERR_PTR (-EINVAL ); psd =kzalloc (sizeof (*psd),GFP_KERNEL );
net/psp/psp_nl.c +40 -0
@@ -221,3 +221,43 @@ int psp_nl_dev_set_doit(struct sk_buff *skb, struct genl_info *info)nlmsg_free (rsp);return err; } + +int psp_nl_key_rotate_doit (struct sk_buff *skb,struct genl_info *info) +{ +struct psp_dev *psd = info->user_ptr[0 ]; +struct genl_info ntf_info; +struct sk_buff *ntf, *rsp; +int err; + + rsp =psp_nl_reply_new (info); +if (!rsp) +return -ENOMEM ; + +genl_info_init_ntf (&ntf_info, &psp_nl_family,PSP_CMD_KEY_ROTATE_NTF ); + ntf =psp_nl_reply_new (&ntf_info); +if (!ntf) { + err = -ENOMEM ; + goto err_free_rsp; + } + +if (nla_put_u32 (rsp,PSP_A_DEV_ID , psd->id) || +nla_put_u32 (ntf,PSP_A_DEV_ID , psd->id)) { + err = -EMSGSIZE ; + goto err_free_ntf; + } + + err = psd->ops->key_rotate (psd, info->extack); +if (err) + goto err_free_ntf; + +nlmsg_end (ntf, (struct nlmsghdr *)ntf->data); +genlmsg_multicast_netns (&psp_nl_family,dev_net (psd->main_netdev), ntf, +0 ,PSP_NLGRP_USE ,GFP_KERNEL ); +return psp_nl_reply_send (rsp, info); + +err_free_ntf: +nlmsg_free (ntf); +err_free_rsp: +nlmsg_free (rsp); +return err; +}
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 6/19 net: move sk_validate_xmit_skb() to net/core/dev.c
In reply to Daniel ZahkaMove definition of sk_validate_xmit_skb() from net/core/sock.c to net/core/dev.c.
This change is in preparation of the next patch, where sk_validate_xmit_skb() will need to cast sk to a tcp_timewait_sock *, and access member fields. Including linux/tcp.h from linux/sock.h creates a circular dependency, and dev.c is the only current call site of this function.
---
Notes:
v2:
- patch introduced in v2
include/net/sock.h | 22 ---------------------- net/core/dev.c | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 22 deletions(-)
include/net/sock.h +0 -22
@@ -2870,28 +2870,6 @@ sk_requests_wifi_status(struct sock *sk)return sk &&sk_fullsock (sk) &&sock_flag (sk,SOCK_WIFI_STATUS ); } -/* Checks if this SKB belongs to an HW offloaded socket -* and whether any SW fallbacks are required based on dev. -* Check decrypted mark in case skb_orphan() cleared socket. -*/ -static inline struct sk_buff *sk_validate_xmit_skb (struct sk_buff *skb, -struct net_device *dev) -{ -#ifdef CONFIG_SOCK_VALIDATE_XMIT -struct sock *sk = skb->sk; - -if (sk &&sk_fullsock (sk) && sk->sk_validate_xmit_skb) { - skb = sk->sk_validate_xmit_skb (sk, dev, skb); - }else if (unlikely (skb_is_decrypted (skb))) { -pr_warn_ratelimited ("unencrypted skb with no associated socket - dropping\n" ); -kfree_skb (skb); - skb =NULL ; - } -#endif - -return skb; -} -/* This helper checks if a socket is a LISTEN or NEW_SYN_RECV * SYNACK messages can be attached to either ones (depending on SYNCOOKIE) */
net/core/dev.c +22 -0
@@ -3895,6 +3895,28 @@ int skb_csum_hwoffload_help(struct sk_buff *skb, }EXPORT_SYMBOL (skb_csum_hwoffload_help); +/* Checks if this SKB belongs to an HW offloaded socket +* and whether any SW fallbacks are required based on dev. +* Check decrypted mark in case skb_orphan() cleared socket. +*/ +static struct sk_buff *sk_validate_xmit_skb (struct sk_buff *skb, +struct net_device *dev) +{ +#ifdef CONFIG_SOCK_VALIDATE_XMIT +struct sock *sk = skb->sk; + +if (sk &&sk_fullsock (sk) && sk->sk_validate_xmit_skb) { + skb = sk->sk_validate_xmit_skb (sk, dev, skb); + }else if (unlikely (skb_is_decrypted (skb))) { +pr_warn_ratelimited ("unencrypted skb with no associated socket - dropping\n" ); +kfree_skb (skb); + skb =NULL ; + } +#endif + +return skb; +} +static struct sk_buff *validate_xmit_unreadable_skb (struct sk_buff *skb,struct net_device *dev) {
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 7/19 net: tcp: allow tcp_timewait_sock to validate skbs before handing to device
In reply to Daniel ZahkaProvide a callback to validate skb's originating from tcp timewait socks before passing to the device layer. Full socks have a sk_validate_xmit_skb member for checking that a device is capable of performing offloads required for transmitting an skb. With psp, tcp timewait socks will inherit the crypto state from their corresponding full socks. Any ACKs or RSTs that originate from a tcp timewait sock carrying psp state should be psp encapsulated.
---
Notes:
v3:
- check for sk_is_inet() before casting to inet_twsk() v2:
- patch introduced in v2
include/net/inet_timewait_sock.h | 5 +++++ net/core/dev.c | 14 ++++++++++++-- net/ipv4/inet_timewait_sock.c | 3 +++ 3 files changed, 20 insertions(+), 2 deletions(-)
include/net/inet_timewait_sock.h +5 -0
@@ -84,6 +84,11 @@ struct inet_timewait_sock {#if IS_ENABLED (CONFIG_INET_PSP )struct psp_assoc __rcu *psp_assoc;#endif +#ifdef CONFIG_SOCK_VALIDATE_XMIT +struct sk_buff * (*tw_validate_xmit_skb)(struct sock *sk, +struct net_device *dev, +struct sk_buff *skb); +#endif };#define tw_tclass tw_tos
net/core/dev.c +12 -2
@@ -3903,10 +3903,20 @@ static struct sk_buff *sk_validate_xmit_skb(struct sk_buff *skb, struct net_device *dev) {#ifdef CONFIG_SOCK_VALIDATE_XMIT +struct sk_buff *(*sk_validate)(struct sock *sk,struct net_device *dev, +struct sk_buff *skb);struct sock *sk = skb->sk; -if (sk &&sk_fullsock (sk) && sk->sk_validate_xmit_skb) { - skb = sk->sk_validate_xmit_skb (sk, dev, skb); + sk_validate =NULL ; +if (sk) { +if (sk_fullsock (sk)) + sk_validate = sk->sk_validate_xmit_skb; +else if (sk_is_inet (sk) && sk->sk_state ==TCP_TIME_WAIT ) + sk_validate =inet_twsk (sk)->tw_validate_xmit_skb; + } + +if (sk_validate) { + skb =sk_validate (sk, dev, skb); }else if (unlikely (skb_is_decrypted (skb))) {pr_warn_ratelimited ("unencrypted skb with no associated socket - dropping\n" );kfree_skb (skb);
net/ipv4/inet_timewait_sock.c +3 -0
@@ -210,6 +210,9 @@ struct inet_timewait_sock *inet_twsk_alloc(const struct sock *sk,atomic64_set (&tw->tw_cookie,atomic64_read (&sk->sk_cookie));twsk_net_set (tw,sock_net (sk));timer_setup (&tw->tw_timer, tw_timer_handler,0 ); +#ifdef CONFIG_SOCK_VALIDATE_XMIT + tw->tw_validate_xmit_skb =NULL ; +#endif /* * Because we use RCU lookups, we should not set tw_refcnt * to a non null value before everything is setup for this
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 8/19 net: psp: add socket security association code
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
Add the ability to install PSP Rx and Tx crypto keys on TCP connections. Netlink ops are provided for both operations. Rx side combines allocating a new Rx key and installing it on the socket. Theoretically these are separate actions, but in practice they will always be used one after the other. We can add distinct "alloc" and "install" ops later.
---
Notes:
v7:
- check that 31 LSBs of the SPI are non-zero in psp_nl_parse_key() v6:
- handle failed allocation from psp_assoc_dummy()
v4:
- fix EXPORT_IPV6_MOD_GPL(psp_reply_set_decrypted) semicolon
- remove version from netlink rx-assoc reply
- remove key_sz field from struct psp_assoc
- rename psd_get_for_sock() to psp_dev_get_for_sock()
- use sk_is_tcp() to check sock in psp_assoc_device_get_locked() v3:
- lift pse/pas comparison code into new function:
psp_pse_matches_pas().
- explicitly mark rcu critical section psp_reply_set_decrypted()
- use rcu_dereference_proteced() instead of rcu_read_lock() in psp_sk_assoc_free() and psp_twsk_assoc_free()
- rename psp_is_nondata() to psp_is_allowed_nondata()
- check for sk_is_inet() before casting to inet_twsk()
- psp_reply_set_decrypted() should not call psp_sk_assoc()
- lift common code into psp_sk_get_assoc_rcu()
- Fix exports with EXPORT_IPV6_MOD_GPL()
v2:
- add pas->dev_id == pse->dev_id to policy checks
- __psp_sk_rx_policy_check() now allows pure ACKs, FINs, and RSTs to be non-psp authenticated before "PSP Full" state.
- assign tw_validate_skb funtion during psp_twsk_init()
- psp_skb_get_rcu() also checks if sk is a tcp timewait sock when looking for psp assocs.
- scan ofo queue non-psp data during psp_sock_recv_queue_check()
- add tcp_write_collapse_fence() to psp_sock_assoc_set_tx() v1:
- https://lore.kernel.org/netdev/[email protected]/
Documentation/netlink/specs/psp.yaml | 70 +++++++ include/net/psp/functions.h | 114 +++++++++-- include/net/psp/types.h | 57 ++++++ include/uapi/linux/psp.h | 21 ++ net/psp/Kconfig | 1 + net/psp/Makefile | 2 +- net/psp/psp-nl-gen.c | 39 ++++ net/psp/psp-nl-gen.h | 7 + net/psp/psp.h | 22 +++ net/psp/psp_main.c | 26 ++- net/psp/psp_nl.c | 232 ++++++++++++++++++++++ net/psp/psp_sock.c | 281 +++++++++++++++++++++++++++ 12 files changed, 859 insertions(+), 13 deletions(-) create mode 100644 net/psp/psp_sock.c
Documentation/netlink/specs/psp.yaml +70 -0
@@ -38,6 +38,44 @@ attribute-sets: type: u32 enum: version enum-as-flags: true + - + name: assoc + attributes: + - + name: dev-id + doc: PSP device ID. + type: u32 + checks: + min: 1 + - + name: version + doc: | + PSP versions (AEAD and protocol version) used by this association, + dictates the size of the key. + type: u32 + enum: version + - + name: rx-key + type: nest + nested-attributes: keys + - + name: tx-key + type: nest + nested-attributes: keys + - + name: sock-fd + doc: Sockets which should be bound to the association immediately. + type: u32 + - + name: keys + attributes: + - + name: key + type: binary + - + name: spi + doc: Security Parameters Index (SPI) of the association. + type: u32 operations: list:
@@ -107,6 +145,38 @@ operations: notify: key-rotate mcgrp: use + - + name: rx-assoc + doc: Allocate a new Rx key + SPI pair, associate it with a socket. + attribute-set: assoc + do: + request: + attributes: + - dev-id + - version + - sock-fd + reply: + attributes: + - dev-id + - rx-key + pre: psp-assoc-device-get-locked + post: psp-device-unlock + - + name: tx-assoc + doc: Add a PSP Tx association. + attribute-set: assoc + do: + request: + attributes: + - dev-id + - version + - tx-key + - sock-fd + reply: + attributes: [] + pre: psp-assoc-device-get-locked + post: psp-device-unlock + mcast-groups: list: -
include/net/psp/functions.h +103 -11
157 lines not on this page · raw message
include/net/psp/types.h +57 -0
87 lines not on this page · raw message
include/uapi/linux/psp.h +21 -0
@@ -26,6 +26,25 @@ enum {PSP_A_DEV_MAX = (__PSP_A_DEV_MAX -1 ) }; +enum { +PSP_A_ASSOC_DEV_ID =1 , +PSP_A_ASSOC_VERSION , +PSP_A_ASSOC_RX_KEY , +PSP_A_ASSOC_TX_KEY , +PSP_A_ASSOC_SOCK_FD , + + __PSP_A_ASSOC_MAX, +PSP_A_ASSOC_MAX = (__PSP_A_ASSOC_MAX -1 ) +}; + +enum { +PSP_A_KEYS_KEY =1 , +PSP_A_KEYS_SPI , + + __PSP_A_KEYS_MAX, +PSP_A_KEYS_MAX = (__PSP_A_KEYS_MAX -1 ) +}; +enum {PSP_CMD_DEV_GET =1 ,PSP_CMD_DEV_ADD_NTF ,
@@ -34,6 +53,8 @@ enum {PSP_CMD_DEV_CHANGE_NTF ,PSP_CMD_KEY_ROTATE ,PSP_CMD_KEY_ROTATE_NTF , +PSP_CMD_RX_ASSOC , +PSP_CMD_TX_ASSOC , __PSP_CMD_MAX,PSP_CMD_MAX = (__PSP_CMD_MAX -1 )
net/psp/Kconfig +1 -0
@@ -6,6 +6,7 @@ config INET_PSP bool "PSP Security Protocol support" depends on INET select SKB_DECRYPTED + select SOCK_VALIDATE_XMIT help Enable kernel support for the PSP protocol. For more information see:
net/psp/Makefile +1 -1
@@ -2,4 +2,4 @@ obj-$(CONFIG_INET_PSP) += psp.o -psp-y := psp_main.o psp_nl.o psp-nl-gen.o +psp-y := psp_main.o psp_nl.o psp_sock.o psp-nl-gen.o
net/psp/psp-nl-gen.c +39 -0
@@ -10,6 +10,12 @@#include <uapi/linux/psp.h> +/* Common nested types */ +const struct nla_policy psp_keys_nl_policy[PSP_A_KEYS_SPI +1 ] = { + [PSP_A_KEYS_KEY ] = { .type =NLA_BINARY , }, + [PSP_A_KEYS_SPI ] = { .type =NLA_U32 , }, +}; +/* PSP_CMD_DEV_GET - do */ static const struct nla_policy psp_dev_get_nl_policy[PSP_A_DEV_ID +1 ] = { [PSP_A_DEV_ID ] =NLA_POLICY_MIN (NLA_U32 ,1 ),
@@ -26,6 +32,21 @@ static const struct nla_policy psp_key_rotate_nl_policy[PSP_A_DEV_ID + 1] = { [PSP_A_DEV_ID] = NLA_POLICY_MIN(NLA_U32, 1), }; +/* PSP_CMD_RX_ASSOC - do */ +static const struct nla_policy psp_rx_assoc_nl_policy[PSP_A_ASSOC_SOCK_FD +1 ] = { + [PSP_A_ASSOC_DEV_ID ] =NLA_POLICY_MIN (NLA_U32 ,1 ), + [PSP_A_ASSOC_VERSION ] =NLA_POLICY_MAX (NLA_U32 ,3 ), + [PSP_A_ASSOC_SOCK_FD ] = { .type =NLA_U32 , }, +}; + +/* PSP_CMD_TX_ASSOC - do */ +static const struct nla_policy psp_tx_assoc_nl_policy[PSP_A_ASSOC_SOCK_FD +1 ] = { + [PSP_A_ASSOC_DEV_ID ] =NLA_POLICY_MIN (NLA_U32 ,1 ), + [PSP_A_ASSOC_VERSION ] =NLA_POLICY_MAX (NLA_U32 ,3 ), + [PSP_A_ASSOC_TX_KEY ] =NLA_POLICY_NESTED (psp_keys_nl_policy), + [PSP_A_ASSOC_SOCK_FD ] = { .type =NLA_U32 , }, +}; +/* Ops table for psp */ static const struct genl_split_ops psp_nl_ops[] = { {
@@ -60,6 +81,24 @@ static const struct genl_split_ops psp_nl_ops[] = { .maxattr = PSP_A_DEV_ID, .flags = GENL_CMD_CAP_DO, }, + { + .cmd = PSP_CMD_RX_ASSOC, + .pre_doit = psp_assoc_device_get_locked, + .doit = psp_nl_rx_assoc_doit, + .post_doit = psp_device_unlock, + .policy = psp_rx_assoc_nl_policy, + .maxattr = PSP_A_ASSOC_SOCK_FD, + .flags = GENL_CMD_CAP_DO, + }, + { + .cmd = PSP_CMD_TX_ASSOC, + .pre_doit = psp_assoc_device_get_locked, + .doit = psp_nl_tx_assoc_doit, + .post_doit = psp_device_unlock, + .policy = psp_tx_assoc_nl_policy, + .maxattr = PSP_A_ASSOC_SOCK_FD, + .flags = GENL_CMD_CAP_DO, + }, }; static const struct genl_multicast_group psp_nl_mcgrps[] = {
net/psp/psp-nl-gen.h +7 -0
@@ -11,8 +11,13 @@#include <uapi/linux/psp.h> +/* Common nested types */ +extern const struct nla_policy psp_keys_nl_policy[PSP_A_KEYS_SPI +1 ]; +int psp_device_get_locked (const struct genl_split_ops *ops,struct sk_buff *skb,struct genl_info *info); +int psp_assoc_device_get_locked (const struct genl_split_ops *ops, +struct sk_buff *skb,struct genl_info *info);void psp_device_unlock (const struct genl_split_ops *ops,struct sk_buff *skb,struct genl_info *info);
@@ -21,6 +26,8 @@ int psp_nl_dev_get_doit(struct sk_buff *skb, struct genl_info *info);int psp_nl_dev_get_dumpit (struct sk_buff *skb,struct netlink_callback *cb);int psp_nl_dev_set_doit (struct sk_buff *skb,struct genl_info *info);int psp_nl_key_rotate_doit (struct sk_buff *skb,struct genl_info *info); +int psp_nl_rx_assoc_doit (struct sk_buff *skb,struct genl_info *info); +int psp_nl_tx_assoc_doit (struct sk_buff *skb,struct genl_info *info);enum {PSP_NLGRP_MGMT ,
net/psp/psp.h +22 -0
@@ -4,6 +4,7 @@#define __PSP_PSP_H#include <linux/list.h> +#include <linux/lockdep.h> #include <linux/mutex.h> #include <net/netns/generic.h> #include <net/psp.h>
@@ -17,15 +18,36 @@ int psp_dev_check_access(struct psp_dev *psd, struct net *net);void psp_nl_notify_dev (struct psp_dev *psd,u32 cmd); +struct psp_assoc *psp_assoc_create (struct psp_dev *psd); +struct psp_dev *psp_dev_get_for_sock (struct sock *sk); +void psp_dev_tx_key_del (struct psp_dev *psd,struct psp_assoc *pas); +int psp_sock_assoc_set_rx (struct sock *sk,struct psp_assoc *pas, +struct psp_key_parsed *key, +struct netlink_ext_ack *extack); +int psp_sock_assoc_set_tx (struct sock *sk,struct psp_dev *psd, +u32 version,struct psp_key_parsed *key, +struct netlink_ext_ack *extack); +static inline void psp_dev_get (struct psp_dev *psd) {refcount_inc (&psd->refcnt); } +static inline bool psp_dev_tryget (struct psp_dev *psd) +{ +return refcount_inc_not_zero (&psd->refcnt); +} +static inline void psp_dev_put (struct psp_dev *psd) {if (refcount_dec_and_test (&psd->refcnt))psp_dev_destroy (psd); } +static inline bool psp_dev_is_registered (struct psp_dev *psd) +{ +lockdep_assert_held (&psd->lock); +return !!psd->ops; +} +#endif /* __PSP_PSP_H */
net/psp/psp_main.c +25 -1
@@ -55,7 +55,10 @@ psp_dev_create(struct net_device *netdev,if (WARN_ON (!psd_caps->versions || !psd_ops->set_config || - !psd_ops->key_rotate)) + !psd_ops->key_rotate || + !psd_ops->rx_spi_alloc || + !psd_ops->tx_key_add || + !psd_ops->tx_key_del))return ERR_PTR (-EINVAL ); psd =kzalloc (sizeof (*psd),GFP_KERNEL );
@@ -68,6 +71,7 @@ psp_dev_create(struct net_device *netdev, psd->drv_priv = priv_ptr;mutex_init (&psd->lock); +INIT_LIST_HEAD (&psd->active_assocs);refcount_set (&psd->refcnt,1 );mutex_lock (&psp_devs_lock);
@@ -107,6 +111,8 @@ void psp_dev_destroy(struct psp_dev *psd)*/ void psp_dev_unregister (struct psp_dev *psd) { +struct psp_assoc *pas, *next; +mutex_lock (&psp_devs_lock);mutex_lock (&psd->lock);
@@ -119,6 +125,9 @@ void psp_dev_unregister(struct psp_dev *psd)xa_store (&psp_devs, psd->id,NULL ,GFP_KERNEL );mutex_unlock (&psp_devs_lock); +list_for_each_entry_safe (pas, next, &psd->active_assocs, assocs_list) +psp_dev_tx_key_del (psd, pas); +rcu_assign_pointer (psd->main_netdev->psp_dev,NULL ); psd->ops =NULL ;
@@ -130,6 +139,21 @@ void psp_dev_unregister(struct psp_dev *psd) }EXPORT_SYMBOL (psp_dev_unregister); +unsigned int psp_key_size (u32 version) +{ +switch (version) { +case PSP_VERSION_HDR0_AES_GCM_128 : +case PSP_VERSION_HDR0_AES_GMAC_128 : +return 16 ; +case PSP_VERSION_HDR0_AES_GCM_256 : +case PSP_VERSION_HDR0_AES_GMAC_256 : +return 32 ; +default : +return 0 ; + } +} +EXPORT_SYMBOL (psp_key_size); +static int __init psp_init (void ) {mutex_init (&psp_devs_lock);
net/psp/psp_nl.c +232 -0
244 lines not on this page · raw message
net/psp/psp_sock.c new file +281 -0
281 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 9/19 net: psp: update the TCP MSS to reflect PSP packet overhead
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
PSP eats 32B of header space. Adjust MSS appropriately.
We can either modify tcp_mtu_to_mss() / tcp_mss_to_mtu() or reuse icsk_ext_hdr_len. The former option is more TCP specific and has runtime overhead. The latter is a bit of a hack as PSP is not an ext_hdr. If one squints hard enough, UDP encap is just a more practical version of IPv6 exthdr, so go with the latter. Happy to change.
---
Notes:
v6:
- make psp_sk_overhead() add 40B of encapsulation overhead. v1:
- https://lore.kernel.org/netdev/[email protected]/
include/net/psp/functions.h | 14 ++++++++++++++ include/net/psp/types.h | 3 +++ net/ipv4/tcp_ipv4.c | 4 ++-- net/ipv6/ipv6_sockglue.c | 6 +++++- net/ipv6/tcp_ipv6.c | 6 +++--- net/psp/psp_sock.c | 5 +++++ 6 files changed, 32 insertions(+), 6 deletions(-)
include/net/psp/functions.h +14 -0
@@ -5,6 +5,7 @@#include <linux/skbuff.h> #include <linux/rcupdate.h> +#include <linux/udp.h> #include <net/sock.h> #include <net/tcp.h> #include <net/psp/types.h>
@@ -139,6 +140,14 @@ static inline struct psp_assoc *psp_skb_get_assoc_rcu(struct sk_buff *skb)return psp_sk_get_assoc_rcu (skb->sk); } + +static inline unsigned int psp_sk_overhead (const struct sock *sk) +{ +int psp_encap =sizeof (struct udphdr ) +PSP_HDR_SIZE +PSP_TRL_SIZE ; +bool has_psp =rcu_access_pointer (sk->psp_assoc); + +return has_psp ? psp_encap :0 ; +}#else static inline void psp_sk_assoc_free (struct sock *sk) { } static inline void
@@ -178,6 +187,11 @@ static inline struct psp_assoc *psp_skb_get_assoc_rcu(struct sk_buff *skb) {return NULL ; } + +static inline unsigned int psp_sk_overhead (const struct sock *sk) +{ +return 0 ; +}#endif static inline unsigned long
include/net/psp/types.h +3 -0
@@ -93,6 +93,9 @@ struct psp_dev_caps {#define PSP_MAX_KEY 32 +#define PSP_HDR_SIZE 16/* We don't support optional fields, yet */ +#define PSP_TRL_SIZE 16/* AES-GCM/GMAC trailer size */ +struct psp_skb_ext {__be32 spi;u16 dev_id;
net/ipv4/tcp_ipv4.c +2 -2
@@ -293,9 +293,9 @@ int tcp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len) inet->inet_dport = usin->sin_port;sk_daddr_set (sk, daddr); -inet_csk (sk)->icsk_ext_hdr_len =0 ; +inet_csk (sk)->icsk_ext_hdr_len =psp_sk_overhead (sk);if (inet_opt) -inet_csk (sk)->icsk_ext_hdr_len = inet_opt->opt.optlen; +inet_csk (sk)->icsk_ext_hdr_len += inet_opt->opt.optlen; tp->rx_opt.mss_clamp =TCP_MSS_DEFAULT ;
net/ipv6/ipv6_sockglue.c +5 -1
@@ -49,6 +49,7 @@#include <net/xfrm.h> #include <net/compat.h> #include <net/seg6.h> +#include <net/psp.h> #include <linux/uaccess.h>
@@ -107,7 +108,10 @@ struct ipv6_txoptions *ipv6_update_options(struct sock *sk, !((1 << sk->sk_state) & (TCPF_LISTEN | TCPF_CLOSE)) && inet_sk(sk)->inet_daddr != LOOPBACK4_IPV6) {struct inet_connection_sock *icsk =inet_csk (sk); - icsk->icsk_ext_hdr_len = opt->opt_flen + opt->opt_nflen; + + icsk->icsk_ext_hdr_len = +psp_sk_overhead (sk) + + opt->opt_flen + opt->opt_nflen; icsk->icsk_sync_mss (sk, icsk->icsk_pmtu_cookie); } }
net/ipv6/tcp_ipv6.c +3 -3
@@ -302,10 +302,10 @@ static int tcp_v6_connect(struct sock *sk, struct sockaddr *uaddr, sk->sk_gso_type =SKB_GSO_TCPV6 ;ip6_dst_store (sk, dst,NULL ,NULL ); - icsk->icsk_ext_hdr_len =0 ; + icsk->icsk_ext_hdr_len =psp_sk_overhead (sk);if (opt) - icsk->icsk_ext_hdr_len = opt->opt_flen + - opt->opt_nflen; + icsk->icsk_ext_hdr_len += opt->opt_flen + + opt->opt_nflen; tp->rx_opt.mss_clamp =IPV6_MIN_MTU -sizeof (struct tcphdr ) -sizeof (struct ipv6hdr );
net/psp/psp_sock.c +5 -0
@@ -180,6 +180,7 @@ int psp_sock_assoc_set_tx(struct sock *sk, struct psp_dev *psd, u32 version, struct psp_key_parsed *key, struct netlink_ext_ack *extack) { + struct inet_connection_sock *icsk;struct psp_assoc *pas, *dummy;int err;
@@ -236,6 +237,10 @@ int psp_sock_assoc_set_tx(struct sock *sk, struct psp_dev *psd,tcp_write_collapse_fence (sk); pas->upgrade_seq =tcp_sk (sk)->rcv_nxt; + icsk =inet_csk (sk); + icsk->icsk_ext_hdr_len +=psp_sk_overhead (sk); + icsk->icsk_sync_mss (sk, icsk->icsk_pmtu_cookie); + exit_free_dummy:kfree (dummy); exit_unlock:
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 10/19 psp: track generations of device key
In reply to Daniel ZahkaFrom: Jakub Kicinski <[email protected]>
There is a (somewhat theoretical in absence of multi-host support) possibility that another entity will rotate the key and we won't know. This may lead to accepting packets with matching SPI but which used different crypto keys than we expected.
The PSP Architecture specification mentions that an implementation should track device key generation when device keys are managed by the NIC. Some PSP implementations may opt to include this key generation state in decryption metadata each time a device key is used to decrypt a packet. If that is the case, that key generation counter can also be used when policy checking a decrypted skb against a psp_assoc. This is an optional feature that is not explicitly part of the PSP spec, but can provide additional security in the case where an attacker may have the ability to force key rotations faster than rekeying can occur.
Since we're tracking "key generations" more explicitly now, maintain different lists for associations from different generations. This way we can catch stale associations (the user space should listen to rotation notifications and change the keys).
Drivers can "opt out" of generation tracking by setting the generation value to 0.
---
Notes:
v1:
- https://lore.kernel.org/netdev/[email protected]/
include/net/psp/types.h | 10 ++++++++++ net/psp/psp.h | 1 + net/psp/psp_main.c | 6 +++++- net/psp/psp_nl.c | 10 ++++++++++ net/psp/psp_sock.c | 16 ++++++++++++++++ 5 files changed, 42 insertions(+), 1 deletion(-)
include/net/psp/types.h +10 -0
@@ -50,8 +50,12 @@ struct psp_dev_config {* @lock: instance lock, protects all fields * @refcnt: reference count for the instance * @id: instance id +* @generation: current generation of the device key * @config: current device configuration * @active_assocs: list of registered associations +* @prev_assocs: associations which use old (but still usable) +* device key +* @stale_assocs: associations which use a rotated out key * * @rcu: RCU head for freeing the structure */
@@ -67,13 +71,19 @@ struct psp_dev {u32 id; +u8 generation; +struct psp_dev_config config;struct list_head active_assocs; +struct list_head prev_assocs; +struct list_head stale_assocs;struct rcu_head rcu; }; +#define PSP_GEN_VALID_MASK 0x7f +/** * struct psp_dev_caps - PSP device capabilities */
net/psp/psp.h +1 -0
@@ -27,6 +27,7 @@ int psp_sock_assoc_set_rx(struct sock *sk, struct psp_assoc *pas,int psp_sock_assoc_set_tx (struct sock *sk,struct psp_dev *psd,u32 version,struct psp_key_parsed *key,struct netlink_ext_ack *extack); +void psp_assocs_key_rotated (struct psp_dev *psd);static inline void psp_dev_get (struct psp_dev *psd) {
net/psp/psp_main.c +5 -1
@@ -72,6 +72,8 @@ psp_dev_create(struct net_device *netdev,mutex_init (&psd->lock);INIT_LIST_HEAD (&psd->active_assocs); +INIT_LIST_HEAD (&psd->prev_assocs); +INIT_LIST_HEAD (&psd->stale_assocs);refcount_set (&psd->refcnt,1 );mutex_lock (&psp_devs_lock);
@@ -125,7 +127,9 @@ void psp_dev_unregister(struct psp_dev *psd)xa_store (&psp_devs, psd->id,NULL ,GFP_KERNEL );mutex_unlock (&psp_devs_lock); -list_for_each_entry_safe (pas, next, &psd->active_assocs, assocs_list) +list_splice_init (&psd->active_assocs, &psd->prev_assocs); +list_splice_init (&psd->prev_assocs, &psd->stale_assocs); +list_for_each_entry_safe (pas, next, &psd->stale_assocs, assocs_list)psp_dev_tx_key_del (psd, pas);rcu_assign_pointer (psd->main_netdev->psp_dev,NULL );
net/psp/psp_nl.c +10 -0
@@ -230,6 +230,7 @@ int psp_nl_key_rotate_doit(struct sk_buff *skb, struct genl_info *info)struct psp_dev *psd = info->user_ptr[0 ];struct genl_info ntf_info;struct sk_buff *ntf, *rsp; +u8 prev_gen;int err; rsp =psp_nl_reply_new (info);
@@ -249,10 +250,19 @@ int psp_nl_key_rotate_doit(struct sk_buff *skb, struct genl_info *info) goto err_free_ntf; } +/* suggest the next gen number, driver can override */ + prev_gen = psd->generation; + psd->generation = (prev_gen +1 ) &PSP_GEN_VALID_MASK ; + err = psd->ops->key_rotate (psd, info->extack);if (err) goto err_free_ntf; +WARN_ON_ONCE ((psd->generation && psd->generation == prev_gen) || + psd->generation & ~PSP_GEN_VALID_MASK ); + +psp_assocs_key_rotated (psd); +nlmsg_end (ntf, (struct nlmsghdr *)ntf->data);genlmsg_multicast_netns (&psp_nl_family,dev_net (psd->main_netdev), ntf,0 ,PSP_NLGRP_USE ,GFP_KERNEL );
net/psp/psp_sock.c +16 -0
@@ -60,6 +60,7 @@ struct psp_assoc *psp_assoc_create(struct psp_dev *psd) pas->psd = psd; pas->dev_id = psd->id; + pas->generation = psd->generation;psp_dev_get (psd);refcount_set (&pas->refcnt,1 );
@@ -248,6 +249,21 @@ int psp_sock_assoc_set_tx(struct sock *sk, struct psp_dev *psd,return err; } +void psp_assocs_key_rotated (struct psp_dev *psd) +{ +struct psp_assoc *pas, *next; + +/* Mark the stale associations as invalid, they will no longer +* be able to Rx any traffic. +*/ +list_for_each_entry_safe (pas, next, &psd->prev_assocs, assocs_list) + pas->generation |= ~PSP_GEN_VALID_MASK ; +list_splice_init (&psd->prev_assocs, &psd->stale_assocs); +list_splice_init (&psd->active_assocs, &psd->prev_assocs); + +/* TODO: we should inform the sockets that got shut down */ +} +void psp_twsk_init (struct inet_timewait_sock *tw,const struct sock *sk) {struct psp_assoc *pas =psp_sk_assoc (sk);
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 11/19 net/mlx5e: Support PSP offload functionality
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Add PSP offload related IFC structs, layouts, and enumerations. Implement .set_config and .rx_spi_alloc PSP device operations. Driver does not need to make use of the .set_config operation. Stub .assoc_add and .assoc_del PSP operations.
Introduce the MLX5_EN_PSP configuration option for enabling PSP offload support on mlx5 devices.
---
Notes:
v7:
- use flexible array declaration instead of 0-length array declaration in struct mlx5_ifc_psp_gen_spi_out_bits
v4:
- remove unneeded psp.c/psp.h files
- remove unneeded struct psp_key_spi usage
v1:
- https://lore.kernel.org/netdev/[email protected]/
.../net/ethernet/mellanox/mlx5/core/Kconfig | 11 ++ .../net/ethernet/mellanox/mlx5/core/Makefile | 2 + drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 + .../ethernet/mellanox/mlx5/core/en/params.c | 4 +- .../mellanox/mlx5/core/en_accel/psp.c | 140 ++++++++++++++++++ .../mellanox/mlx5/core/en_accel/psp.h | 47 ++++++ .../mellanox/mlx5/core/en_accel/psp_offload.c | 44 ++++++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 9 ++ drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 + .../net/ethernet/mellanox/mlx5/core/main.c | 1 + .../mellanox/mlx5/core/steering/hws/definer.c | 2 +- include/linux/mlx5/device.h | 4 + include/linux/mlx5/mlx5_ifc.h | 95 +++++++++++- 13 files changed, 361 insertions(+), 7 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_offload.c
drivers/net/ethernet/mellanox/mlx5/core/Kconfig +11 -0
@@ -208,3 +208,14 @@ config MLX5_DPLL help DPLL support in Mellanox Technologies ConnectX NICs. +config MLX5_EN_PSP + bool "Mellanox Technologies support for PSP cryptography-offload acceleration" + depends on INET_PSP + depends on MLX5_CORE_EN + default y + help + mlx5 device offload support for Google PSP Security Protocol offload. + Adds support for PSP encryption offload and for SPI and key generation + interfaces to PSP Stack which supports PSP crypto offload. + + If unsure, say Y.
drivers/net/ethernet/mellanox/mlx5/core/Makefile +2 -0
@@ -110,6 +110,8 @@ mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/ktls_stats.o \ en_accel/fs_tcp.o en_accel/ktls.o en_accel/ktls_txrx.o \ en_accel/ktls_tx.o en_accel/ktls_rx.o +mlx5_core-$(CONFIG_MLX5_EN_PSP) += en_accel/psp.o en_accel/psp_offload.o + # # SW Steering #
drivers/net/ethernet/mellanox/mlx5/core/en.h +3 -0
@@ -936,6 +936,9 @@ struct mlx5e_priv {#ifdef CONFIG_MLX5_EN_IPSEC struct mlx5e_ipsec *ipsec;#endif +#ifdef CONFIG_MLX5_EN_PSP +struct mlx5e_psp *psp; +#endif #ifdef CONFIG_MLX5_EN_TLS struct mlx5e_tls *tls;#endif
drivers/net/ethernet/mellanox/mlx5/core/en/params.c +3 -1
@@ -6,6 +6,7 @@#include "en/port.h" #include "en_accel/en_accel.h" #include "en_accel/ipsec.h" +#include "en_accel/psp.h" #include <linux/dim.h> #include <net/page_pool/types.h> #include <net/xdp_sock_drv.h>
@@ -1003,7 +1004,8 @@ void mlx5e_build_sq_param(struct mlx5_core_dev *mdev,bool allow_swp; allow_swp =mlx5_geneve_tx_allowed (mdev) || - (mlx5_ipsec_device_caps (mdev) &MLX5_IPSEC_CAP_CRYPTO ); + (mlx5_ipsec_device_caps (mdev) &MLX5_IPSEC_CAP_CRYPTO ) || +mlx5_is_psp_device (mdev);mlx5e_build_sq_param_common (mdev, param);MLX5_SET (wq, wq, log_wq_sz, params->log_sq_size);MLX5_SET (sqc, sqc, allow_swp, allow_swp);
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c new file +140 -0
140 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h new file +47 -0
47 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_offload.c new file +44 -0
44 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +9 -0
@@ -52,6 +52,7 @@#include "en_tc.h" #include "en_rep.h" #include "en_accel/ipsec.h" +#include "en_accel/psp.h" #include "en_accel/macsec.h" #include "en_accel/en_accel.h" #include "en_accel/ktls.h"
@@ -5870,6 +5871,7 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev,if (take_rtnl)rtnl_lock (); +mlx5e_psp_register (priv);/* update XDP supported features */ mlx5e_set_xdp_feature (netdev);
@@ -5882,6 +5884,7 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev,static void mlx5e_nic_cleanup (struct mlx5e_priv *priv) {mlx5e_health_destroy_reporters (priv); +mlx5e_psp_unregister (priv);mlx5e_ktls_cleanup (priv);mlx5e_fs_cleanup (priv->fs);debugfs_remove_recursive (priv->dfs_root);
@@ -6009,6 +6012,10 @@ static void mlx5e_nic_enable(struct mlx5e_priv *priv)if (err)mlx5_core_err (mdev,"MACsec initialization failed, %d\n" , err); + err =mlx5e_psp_init (priv); +if (err) +mlx5_core_err (mdev,"PSP initialization failed, %d\n" , err); +/* Marking the link as currently not needed by the Driver */ if (!netif_running (netdev))mlx5e_modify_admin_state (mdev,MLX5_PORT_DOWN );
@@ -6072,6 +6079,7 @@ static void mlx5e_nic_disable(struct mlx5e_priv *priv)mlx5e_disable_async_events (priv);mlx5_lag_remove_netdev (mdev, priv->netdev);mlx5_vxlan_reset_to_default (mdev->vxlan); +mlx5e_psp_cleanup (priv);mlx5e_macsec_cleanup (priv);mlx5e_ipsec_cleanup (priv); }
@@ -6730,6 +6738,7 @@ static void _mlx5e_remove(struct auxiliary_device *adev)* is already unregistered before changing to NIC profile. */ if (priv->netdev->reg_state ==NETREG_REGISTERED ) { +mlx5e_psp_unregister (priv);unregister_netdev (priv->netdev);_mlx5e_suspend (adev, false); }else {
drivers/net/ethernet/mellanox/mlx5/core/fw.c +6 -0
@@ -294,6 +294,12 @@ int mlx5_query_hca_caps(struct mlx5_core_dev *dev)return err; } +if (MLX5_CAP_GEN (dev, psp)) { + err =mlx5_core_get_caps (dev,MLX5_CAP_PSP ); +if (err) +return err; + } +return 0 ; }
drivers/net/ethernet/mellanox/mlx5/core/main.c +1 -0
@@ -1798,6 +1798,7 @@ static const int types[] = {MLX5_CAP_VDPA_EMULATION ,MLX5_CAP_IPSEC ,MLX5_CAP_PORT_SELECTION , +MLX5_CAP_PSP ,MLX5_CAP_MACSEC ,MLX5_CAP_ADV_VIRTUALIZATION , MLX5_CAP_CRYPTO,
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c +1 -1
@@ -1280,7 +1280,7 @@ hws_definer_conv_misc2(struct mlx5hws_definer_conv_data *cd,struct mlx5hws_definer_fc *fc = cd->fc;struct mlx5hws_definer_fc *curr_fc; - if (HWS_IS_FLD_SET_SZ(match_param, misc_parameters_2.reserved_at_1a0, 0x8) || + if (HWS_IS_FLD_SET_SZ(match_param, misc_parameters_2.psp_syndrome, 0x8) || HWS_IS_FLD_SET_SZ(match_param, misc_parameters_2.ipsec_next_header, 0x8) || HWS_IS_FLD_SET_SZ(match_param, misc_parameters_2.reserved_at_1c0, 0x40) ||
include/linux/mlx5/device.h +4 -0
@@ -1248,6 +1248,7 @@ enum mlx5_cap_type {MLX5_CAP_IPSEC ,MLX5_CAP_CRYPTO =0x1a ,MLX5_CAP_SHAMPO =0x1d , +MLX5_CAP_PSP =0x1e ,MLX5_CAP_MACSEC =0x1f ,MLX5_CAP_GENERAL_2 =0x20 , MLX5_CAP_PORT_SELECTION = 0x25,
@@ -1487,6 +1488,9 @@ enum mlx5_qcam_feature_groups {#define MLX5_CAP_SHAMPO (mdev, cap) \ MLX5_GET(shampo_cap, mdev->caps.hca[MLX5_CAP_SHAMPO]->cur, cap) +#define MLX5_CAP_PSP (mdev, cap)\ + MLX5_GET(psp_cap, (mdev)->caps.hca[MLX5_CAP_PSP]->cur, cap) +enum {MLX5_CMD_STAT_OK =0x0 ,MLX5_CMD_STAT_INT_ERR =0x1 ,
include/linux/mlx5/mlx5_ifc.h +90 -5
169 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 12/19 net/mlx5e: Implement PSP operations .assoc_add and .assoc_del
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Implement .assoc_add and .assoc_del PSP operations used in the tx control path. Allocate the relevant hardware resources when a new key is registered using .assoc_add. Destroy the key when .assoc_del is called. Use a atomic counter to keep track of the current number of keys being used by the device.
---
Notes:
v4:
- delete unused struct mlx5e_psp_sa_entry declaration
- use psp_key_size() instead of pas->key_sz in mlx5e_psp_assoc_add() v1:
- https://lore.kernel.org/netdev/[email protected]/
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../mellanox/mlx5/core/en_accel/en_accel.h | 8 + .../mellanox/mlx5/core/en_accel/psp.c | 52 +++- .../mellanox/mlx5/core/en_accel/psp.h | 2 + .../mellanox/mlx5/core/en_accel/psp_fs.c | 233 ++++++++++++++++++ .../mellanox/mlx5/core/en_accel/psp_fs.h | 23 ++ .../net/ethernet/mellanox/mlx5/core/en_main.c | 10 +- .../ethernet/mellanox/mlx5/core/lib/crypto.h | 1 + 8 files changed, 321 insertions(+), 10 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.h
drivers/net/ethernet/mellanox/mlx5/core/Makefile +1 -1
@@ -110,7 +110,7 @@ mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/ktls_stats.o \ en_accel/fs_tcp.o en_accel/ktls.o en_accel/ktls_txrx.o \ en_accel/ktls_tx.o en_accel/ktls_rx.o -mlx5_core-$(CONFIG_MLX5_EN_PSP) += en_accel/psp.o en_accel/psp_offload.o +mlx5_core-$(CONFIG_MLX5_EN_PSP) += en_accel/psp.o en_accel/psp_offload.o en_accel/psp_fs.o # # SW Steering
drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h +8 -0
@@ -42,6 +42,7 @@#include <en_accel/macsec.h> #include "en.h" #include "en/txrx.h" +#include "en_accel/psp_fs.h" #if IS_ENABLED (CONFIG_GENEVE )#include <net/geneve.h>
@@ -218,11 +219,18 @@ static inline void mlx5e_accel_cleanup_rx(struct mlx5e_priv *priv)static inline int mlx5e_accel_init_tx (struct mlx5e_priv *priv) { +int err; + + err =mlx5_accel_psp_fs_init_tx_tables (priv); +if (err) +return err; +return mlx5e_ktls_init_tx (priv); }static inline void mlx5e_accel_cleanup_tx (struct mlx5e_priv *priv) {mlx5e_ktls_cleanup_tx (priv); +mlx5_accel_psp_fs_cleanup_tx_tables (priv); }#endif /* __MLX5E_EN_ACCEL_H__ */
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c +48 -4
94 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h +2 -0
@@ -10,6 +10,8 @@struct mlx5e_psp {struct psp_dev *psp;struct psp_dev_caps caps; +struct mlx5e_psp_fs *fs; +atomic_t tx_key_cnt; };static inline bool mlx5_is_psp_device (struct mlx5_core_dev *mdev)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c new file +233 -0
233 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.h new file +23 -0
@@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */ +/* Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. */ + +#ifndef __MLX5_PSP_FS_H__ +#define __MLX5_PSP_FS_H__ + +#ifdef CONFIG_MLX5_EN_PSP + +struct mlx5e_psp_fs ; + +struct mlx5e_psp_fs *mlx5e_accel_psp_fs_init (struct mlx5e_priv *priv); +void mlx5e_accel_psp_fs_cleanup (struct mlx5e_psp_fs *fs); +int mlx5_accel_psp_fs_init_tx_tables (struct mlx5e_priv *priv); +void mlx5_accel_psp_fs_cleanup_tx_tables (struct mlx5e_priv *priv); +#else +static inline int mlx5_accel_psp_fs_init_tx_tables (struct mlx5e_priv *priv) +{ +return 0 ; +} + +static inline void mlx5_accel_psp_fs_cleanup_tx_tables (struct mlx5e_priv *priv) { } +#endif /* CONFIG_MLX5_EN_PSP */ +#endif /* __MLX5_PSP_FS_H__ */
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +5 -5
@@ -5859,6 +5859,10 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev, } priv->fs = fs; + err =mlx5e_psp_init (priv); +if (err) +mlx5_core_err (mdev,"PSP initialization failed, %d\n" , err); + err =mlx5e_ktls_init (priv);if (err)mlx5_core_err (mdev,"TLS initialization failed, %d\n" , err);
@@ -5886,6 +5890,7 @@ static void mlx5e_nic_cleanup(struct mlx5e_priv *priv)mlx5e_health_destroy_reporters (priv);mlx5e_psp_unregister (priv);mlx5e_ktls_cleanup (priv); +mlx5e_psp_cleanup (priv);mlx5e_fs_cleanup (priv->fs);debugfs_remove_recursive (priv->dfs_root); priv->fs =NULL ;
@@ -6012,10 +6017,6 @@ static void mlx5e_nic_enable(struct mlx5e_priv *priv)if (err)mlx5_core_err (mdev,"MACsec initialization failed, %d\n" , err); - err =mlx5e_psp_init (priv); -if (err) -mlx5_core_err (mdev,"PSP initialization failed, %d\n" , err); -/* Marking the link as currently not needed by the Driver */ if (!netif_running (netdev))mlx5e_modify_admin_state (mdev,MLX5_PORT_DOWN );
@@ -6079,7 +6080,6 @@ static void mlx5e_nic_disable(struct mlx5e_priv *priv)mlx5e_disable_async_events (priv);mlx5_lag_remove_netdev (mdev, priv->netdev);mlx5_vxlan_reset_to_default (mdev->vxlan); -mlx5e_psp_cleanup (priv);mlx5e_macsec_cleanup (priv);mlx5e_ipsec_cleanup (priv); }
drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.h +1 -0
@@ -8,6 +8,7 @@ enum {MLX5_ACCEL_OBJ_TLS_KEY =MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_PURPOSE_TLS ,MLX5_ACCEL_OBJ_IPSEC_KEY =MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_PURPOSE_IPSEC ,MLX5_ACCEL_OBJ_MACSEC_KEY =MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_PURPOSE_MACSEC , +MLX5_ACCEL_OBJ_PSP_KEY =MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_PURPOSE_PSP , MLX5_ACCEL_OBJ_TYPE_KEY_NUM, };
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 13/19 psp: provide encapsulation helper for drivers
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Create a new function psp_encapsulate(), which takes a TCP packet and PSP encapsulates it according to the "Transport Mode Packet Format" section of the PSP Architecture Specification.
psp_encapsulate() does not push a PSP trailer onto the skb. Only IPv6 is supported. Virtualization cookie is not included.
---
Notes:
v4:
- rename psp_encapsulate() to psp_dev_encapsulate() v3:
- patch introduced
include/net/psp/functions.h | 2 ++ include/net/psp/types.h | 2 ++ net/psp/psp_main.c | 57 +++++++++++++++++++++++++++++++++++++ 3 files changed, 61 insertions(+)
include/net/psp/functions.h +2 -0
@@ -17,6 +17,8 @@ struct psp_dev * psp_dev_create(struct net_device *netdev, struct psp_dev_ops *psd_ops, struct psp_dev_caps *psd_caps, void *priv_ptr);void psp_dev_unregister (struct psp_dev *psd); +bool psp_dev_encapsulate (struct net *net,struct sk_buff *skb, +__be32 spi,u8 ver,__be16 sport);/* Kernel-facing API */ void psp_assoc_put (struct psp_assoc *pas);
include/net/psp/types.h +2 -0
@@ -20,6 +20,8 @@ struct psphdr {__be64 vc[];/* optional */ }; +#define PSP_ENCAP_HLEN (sizeof(struct udphdr) + sizeof(struct psphdr)) +#define PSP_SPI_KEY_ID GENMASK(30, 0)#define PSP_SPI_KEY_PHASE BIT(31)
net/psp/psp_main.c +57 -0
73 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 14/19 net/mlx5e: Implement PSP Tx data path
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Setup PSP offload on Tx data path based on whether skb indicates that it is intended for PSP or not. Support driver side encapsulation of the UDP headers, PSP headers, and PSP trailer for the PSP traffic that will be encrypted by the NIC.
---
Notes:
v4:
- replace memcpy in mlx5e_psp_set_state()
v3:
- move psp_encapsulate() into psp_main.c in a separate commit v1:
- https://lore.kernel.org/netdev/[email protected]/
.../net/ethernet/mellanox/mlx5/core/Makefile | 3 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +- .../mellanox/mlx5/core/en_accel/en_accel.h | 28 +++ .../mellanox/mlx5/core/en_accel/psp_rxtx.c | 170 ++++++++++++++++++ .../mellanox/mlx5/core/en_accel/psp_rxtx.h | 96 ++++++++++ .../net/ethernet/mellanox/mlx5/core/en_tx.c | 10 +- 6 files changed, 306 insertions(+), 4 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h
drivers/net/ethernet/mellanox/mlx5/core/Makefile +2 -1
@@ -110,7 +110,8 @@ mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/ktls_stats.o \ en_accel/fs_tcp.o en_accel/ktls.o en_accel/ktls_txrx.o \ en_accel/ktls_tx.o en_accel/ktls_rx.o -mlx5_core-$(CONFIG_MLX5_EN_PSP) += en_accel/psp.o en_accel/psp_offload.o en_accel/psp_fs.o +mlx5_core-$(CONFIG_MLX5_EN_PSP) += en_accel/psp.o en_accel/psp_offload.o en_accel/psp_fs.o \ + en_accel/psp_rxtx.o # # SW Steering
drivers/net/ethernet/mellanox/mlx5/core/en.h +2 -1
@@ -47,6 +47,7 @@#include <linux/rhashtable.h> #include <net/udp_tunnel.h> #include <net/switchdev.h> +#include <net/psp/types.h> #include <net/xdp.h> #include <linux/dim.h> #include <linux/bits.h>
@@ -68,7 +69,7 @@ struct page_pool;#define MLX5E_METADATA_ETHER_TYPE (0x8CE4)#define MLX5E_METADATA_ETHER_LEN 8 -#define MLX5E_ETH_HARD_MTU (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN) +#define MLX5E_ETH_HARD_MTU (ETH_HLEN + PSP_ENCAP_HLEN + PSP_TRL_SIZE + VLAN_HLEN + ETH_FCS_LEN)#define MLX5E_HW2SW_MTU (params, hwmtu) ((hwmtu) - ((params)->hard_mtu))#define MLX5E_SW2HW_MTU (params, swmtu) ((swmtu) + ((params)->hard_mtu))
drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h +28 -0
@@ -43,6 +43,7 @@#include "en.h" #include "en/txrx.h" #include "en_accel/psp_fs.h" +#include "en_accel/psp_rxtx.h" #if IS_ENABLED (CONFIG_GENEVE )#include <net/geneve.h>
@@ -120,6 +121,9 @@ struct mlx5e_accel_tx_state {#ifdef CONFIG_MLX5_EN_IPSEC struct mlx5e_accel_tx_ipsec_state ipsec;#endif +#ifdef CONFIG_MLX5_EN_PSP +struct mlx5e_accel_tx_psp_state psp_st; +#endif }; static inline bool mlx5e_accel_tx_begin(struct net_device *dev,
@@ -138,6 +142,13 @@ static inline bool mlx5e_accel_tx_begin(struct net_device *dev,return false;#endif +#ifdef CONFIG_MLX5_EN_PSP +if (mlx5e_psp_is_offload (skb, dev)) { +if (unlikely (!mlx5e_psp_handle_tx_skb (dev, skb, &state->psp_st))) +return false; + } +#endif +#ifdef CONFIG_MLX5_EN_IPSEC if (test_bit (MLX5E_SQ_STATE_IPSEC , &sq->state) &&xfrm_offload (skb)) {if (unlikely (!mlx5e_ipsec_handle_tx_skb (dev, skb, &state->ipsec)))
@@ -158,8 +169,14 @@ static inline bool mlx5e_accel_tx_begin(struct net_device *dev, }static inline unsigned int mlx5e_accel_tx_ids_len (struct mlx5e_txqsq *sq, +struct sk_buff *skb,struct mlx5e_accel_tx_state *state) { +#ifdef CONFIG_MLX5_EN_PSP +if (mlx5e_psp_is_offload_state (&state->psp_st)) +return mlx5e_psp_tx_ids_len (&state->psp_st); +#endif +#ifdef CONFIG_MLX5_EN_IPSEC if (test_bit (MLX5E_SQ_STATE_IPSEC , &sq->state))return mlx5e_ipsec_tx_ids_len (&state->ipsec);
@@ -173,8 +190,14 @@ static inline unsigned int mlx5e_accel_tx_ids_len(struct mlx5e_txqsq *sq,static inline void mlx5e_accel_tx_eseg (struct mlx5e_priv *priv,struct sk_buff *skb, +struct mlx5e_accel_tx_state *accel,struct mlx5_wqe_eth_seg *eseg,u16 ihs) { +#ifdef CONFIG_MLX5_EN_PSP +if (mlx5e_psp_is_offload_state (&accel->psp_st)) +mlx5e_psp_tx_build_eseg (priv, skb, &accel->psp_st, eseg); +#endif +#ifdef CONFIG_MLX5_EN_IPSEC if (xfrm_offload (skb))mlx5e_ipsec_tx_build_eseg (priv, skb, eseg);
@@ -200,6 +223,11 @@ static inline void mlx5e_accel_tx_finish(struct mlx5e_txqsq *sq,mlx5e_ktls_handle_tx_wqe (&wqe->ctrl, &state->tls);#endif +#ifdef CONFIG_MLX5_EN_PSP +if (mlx5e_psp_is_offload_state (&state->psp_st)) +mlx5e_psp_handle_tx_wqe (wqe, &state->psp_st, inlseg); +#endif +#ifdef CONFIG_MLX5_EN_IPSEC if (test_bit (MLX5E_SQ_STATE_IPSEC , &sq->state) && state->ipsec.xo && state->ipsec.tailen)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c new file +170 -0
170 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h new file +96 -0
96 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_tx.c +8 -2
@@ -39,6 +39,7 @@#include "ipoib/ipoib.h" #include "en_accel/en_accel.h" #include "en_accel/ipsec_rxtx.h" +#include "en_accel/psp_rxtx.h" #include "en_accel/macsec.h" #include "en/ptp.h" #include <net/ipv6.h>
@@ -120,6 +121,11 @@ mlx5e_txwqe_build_eseg_csum(struct mlx5e_txqsq *sq, struct sk_buff *skb, struct mlx5e_accel_tx_state *accel, struct mlx5_wqe_eth_seg *eseg) { +#ifdef CONFIG_MLX5_EN_PSP + if (unlikely(mlx5e_psp_txwqe_build_eseg_csum(sq, skb, &accel->psp_st, eseg))) + return; +#endif + if (unlikely(mlx5e_ipsec_txwqe_build_eseg_csum(sq, skb, eseg))) return;
@@ -297,7 +303,7 @@ static void mlx5e_sq_xmit_prepare(struct mlx5e_txqsq *sq, struct sk_buff *skb, stats->packets++; } - attr->insz =mlx5e_accel_tx_ids_len (sq, accel); + attr->insz =mlx5e_accel_tx_ids_len (sq, skb, accel); stats->bytes += attr->num_bytes; }
@@ -661,7 +667,7 @@ static void mlx5e_txwqe_build_eseg(struct mlx5e_priv *priv, struct mlx5e_txqsq * struct sk_buff *skb, struct mlx5e_accel_tx_state *accel, struct mlx5_wqe_eth_seg *eseg, u16 ihs) { -mlx5e_accel_tx_eseg (priv ,skb ,eseg ,ihs ); +mlx5e_accel_tx_eseg (priv ,skb ,accel ,eseg ,ihs );mlx5e_txwqe_build_eseg_csum (sq, skb, accel, eseg);if (unlikely (sq->ptpsq))mlx5e_cqe_ts_id_eseg (sq->ptpsq, skb, eseg);
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 15/19 net/mlx5e: Add PSP steering in local NIC RX
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Introduce decrypt FT, the RX error FT, and the default rules.
The PSP (PSP) RX decrypt flow table is pointed by the TTC (Traffic Type Classifier) UDP steering rules.
The decrypt flow table has two flow groups. The first flow group keeps the decrypt steering rule programmed always when PSP packet is recognized using the dedicated udp destination port number 1000, if packet is decrypted then a PSP marker is set in metadata_regB[30]. The second flow group has a default rule to forward all non-offloaded PSP packet to the TTC UDP default RSS TIR.
The RX error flow table is the destination of the decrypt steering rules in the PSP RX decrypt flow table. It has two fixed rule one with single copy action that copies psp_syndrome to metadata_regB[23:29]. The PSP marker and syndrome is used to filter out non-psp packet and to return the PSP crypto offload status in Rx flow. The marker is used to identify such packet in driver so the driver could set SKB PSP metadata. The destination of RX error flow table is the TTC UDP default RSS TIR. The second rule will drop packets that failed to be decrypted (like in case illegal SPI or expired SPI is used).
---
Notes:
v6:
- move call to mlx5e_fs_get_ttc() to after null check of fs v1:
- https://lore.kernel.org/netdev/[email protected]/
.../net/ethernet/mellanox/mlx5/core/en/fs.h | 2 +- .../mellanox/mlx5/core/en_accel/psp_fs.c | 482 +++++++++++++++++- 2 files changed, 477 insertions(+), 7 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en/fs.h +1 -1
@@ -88,7 +88,7 @@ enum {#ifdef CONFIG_MLX5_EN_ARFS MLX5E_ARFS_FT_LEVEL = MLX5E_INNER_TTC_FT_LEVEL + 1,#endif -#ifdef CONFIG_MLX5_EN_IPSEC +#if defined(CONFIG_MLX5_EN_IPSEC ) || defined(CONFIG_MLX5_EN_PSP )MLX5E_ACCEL_FS_ESP_FT_LEVEL =MLX5E_INNER_TTC_FT_LEVEL +1 ,MLX5E_ACCEL_FS_ESP_FT_ERR_LEVEL , MLX5E_ACCEL_FS_POL_FT_LEVEL,
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c +476 -6
522 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 16/19 net/mlx5e: Configure PSP Rx flow steering rules
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Set the Rx PSP flow steering rule where PSP packet is identified and decrypted using the dedicated UDP destination port number 1000. If packet is decrypted then a PSP marker and syndrome are added to metadata so SW can use it later on in Rx data path.
The rule is set as part of init_rx netdev profile implementation.
---
Notes:
v6:
- change loop index in mlx5_accel_psp_fs_init_rx_tables() to int to avoid relying on udefined behavior.
v1:
- https://lore.kernel.org/netdev/[email protected]/
.../mellanox/mlx5/core/en_accel/en_accel.h | 14 +++++- .../mellanox/mlx5/core/en_accel/psp_fs.c | 43 ++++++++++++++++--- .../mellanox/mlx5/core/en_accel/psp_fs.h | 7 +++ 3 files changed, 58 insertions(+), 6 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h +13 -1
@@ -237,12 +237,24 @@ static inline void mlx5e_accel_tx_finish(struct mlx5e_txqsq *sq,static inline int mlx5e_accel_init_rx (struct mlx5e_priv *priv) { -return mlx5e_ktls_init_rx (priv); +int err; + + err =mlx5_accel_psp_fs_init_rx_tables (priv); +if (err) + goto out; + + err =mlx5e_ktls_init_rx (priv); +if (err) +mlx5_accel_psp_fs_cleanup_rx_tables (priv); + +out: +return err; }static inline void mlx5e_accel_cleanup_rx (struct mlx5e_priv *priv) {mlx5e_ktls_cleanup_rx (priv); +mlx5_accel_psp_fs_cleanup_rx_tables (priv); }static inline int mlx5e_accel_init_tx (struct mlx5e_priv *priv)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c +38 -5
58 lines not on this page · raw message
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.h +7 -0
@@ -12,6 +12,8 @@ struct mlx5e_psp_fs *mlx5e_accel_psp_fs_init(struct mlx5e_priv *priv);void mlx5e_accel_psp_fs_cleanup (struct mlx5e_psp_fs *fs);int mlx5_accel_psp_fs_init_tx_tables (struct mlx5e_priv *priv);void mlx5_accel_psp_fs_cleanup_tx_tables (struct mlx5e_priv *priv); +int mlx5_accel_psp_fs_init_rx_tables (struct mlx5e_priv *priv); +void mlx5_accel_psp_fs_cleanup_rx_tables (struct mlx5e_priv *priv);#else static inline int mlx5_accel_psp_fs_init_tx_tables (struct mlx5e_priv *priv) {
@@ -19,5 +21,10 @@ static inline int mlx5_accel_psp_fs_init_tx_tables(struct mlx5e_priv *priv) }static inline void mlx5_accel_psp_fs_cleanup_tx_tables (struct mlx5e_priv *priv) { } +static inline int mlx5_accel_psp_fs_init_rx_tables (struct mlx5e_priv *priv) +{ +return 0 ; +} +static inline void mlx5_accel_psp_fs_cleanup_rx_tables (struct mlx5e_priv *priv) { }#endif /* CONFIG_MLX5_EN_PSP */ #endif /* __MLX5_PSP_FS_H__ */
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 17/19 psp: provide decapsulation and receive helper for drivers
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Create psp_rcv(), which drivers can call to psp decapsulate and attach a psp_skb_ext to an skb.
psp_rcv() only supports what the PSP architecture specification refers to as "transport mode" packets, where the L3 header is IPv6. psp_rcv() also assumes that a psp trailer is present and should be pulled from the skb.
---
Notes:
v4:
- rename psp_rcv() to psp_dev_rcv()
- add strip_icv param psp_dev_rcv() to make trailer stripping optional v3:
- patch introduced
include/net/psp/functions.h | 1 + net/psp/psp_main.c | 53 +++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+)
include/net/psp/functions.h +1 -0
@@ -19,6 +19,7 @@ psp_dev_create(struct net_device *netdev, struct psp_dev_ops *psd_ops,void psp_dev_unregister (struct psp_dev *psd);bool psp_dev_encapsulate (struct net *net,struct sk_buff *skb,__be32 spi,u8 ver,__be16 sport); +int psp_dev_rcv (struct sk_buff *skb,u16 dev_id,u8 generation,bool strip_icv);/* Kernel-facing API */ void psp_assoc_put (struct psp_assoc *pas);
net/psp/psp_main.c +53 -0
59 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 18/19 net/mlx5e: Add Rx data path offload
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
On receive flow inspect received packets for PSP offload indication using the cqe, for PSP offloaded packets set SKB PSP metadata i.e spi, header length and key generation number to stack for further processing.
---
Notes:
v4:
- remove mlx5e_psp_csum_complete() because stripping psp_icv can be done in psp_dev_rcv() now
- fix MLX5_PSP_METADATA_SYNDROME typo
v3:
- move psp_rcv() into psp_main.c in a separate commit
v2:
- fill out new pse::dev_id field in psp_rcv()
v1:
- https://lore.kernel.org/netdev/[email protected]/
.../mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 2 +- .../mellanox/mlx5/core/en_accel/psp_rxtx.c | 30 ++++++++++++ .../mellanox/mlx5/core/en_accel/psp_rxtx.h | 25 ++++++++++ .../net/ethernet/mellanox/mlx5/core/en_rx.c | 49 ++++++++++++++----- 4 files changed, 93 insertions(+), 13 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h +1 -1
@@ -40,7 +40,7 @@#include "en/txrx.h" /* Bit31: IPsec marker, Bit30: reserved, Bit29-24: IPsec syndrome, Bit23-0: IPsec obj id */ -#define MLX5_IPSEC_METADATA_MARKER (metadata) (((metadata) >> 31) & 0x1) +#define MLX5_IPSEC_METADATA_MARKER (metadata) ((((metadata) >> 30) & 0x3) == 0x2)#define MLX5_IPSEC_METADATA_SYNDROM (metadata) (((metadata) >> 24) & GENMASK(5, 0))#define MLX5_IPSEC_METADATA_HANDLE (metadata) ((metadata) & GENMASK(23, 0))
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c +30 -0
@@ -14,6 +14,12 @@#include "en_accel/psp_rxtx.h" #include "en_accel/psp.h" +enum { +MLX5E_PSP_OFFLOAD_RX_SYNDROME_DECRYPTED , +MLX5E_PSP_OFFLOAD_RX_SYNDROME_AUTH_FAILED , +MLX5E_PSP_OFFLOAD_RX_SYNDROME_BAD_TRAILER , +}; +static void mlx5e_psp_set_swp (struct sk_buff *skb,struct mlx5e_accel_tx_psp_state *psp_st,struct mlx5_wqe_eth_seg *eseg)
@@ -113,6 +119,30 @@ static bool mlx5e_psp_set_state(struct mlx5e_priv *priv,return ret; } +bool mlx5e_psp_offload_handle_rx_skb (struct net_device *netdev,struct sk_buff *skb, +struct mlx5_cqe64 *cqe) +{ +u32 psp_meta_data =be32_to_cpu (cqe->ft_metadata); +struct mlx5e_priv *priv =netdev_priv (netdev); +u16 dev_id = priv->psp->psp->id; +bool strip_icv = true; +u8 generation =0 ; + +/* TBD: report errors as SW counters to ethtool, any further handling ? */ +if (MLX5_PSP_METADATA_SYNDROME (psp_meta_data) !=MLX5E_PSP_OFFLOAD_RX_SYNDROME_DECRYPTED ) + goto drop; + +if (psp_dev_rcv (skb, dev_id, generation, strip_icv)) + goto drop; + + skb->decrypted =1 ; +return false; + +drop: +kfree_skb (skb); +return true; +} +void mlx5e_psp_tx_build_eseg (struct mlx5e_priv *priv,struct sk_buff *skb,struct mlx5e_accel_tx_psp_state *psp_st,struct mlx5_wqe_eth_seg *eseg)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.h +25 -0
@@ -10,6 +10,11 @@#include "en.h" #include "en/txrx.h" +/* Bit30: PSP marker, Bit29-23: PSP syndrome, Bit22-0: PSP obj id */ +#define MLX5_PSP_METADATA_MARKER (metadata) ((((metadata) >> 30) & 0x3) == 0x3) +#define MLX5_PSP_METADATA_SYNDROME (metadata) (((metadata) >> 23) & GENMASK(6, 0)) +#define MLX5_PSP_METADATA_HANDLE (metadata) ((metadata) & GENMASK(22, 0)) +struct mlx5e_accel_tx_psp_state {u32 tailen;u32 keyid;
@@ -75,6 +80,14 @@ static inline unsigned int mlx5e_psp_tx_ids_len(struct mlx5e_accel_tx_psp_state {return psp_st->tailen; } + +static inline bool mlx5e_psp_is_rx_flow (struct mlx5_cqe64 *cqe) +{ +return MLX5_PSP_METADATA_MARKER (be32_to_cpu (cqe->ft_metadata)); +} + +bool mlx5e_psp_offload_handle_rx_skb (struct net_device *netdev,struct sk_buff *skb, +struct mlx5_cqe64 *cqe);#else static inline bool mlx5e_psp_is_offload_state (struct mlx5e_accel_tx_psp_state *psp_state) {
@@ -92,5 +105,17 @@ static inline bool mlx5e_psp_txwqe_build_eseg_csum(struct mlx5e_txqsq *sq, struc {return false; } + +static inline bool mlx5e_psp_is_rx_flow (struct mlx5_cqe64 *cqe) +{ +return false; +} + +static inline bool mlx5e_psp_offload_handle_rx_skb (struct net_device *netdev, +struct sk_buff *skb, +struct mlx5_cqe64 *cqe) +{ +return false; +}#endif /* CONFIG_MLX5_EN_PSP */ #endif /* __MLX5E_PSP_RXTX_H__ */
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +37 -12
136 lines not on this page · raw message
Signature · 1 line
2.47.3
Daniel Zahka
maintainerPATCH v7 19/19 net/mlx5e: Implement PSP key_rotate operation
In reply to Daniel ZahkaFrom: Raed Salem <[email protected]>
Implement .key_rotate operation where when invoked will cause the HW to use a new master key to derive PSP spi/key pairs with complience with PSP spec.
---
Notes:
v1:
- https://lore.kernel.org/netdev/[email protected]/
.../net/ethernet/mellanox/mlx5/core/en_accel/psp.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c +11 -0
@@ -82,11 +82,22 @@ static void mlx5e_psp_assoc_del(struct psp_dev *psd, struct psp_assoc *pas)atomic_dec (&psp->tx_key_cnt); } +static int mlx5e_psp_key_rotate (struct psp_dev *psd,struct netlink_ext_ack *exack) +{ +struct mlx5e_priv *priv =netdev_priv (psd->main_netdev); + +/* no support for protecting against external rotations */ + psd->generation =0 ; + +return mlx5e_psp_rotate_key (priv->mdev); +} +static struct psp_dev_ops mlx5_psp_ops = { .set_config = mlx5e_psp_set_config, .rx_spi_alloc = mlx5e_psp_rx_spi_alloc, .tx_key_add = mlx5e_psp_assoc_add, .tx_key_del = mlx5e_psp_assoc_del, + .key_rotate = mlx5e_psp_key_rotate, };void mlx5e_psp_unregister (struct mlx5e_priv *priv)
Signature · 1 line
2.47.3
Jakub Kicinski
maintainerQuoted 1 line · On Wed, 20 Aug 2025 04:30:58 -0700 Daniel Zahka wrote:
include/linux/mlx5/mlx5_ifc.h | 95 ++-
Tariq, Saeed, would you like to fold the mlx5_ifc.h changes into your next mlx5-next PR? Or is it okay for those to go in directly?