Skip to contentSkip to conversation

netlink: specs: binder: replace underscores with dashes in names

PATCH In review Carlos Llamas 3 participants 3 messages Aug 21, 2025

Subsystems (4)
lore
Share & tools
lore

Carlos Llamas

author maintainer
#0 lore raw

PATCH 1/1 netlink: specs: binder: replace underscores with dashes in names

The usage of underscores is no longer allowed for the 'name' format in the yaml spec. Instead, dashes should be used. This fixes the build issue reported by Thorsten that showed up on linux-next.

Note this change has no impact on C code.

Cc Jakub Kicinski <[email protected]>
Fixes 63740349eba7 ("binder: introduce transaction reports via netlink")
---
 Documentation/netlink/specs/binder.yaml | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Documentation/netlink/specs/binder.yaml +12 -12
index 140b77a6afee..0f0575ad1265 100644
@@ -26,27 +26,27 @@ attribute-sets:
         type: string
         doc: The binder context where the transaction occurred.
       -
-        name: from_pid
+        name: from-pid
         type: u32
         doc: The PID of the sender process.
       -
-        name: from_tid
+        name: from-tid
         type: u32
         doc: The TID of the sender thread.
       -
-        name: to_pid
+        name: to-pid
         type: u32
         doc: |
           The PID of the recipient process. This attribute may not be present
           if the target could not be determined.
       -
-        name: to_tid
+        name: to-tid
         type: u32
         doc: |
           The TID of the recipient thread. This attribute may not be present
           if the target could not be determined.
       -
-        name: is_reply
+        name: is-reply
         type: flag
         doc: When present, indicates the failed transaction is a reply.
       -
@@ -58,7 +58,7 @@ attribute-sets:
         type: u32
         doc: The application-defined code from the transaction.
       -
-        name: data_size
+        name: data-size
         type: u32
         doc: The transaction payload size in bytes.
 
@@ -78,14 +78,14 @@ operations:
         attributes:
           - error
           - context
-          - from_pid
-          - from_tid
-          - to_pid
-          - to_tid
-          - is_reply
+          - from-pid
+          - from-tid
+          - to-pid
+          - to-tid
+          - is-reply
           - flags
           - code
-          - data_size
+          - data-size
 
 mcast-groups:
   list:
Signature · 1 line
2.51.0.rc1.193.gad69d77794-goog
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Thu, 21 Aug 2025 13:55:21 +0000 Carlos Llamas wrote:

The usage of underscores is no longer allowed for the 'name' format in the yaml spec. Instead, dashes should be used. This fixes the build issue reported by Thorsten that showed up on linux-next.

Note this change has no impact on C code.

I guess the tree where the patches landed doesn't have last merge window material? I thought the extra consistency checks went in for 6.17 already.. In any case, change makes sense:

#2 lore raw
Quoted 10 lines · Jakub Kicinski
Quoted 5 lines · On Thu, 21 Aug 2025 13:55:21 +0000 Carlos Llamas wrote:

The usage of underscores is no longer allowed for the 'name' format in the yaml spec. Instead, dashes should be used. This fixes the build issue reported by Thorsten that showed up on linux-next.

Note this change has no impact on C code.

I guess the tree where the patches landed doesn't have last merge window material? I thought the extra consistency checks went in for 6.17 already.. In any case, change makes sense:

They don't seem to be in 6.17-rc3, what commit are you thinking this was? Ugh, my fault, nevermind, I was testing the wrong branch in the wrong git tree!

I see this in my tree now, sorry everyone for the noise in not figuring this out, too many trees/branches...

Quoted 1 line

Thanks, I'll take this in the char-misc-next branch now.

greg k-h