staging: media: atomisp: Remove unnecessary forward declaration in gdc.c
Subsystems (4)
PATCH v3 1/3 staging: media: atomisp: Remove unnecessary forward declaration in gdc.c
Get rid of gdc_reg_store() forward declaration because it brings no value.
Signed-off-by Adrian Barnaś <[email protected]>
--- .../pci/hive_isp_css_common/host/gdc.c | 24 ++++--------------- 1 file changed, 5 insertions(+), 19 deletions(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +5 -19
@@ -11,13 +11,11 @@#include "assert_support.h" -/* -* Local function declarations -*/ -static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value); +static inline void gdc_reg_store (const gdc_ID_t ID ,const unsigned int reg, +const hrt_data value) +{ +ia_css_device_store_uint32 (GDC_BASE [ID ] + reg *sizeof (hrt_data), value); +}#ifndef __INLINE_GDC__#include "gdc_private.h"
@@ -92,15 +90,3 @@ int gdc_get_unity( (void )ID ;return (int )(1UL <<HRT_GDC_FRAC_BITS ); } - -/* -* Local function implementations -*/ -static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value) -{ -ia_css_device_store_uint32 (GDC_BASE [ID ] + reg *sizeof (hrt_data), value); -return ; -}
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
PATCH v3 2/3 staging: media: atomisp: Whitespaces style cleanup in gdc.c
Clean up coding style whitespace issues
in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c.
Fixes include:
- removal of unnecessary line breaks
- correcting spacing around operators
- correcting spaces between types and names
Signed-off-by Adrian Barnaś <[email protected]>
--- .../pci/hive_isp_css_common/host/gdc.c | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +8 -13
@@ -24,9 +24,7 @@ static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,/* * Exported function implementations */ -void gdc_lut_store ( -const gdc_ID_t ID , -const int data[4 ][HRT_GDC_N ]) +void gdc_lut_store (const gdc_ID_t ID ,const int data[4 ][HRT_GDC_N ]) {unsigned int i, lut_offset =HRT_GDC_LUT_IDX ;
@@ -34,15 +32,13 @@ void gdc_lut_store(assert (HRT_GDC_LUT_COEFF_OFFSET <= (4 *sizeof (hrt_data)));for (i =0 ; i <HRT_GDC_N ; i++) { -hrt_data entry_0 = data[0 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_1 = data[1 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_2 = data[2 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_3 = data[3 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_0 = data[0 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_1 = data[1 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_2 = data[2 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_3 = data[3 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data word_0 = entry_0 | - (entry_1 <<HRT_GDC_LUT_COEFF_OFFSET ); -hrt_data word_1 = entry_2 | - (entry_3 <<HRT_GDC_LUT_COEFF_OFFSET ); +hrt_data word_0 = entry_0 | (entry_1 <<HRT_GDC_LUT_COEFF_OFFSET ); +hrt_data word_1 = entry_2 | (entry_3 <<HRT_GDC_LUT_COEFF_OFFSET );gdc_reg_store (ID , lut_offset++, word_0);gdc_reg_store (ID , lut_offset++, word_1);
@@ -83,8 +79,7 @@ void gdc_lut_convert_to_isp_format(const int in_lut[4][HRT_GDC_N], } } -int gdc_get_unity ( -const gdc_ID_t ID ) +int gdc_get_unity (const gdc_ID_t ID ) {assert (ID <N_GDC_ID ); (void )ID ;
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
PATCH v3 3/3 staging: media: atomisp: Remove return from end of void function in gdc.c
In reply to Adrian BarnaśFix checkpatch.pl warning on useless return on the end of the void function.
Signed-off-by Adrian Barnaś <[email protected]>
--- drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +0 -1
@@ -43,7 +43,6 @@ void gdc_lut_store(const gdc_ID_t ID, const int data[4][HRT_GDC_N])gdc_reg_store (ID , lut_offset++, word_0);gdc_reg_store (ID , lut_offset++, word_1); } -return ; }/*
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog
Quoted 4 lines · Adrian Barnaś
Get rid of
gdc_reg_store()forward declaration because it brings no value.Signed-off-by Adrian Barnaś <[email protected]>---
Thanks.
Reviewed-by Dan Carpenter <[email protected]>
regards,
dan carpenter