dt-bindings: gpio: ti,twl4030: Correct the schema $id path
Subsystems (2)
PATCH v5 1/1 dt-bindings: gpio: ti,twl4030: Correct the schema $id path
The $id for a binding should match its file path. The ti,twl4030-gpio binding is located in the gpio/ subdirectory but was missing this from its $id.
Correct the path to follow the standard convention.
---
Changes in v5:
- No changes, only added 'Fixes' tag.
Changes in v4:
- No changes.
- This patch is split from larger series per maintainer feedback.
- v3 link:
https://lore.kernel.org/all/[email protected]/
Changes in v3:
- This patch was added to the patch series in v3.
--- Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/ti,twl4030-gpio.yaml# +$id: http://devicetree.org/schemas/gpio/ti,twl4030-gpio.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: TI TWL4030 GPIO controller
Signature · 1 line
2.39.5
Quoted 8 lines · Jihed Chaibi
The $id for a binding should match its file path. The ti,twl4030-gpio binding is located in the gpio/ subdirectory but was missing this from its $id.
Correct the path to follow the standard convention.
Fixes 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")
Don't add blank lines between tags.
Quoted 6 lines
Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Jihed Chaibi <[email protected]>---
Changes in v5:
- No changes, only added 'Fixes' tag.
Don't resend for that.
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
Quoted 42 lines · Jihed Chaibi
The $id for a binding should match its file path. The ti,twl4030-gpio binding is located in the gpio/ subdirectory but was missing this from its $id.
Correct the path to follow the standard convention.
Fixes 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Jihed Chaibi <[email protected]>---
Changes in v5:
- No changes, only added 'Fixes' tag.Changes in v4:
- No changes.
- This patch is split from larger series per maintainer feedback.
- v3 link:https://lore.kernel.org/all/[email protected]/Changes in v3:
- This patch was added to the patch series in v3.--- Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml +1
-2@@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/ti,twl4030-gpio.yaml# +$id: http://devicetree.org/schemas/gpio/ti,twl4030-gpio.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: TI TWL4030 GPIO controller --
Quoted 2 lines
2.39.5
Hi Bartosz, Linus,
Gentle ping on this fix,
It was reviewed by Krzysztof a couple of months ago. I wonder if it's ready to be picked up.
Cheers,
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 9 lines · Jihed Chaibi
The $id for a binding should match its file path. The ti,twl4030-gpio binding is located in the gpio/ subdirectory but was missing this from its $id.
Correct the path to follow the standard convention.
Fixes 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")[...]
Applied, thanks!
[1/1] dt-bindings: gpio: ti,twl4030: Correct the schema $id path
https://git.kernel.org/brgl/linux/c/4a372798e12cc777918db90c06e11c80e90bd001
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>