Skip to contentSkip to conversation

dt-bindings: rtc: Fix Xicor X1205 vendor prefix

PATCH Applied Rob Herring (Arm) 3 participants 7 messages Aug 21, 2025 – Sep 14, 2025

Subsystems (2)
Device tree bindings Real time clock (RTC)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: rtc: Fix Xicor X1205 vendor prefix

The vendor for the Xircom X1205 RTC is not Xircom, but Xicor which was acquired by Intersil.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/rtc/trivial-rtc.yaml +2 -2
index 7330a7200831..f8a35446d029 100644
@@ -85,8 +85,8 @@ properties:
       - via,vt8500-rtc
       # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
       - whwave,sd3078
-      # Xircom X1205 I2C RTC
-      - xircom,x1205
+      # Xicor/Intersil X1205 I2C RTC
+      - xicor,x1205
 
   reg:
     maxItems: 1
Signature · 1 line
2.50.1
author maintainer
#1 lore raw

PATCH 2/2 rtc: x1205: Fix Xicor X1205 vendor prefix

The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired by Intersil. Since the I2C subsystem drops the vendor prefix for driver matching, the vendor prefix hasn't mattered.

Fixes 6875404fdb44 ("rtc: x1205: Add DT probing support")
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 drivers/rtc/rtc-x1205.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-x1205.c +1 -1
index 4bcd7ca32f27..b8a0fccef14e 100644
@@ -669,7 +669,7 @@ static const struct i2c_device_id x1205_id[] = {
 MODULE_DEVICE_TABLE(i2c, x1205_id);
 
 static const struct of_device_id x1205_dt_ids[] = {
-	{ .compatible = "xircom,x1205", },
+	{ .compatible = "xicor,x1205", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, x1205_dt_ids);
Signature · 1 line
2.50.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

Quoted 6 lines · Rob Herring (Arm)

The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired by Intersil. Since the I2C subsystem drops the vendor prefix for driver matching, the vendor prefix hasn't mattered.

Fixes 6875404fdb44 ("rtc: x1205: Add DT probing support")
Signed-off-by Rob Herring (Arm) <[email protected]>
Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

#3 lore raw

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

In reply to Rob Herring (Arm)
Quoted 6 lines · Rob Herring (Arm)

The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired by Intersil. Since the I2C subsystem drops the vendor prefix for driver matching, the vendor prefix hasn't mattered.

Fixes 6875404fdb44 ("rtc: x1205: Add DT probing support")
Signed-off-by Rob Herring (Arm) <[email protected]>

This should probably be tagged for stable since there is a device tree using this (correct) compatible and it doesn't probe right now.

Yours,
Linus Walleij

author maintainer
#4 lore raw

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

Quoted 7 lines · Linus Walleij
Quoted 4 lines · Rob Herring (Arm)

The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired by Intersil. Since the I2C subsystem drops the vendor prefix for driver matching, the vendor prefix hasn't mattered.

Quoted 6 lines
Quoted 2 lines
Fixes 6875404fdb44 ("rtc: x1205: Add DT probing support")
Signed-off-by Rob Herring (Arm) <[email protected]>

This should probably be tagged for stable since there is a device tree using this (correct) compatible and it doesn't probe right now.

It should probe just fine as I explained. The I2C subsystem strips the vendor prefix off for matching, so what you put doesn't really matter.

Rob

maintainer Applied
#6 lore raw
In reply to Rob Herring (Arm)
Quoted 4 lines · Rob Herring (Arm)

The vendor for the Xircom X1205 RTC is not Xircom, but Xicor which was acquired by Intersil.

Applied, thanks!

[1/2] dt-bindings: rtc: Fix Xicor X1205 vendor prefix

      https://git.kernel.org/abelloni/c/0552f7c67469
[2/2] rtc: x1205: Fix Xicor X1205 vendor prefix
      https://git.kernel.org/abelloni/c/14552d291e50

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com