rust: Update PCI resource_start()/len() to return ResourceSize
PATCH 1/1 rust: Update PCI resource_start()/len() to return ResourceSize
It's nicer to return native Rust types rather than the FFI bindings to a type so update the PCI resource bindings to return ResourceSize.
Signed-off-by Alistair Popple <[email protected]>
Suggested-by Danilo Krummrich <[email protected]>
--- rust/kernel/pci.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
rust/kernel/pci.rs +3 -3
@@ -10,7 +10,7 @@ devres::Devres, driver, error::{from_result, to_result, Result}, - io::{Io, IoRaw}, + io::{resource::ResourceSize, Io, IoRaw}, irq::{self, IrqRequest}, str::CStr, sync::aref::ARef,
@@ -437,7 +437,7 @@ pub fn subsystem_device_id(&self) -> u16 { }/// Returns the start of the given PCI bar resource. -pub fn resource_start (&self, bar:u32 ) ->Result <bindings::resource_size_t > { +pub fn resource_start (&self, bar:u32 ) ->Result <ResourceSize > {if !Bar ::index_is_valid (bar) {return Err (EINVAL ); }
@@ -449,7 +449,7 @@ pub fn resource_start(&self, bar: u32) -> Result<bindings::resource_size_t> { }/// Returns the size of the given PCI bar resource. -pub fn resource_len (&self, bar:u32 ) ->Result <bindings::resource_size_t > { +pub fn resource_len (&self, bar:u32 ) ->Result <ResourceSize > {if !Bar ::index_is_valid (bar) {return Err (EINVAL ); }
Signature · 1 line
2.47.2
Quoted 6 lines · Alistair Popple
It's nicer to return native Rust types rather than the FFI bindings to a type so update the PCI resource bindings to return ResourceSize.
Signed-off-by Alistair Popple <[email protected]>Suggested-by Danilo Krummrich <[email protected]>
Reviewed-by Alice Ryhl <[email protected]>
rust/kernel/pci.rs line 13
Quoted 13 lines
rust/kernel/pci.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)rust/kernel/pci.rs +1
-1@@ -10,7 +10,7 @@ devres::Devres, driver, error::{from_result, to_result, Result}, - io::{Io, IoRaw}, + io::{resource::ResourceSize, Io, IoRaw},
Maybe we want ResourceSize re-exported from kernel::io to make this simpler?
Alice