Skip to contentSkip to conversation

iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

PATCH In review Gustavo A. R. Silva 4 participants 5 messages Aug 11, 2025 – Aug 27, 2025 Intel wireless 3945ABG/bg, 4965AGN (iwlegacy)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

Remove unused structures and avoid the following
-Wflex-array-member-not-at-end warnings:

drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

---
 .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
 1 file changed, 24 deletions(-)
drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h +0 -24
index 1e8ab704dbfb..f00eb878b94b 100644
@@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
 	__le16 duration;
 } __packed;
 
-struct ieee80211_info_element {
-	u8 id;
-	u8 len;
-	u8 data[];
-} __packed;
-
-struct ieee80211_measurement_request {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	struct ieee80211_measurement_params params[];
-} __packed;
-
-struct ieee80211_measurement_report {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	union {
-		struct ieee80211_basic_report basic[0];
-	} u;
-} __packed;
-
 #endif
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Gustavo A. R. Silva

Remove unused structures and avoid the following
-Wflex-array-member-not-at-end warnings:

drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

Quoted 40 lines
---
 .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
 1 file changed, 24 deletions(-)
drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h +0 -24
index 1e8ab704dbfb..f00eb878b94b 100644
@@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
 	__le16 duration;
 } __packed;
 
-struct ieee80211_info_element {
-	u8 id;
-	u8 len;
-	u8 data[];
-} __packed;
-
-struct ieee80211_measurement_request {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	struct ieee80211_measurement_params params[];
-} __packed;
-
-struct ieee80211_measurement_report {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	union {
-		struct ieee80211_basic_report basic[0];
-	} u;
-} __packed;
-
 #endif
Signature · 1 line
2.43.0
#2 lore raw
In reply to Gustavo A. R. Silva

Hi all,

Friendly ping: who can take this, please? :)

Thanks!
-Gustavo

Quoted 44 lines · Gustavo A. R. Silva

Remove unused structures and avoid the following
-Wflex-array-member-not-at-end warnings:

drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

---
  .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
  1 file changed, 24 deletions(-)
drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h +0 -24
index 1e8ab704dbfb..f00eb878b94b 100644
@@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
  	__le16 duration;
  } __packed;
 
-struct ieee80211_info_element {
-	u8 id;
-	u8 len;
-	u8 data[];
-} __packed;
-
-struct ieee80211_measurement_request {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	struct ieee80211_measurement_params params[];
-} __packed;
-
-struct ieee80211_measurement_report {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	union {
-		struct ieee80211_basic_report basic[0];
-	} u;
-} __packed;
-
  #endif
#3 lore raw
Quoted 1 line · Gustavo A. R. Silva

Friendly

I contest that. It's been two weeks, while it's still summer with vacations etc., not long after the merge window closed, with weeks to go until the next release comes around. Why are you impatient?

I will take it. Eventually, the more you push the less I want to. And it'd help if you actually followed our conventions and used 'wifi:' prefix.

johannes

#4 lore raw
Quoted 4 lines · Johannes Berg
Quoted 1 line · Gustavo A. R. Silva

Friendly

I contest that. It's been two weeks, while it's still summer with

Sorry, I don't really know when people around the globe are on vacation or not. I don't think we're based in the same area, so our customs may vary.

Quoted 2 lines

vacations etc., not long after the merge window closed, with weeks to go until the next release comes around. Why are you impatient?

Apparently (and according to git blame), the last person that committed a change to this file was Greg KH back in 2019, see: commit 16da78b7b580e ("treewide: Replace GPLv2 boilerplate/ reference with SPDX - rule 270").

So, rather than impatience is more about not really knowing who's maintaining this file.

Quoted 2 lines

I will take it. Eventually, the more you push the less I want to. And

Not sure what to make of this. I'm just doing my work and trying to collaborate with people. I expect all my comments here clarify the reason for the ping.

Quoted 2 lines

it'd help if you actually followed our conventions and used 'wifi:' prefix.

Related to my comments above, you're not listed as a maintainer of this file. If you were, I'd have probably remembered that.

scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h Stanislaw Gruszka <[email protected]> (maintainer:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy)) [email protected] (open list:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy)) [email protected] (open list)
INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy) status: Supported

In any case, thanks for your response.
-Gustavo