Skip to contentSkip to conversation

dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml

PATCH In review Fabio Estevam 2 participants 4 messages Aug 22, 2025 – Aug 25, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml

The 'target-supply' property is already documented in ahci-common.yaml.

Instead of documenting it locally, add a reference to ahci-common.yaml.

Also change to 'unevaluatedProperties: false' to allow the properties from ahci-common.yaml to be evaluated.

---
 .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml +4 -4
index 2011bd03cdcd..8826aed4ec03 100644
@@ -10,6 +10,9 @@ maintainers:
   - Chen-Yu Tsai <[email protected]>
   - Maxime Ripard <[email protected]>
 
+allOf:
+  - $ref: ahci-common.yaml#
+
 properties:
   compatible:
     const: allwinner,sun4i-a10-ahci
@@ -25,16 +28,13 @@ properties:
   interrupts:
     maxItems: 1
 
-  target-supply:
-    description: Regulator for SATA target power
-
 required:
   - compatible
   - reg
   - clocks
   - interrupts
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Fabio Estevam

The 'target-supply' property is already documented in ahci-common.yaml.

Instead of documenting it locally, add a reference to ahci-common.yaml.

Also change to 'unevaluatedProperties: false' to allow the properties from ahci-common.yaml to be evaluated.

Are the other properties in ahci-common.yaml valid for this device?

Quoted 41 lines
---
 .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml +4 -4
index 2011bd03cdcd..8826aed4ec03 100644
@@ -10,6 +10,9 @@ maintainers:
   - Chen-Yu Tsai <[email protected]>
   - Maxime Ripard <[email protected]>
 
+allOf:
+  - $ref: ahci-common.yaml#
+
 properties:
   compatible:
     const: allwinner,sun4i-a10-ahci
@@ -25,16 +28,13 @@ properties:
   interrupts:
     maxItems: 1
 
-  target-supply:
-    description: Regulator for SATA target power
-
 required:
   - compatible
   - reg
   - clocks
   - interrupts
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
#2 lore raw
Quoted 9 lines · Conor Dooley
Quoted 6 lines · Fabio Estevam

The 'target-supply' property is already documented in ahci-common.yaml.

Instead of documenting it locally, add a reference to ahci-common.yaml.

Also change to 'unevaluatedProperties: false' to allow the properties from ahci-common.yaml to be evaluated.

Are the other properties in ahci-common.yaml valid for this device?

Given the imx patch, are you still pursuing this change?

Quoted 42 lines
Quoted 42 lines
---
 .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml +4 -4
index 2011bd03cdcd..8826aed4ec03 100644
@@ -10,6 +10,9 @@ maintainers:
   - Chen-Yu Tsai <[email protected]>
   - Maxime Ripard <[email protected]>
 
+allOf:
+  - $ref: ahci-common.yaml#
+
 properties:
   compatible:
     const: allwinner,sun4i-a10-ahci
@@ -25,16 +28,13 @@ properties:
   interrupts:
     maxItems: 1
 
-  target-supply:
-    description: Regulator for SATA target power
-
 required:
   - compatible
   - reg
   - clocks
   - interrupts
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
#3 lore raw
Quoted 1 line · Conor Dooley

Given the imx patch, are you still pursuing this change?

Let's discard this one, thanks.