Skip to contentSkip to conversation

dt-bindings: ata: imx: Add a reference to ahci-common.yaml

PATCH In review Fabio Estevam 2 participants 3 messages Aug 22, 2025 – Aug 23, 2025

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 dt-bindings: ata: imx: Add a reference to ahci-common.yaml

The 'target-supply' property is documented in ahci-common.yaml.

Add a reference to ahci-common.yaml to fix the following dt-schema warning:

'target-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'

---
 Documentation/devicetree/bindings/ata/imx-sata.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/ata/imx-sata.yaml +3 -1
index f4eb3550a096..c60866544a53 100644
@@ -88,6 +88,8 @@ required:
   - clock-names
 
 allOf:
+  - $ref: ahci-common.yaml#
+
   - if:
       properties:
         compatible:
@@ -112,7 +114,7 @@ allOf:
         clock-names:
           minItems: 2
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Fabio Estevam

The 'target-supply' property is documented in ahci-common.yaml.

Add a reference to ahci-common.yaml to fix the following dt-schema warning:

Same here I guess, you're allowing a bunch of other properties now, what of those are actually permitted ones for this device?

Quoted 33 lines

'target-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'

---
 Documentation/devicetree/bindings/ata/imx-sata.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/ata/imx-sata.yaml +3 -1
index f4eb3550a096..c60866544a53 100644
@@ -88,6 +88,8 @@ required:
   - clock-names
 
 allOf:
+  - $ref: ahci-common.yaml#
+
   - if:
       properties:
         compatible:
@@ -112,7 +114,7 @@ allOf:
         clock-names:
           minItems: 2
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.34.1
author reviewer
#2 lore raw
Quoted 2 lines · Conor Dooley

Same here I guess, you're allowing a bunch of other properties now, what of those are actually permitted ones for this device?

Only 'target-supply' is actually needed.

I sent v2 documenting 'target-supply'.

Thanks