Skip to contentSkip to conversation

po: Fix GRUB Build With Gettext 0.26

PATCH In review Andrew Hamilton 3 participants 4 messages Aug 23, 2025 – Aug 25, 2025

lore
Share & tools
lore
#0 lore raw

cover po: Fix GRUB Build With Gettext 0.26

Gettext 0.26 validates format strings. In some cases before the GRUB build process was converting newlines sequences (\n) to (\<translated character>) which is invalid. Update the impacted language SED script files to ensure newlines use the correct escape sequence.

This avoids build errors such as:
[email protected]:8192: 'msgstr' is not a valid Shell printf format string, unlike 'msgid'. Reason: This escape sequence is invalid.

Andrew Hamilton (1):
po: Update Translations to Build with Gettext 0.26

 po/arabic.sed   | 2 ++
 po/cyrillic.sed | 2 ++
 po/greek.sed    | 2 ++
 po/hebrew.sed   | 2 ++
 4 files changed, 8 insertions(+)
Signature · 7 lines
2.39.5


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw

PATCH 1/1 po: Update Translations to Build with Gettext 0.26

Gettext 0.26 validates format strings. In some cases before the GRUB build process was converting newlines sequences (\n) to (\<translated character>) which is invalid. Update the impacted language SED script files to ensure newlines use the correct escape sequence.

This avoids build errors such as:
[email protected]:8192: 'msgstr' is not a valid Shell printf format string, unlike 'msgid'. Reason: This escape sequence is invalid.

---
 po/arabic.sed   | 2 ++
 po/cyrillic.sed | 2 ++
 po/greek.sed    | 2 ++
 po/hebrew.sed   | 2 ++
 4 files changed, 8 insertions(+)
po/arabic.sed +2 -0
index 3fbee7248..50bede0f8 100644
@@ -81,3 +81,5 @@ s,%\([0-9]*\)زو,%\1zu,g
 s,%\([0-9]*\)كس,%\1x,g
 s,%\([0-9]*\)لكس,%\1lx,g
 s,%\([0-9]*\)للكس,%\1llx,g
+
+s,\\ن,\\n,g
po/cyrillic.sed +2 -0
index 472f09529..d3db38838 100644
@@ -104,3 +104,5 @@ s,%\([0-9]*\)зу,%\1zu,g
 s,%\([0-9]*\)ѯ,%\1x,g
 s,%\([0-9]*\)лѯ,%\1lx,g
 s,%\([0-9]*\)ллѯ,%\1llx,g
+
+s,\\н,\\n,g
po/greek.sed +2 -0
index 0e81625fb..1ace5fcd2 100644
@@ -106,3 +106,5 @@ s,%\([0-9]*\)ζυ,%\1zu,g
 s,%\([0-9]*\)ξ,%\1x,g
 s,%\([0-9]*\)λξ,%\1lx,g
 s,%\([0-9]*\)λλξ,%\1llx,g
+
+s,\\ν,\\n,g
po/hebrew.sed +2 -0
index 33174bbdc..ce59e576e 100644
@@ -89,3 +89,5 @@ s,%\([0-9]*\)זוּ,%\1zu,g
 s,%\([0-9]*\)כּס,%\1x,g
 s,%\([0-9]*\)לכּס,%\1lx,g
 s,%\([0-9]*\)ללכּס,%\1llx,g
+
+s,\\נ,\\n,g
Signature · 7 lines
2.39.5


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#2 lore raw

Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26

Looks good. Reviewed-by: Vladimir Serbinenko [email protected]

Regards
Vladimir 'phcoder' Serbinenko

Quoted 64 lines · Andrew Hamilton

Gettext 0.26 validates format strings. In some cases before the GRUB build process was converting newlines sequences (\n) to (\<translated character>) which is invalid. Update the impacted language SED script files to ensure newlines use the correct escape sequence.

This avoids build errors such as:
[email protected]:8192: 'msgstr' is not a valid Shell printf format string, unlike 'msgid'. Reason: This escape sequence is invalid.

---
 po/arabic.sed   | 2 ++
 po/cyrillic.sed | 2 ++
 po/greek.sed    | 2 ++
 po/hebrew.sed   | 2 ++
 4 files changed, 8 insertions(+)
po/arabic.sed +2 -0
index 3fbee7248..50bede0f8 100644
@@ -81,3 +81,5 @@ s,%\([0-9]*\)زو,%\1zu,g
 s,%\([0-9]*\)كس,%\1x,g
 s,%\([0-9]*\)لكس,%\1lx,g
 s,%\([0-9]*\)للكس,%\1llx,g
+
+s,\\ن,\\n,g
po/cyrillic.sed +2 -0
index 472f09529..d3db38838 100644
@@ -104,3 +104,5 @@ s,%\([0-9]*\)зу,%\1zu,g
 s,%\([0-9]*\)ѯ,%\1x,g
 s,%\([0-9]*\)лѯ,%\1lx,g
 s,%\([0-9]*\)ллѯ,%\1llx,g
+
+s,\\н,\\n,g
po/greek.sed +2 -0
index 0e81625fb..1ace5fcd2 100644
@@ -106,3 +106,5 @@ s,%\([0-9]*\)ζυ,%\1zu,g
 s,%\([0-9]*\)ξ,%\1x,g
 s,%\([0-9]*\)λξ,%\1lx,g
 s,%\([0-9]*\)λλξ,%\1llx,g
+
+s,\\ν,\\n,g
po/hebrew.sed +2 -1
index 33174bbdc..ce59e576e 100644
@@ -89,3 +89,5 @@ s,%\([0-9]*\)זוּ,%\1zu,g
 s,%\([0-9]*\)כּס,%\1x,g
 s,%\([0-9]*\)לכּס,%\1lx,g
 s,%\([0-9]*\)ללכּס,%\1llx,g
+
+s,\\נ,\\n,g
--

2.39.5

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reviewed-by Daniel Kiper on v1 1/1
#3 lore raw

Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26

In reply to Andrew Hamilton
Quoted 6 lines · Andrew Hamilton

Gettext 0.26 validates format strings. In some cases before the GRUB build process was converting newlines sequences (\n) to (\<translated character>) which is invalid. Update the impacted language SED script files to ensure newlines use the correct escape sequence.

Quoted 7 lines

This avoids build errors such as:
[email protected]:8192: 'msgstr' is not a valid Shell printf format string, unlike 'msgid'. Reason: This escape sequence is invalid.

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel