tools/power/x86/amd_pstate_tracer: Fix python gnuplot package names
PATCH 1/1 tools/power/x86/amd_pstate_tracer: Fix python gnuplot package names
The prerequisites section listed non-existent packages "phython-gnuplot" and "phython3-gnuplot", which may mislead users and cause installation failures.
Update the names to the correct distribution package names "python-gnuplot" and "python3-gnuplot", helping users avoid confusion and saving time for those following the instructions.
--- tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py +1 -1
@@ -11,7 +11,7 @@ Prerequisites: gnuplot 5.0 or higher gnuplot-py 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) Kernel config for Linux trace is enabled
Signature · 1 line
2.34.1
Quoted 9 lines · Kuan-Wei Chiu
The prerequisites section listed non-existent packages "phython-gnuplot" and "phython3-gnuplot", which may mislead users and cause installation failures.
Update the names to the correct distribution package names "python-gnuplot" and "python3-gnuplot", helping users avoid confusion and saving time for those following the instructions.
Signed-off-by Kuan-Wei Chiu <[email protected]>
Quoted 17 lines
--- tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py +1
-1@@ -11,7 +11,7 @@ Prerequisites: gnuplot 5.0 or higher gnuplot-py 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) Kernel config for Linux trace is enabled
Hi Mario,
Quoted 5 lines · Mario Limonciello
Quoted 4 lines · Kuan-Wei Chiu
The prerequisites section listed non-existent packages "phython-gnuplot" and "phython3-gnuplot", which may mislead users and cause installation failures.
Quoted 7 lines
Quoted 5 lines
Update the names to the correct distribution package names "python-gnuplot" and "python3-gnuplot", helping users avoid confusion and saving time for those following the instructions.
Signed-off-by Kuan-Wei Chiu <[email protected]>Reviewed-by Mario Limonciello <[email protected]>
Thanks for your review!
Since the merge window is likely opening in less than a week and this patch has already been submitted and reviewed for about a month, I noticed it still hasn't shown up in linux-next.
May I ask how we plan to route this patch?
Regards,
Kuan-Wei
Mario Limonciello
maintainerQuoted 18 lines · Kuan-Wei Chiu
Hi Mario,
Quoted 5 lines · Mario Limonciello
Quoted 4 lines · Kuan-Wei Chiu
The prerequisites section listed non-existent packages "phython-gnuplot" and "phython3-gnuplot", which may mislead users and cause installation failures.
Quoted 7 lines
Quoted 5 lines
Update the names to the correct distribution package names "python-gnuplot" and "python3-gnuplot", helping users avoid confusion and saving time for those following the instructions.
Signed-off-by Kuan-Wei Chiu <[email protected]>Reviewed-by Mario Limonciello <[email protected]>Thanks for your review!
Quoted 8 lines
Since the merge window is likely opening in less than a week and this patch has already been submitted and reviewed for about a month, I noticed it still hasn't shown up in linux-next.
May I ask how we plan to route this patch?
Regards,
Kuan-Wei
Sorry about that! I had thought being tools/ someone else would pick it up, but I suppose it does make sense to go through amd-pstate (followed by linux-pm). I've picked it up and will send out a PR for linux-pm tomorrow or Thursday.