cxl: Demote extended linear cache missing emissions
Dave Jiang
maintainerPATCH 1/1 cxl: Demote extended linear cache missing emissions
Demote extended linear cache missing emissions to debug level as most systems do not have this feature enabled and the complaint about missing feature is spammy.
--- drivers/cxl/acpi.c | 6 +++--- drivers/cxl/core/region.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/cxl/acpi.c +3 -3
@@ -359,9 +359,9 @@ static int cxl_acpi_set_cache_size(struct cxl_root_decoder *cxlrd)*/ size = size >>1 ;if (cache_size && size != cache_size) { -dev_warn (&cxld->dev, -"Extended Linear Cache size %pa != CXL size %pa. No Support!" , - &cache_size, &size); +dev_dbg (&cxld->dev, +"Extended Linear Cache size %pa != CXL size %pa. No Support!" , + &cache_size, &size);return -ENXIO ; }
drivers/cxl/core/region.c +3 -3
@@ -3306,9 +3306,9 @@ static int cxl_extended_linear_cache_resize(struct cxl_region *cxlr,return 0 ;if (size != cache_size) { -dev_warn (&cxlr->dev, -"Extended Linear Cache size %pa != CXL size %pa. No Support!" , - &cache_size, &size); +dev_dbg (&cxlr->dev, +"Extended Linear Cache size %pa != CXL size %pa. No Support!" , + &cache_size, &size);return -ENXIO ; }
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
Signature · 1 line
2.50.1
Quoted 16 lines · Dave Jiang
Demote extended linear cache missing emissions to debug level as most systems do not have this feature enabled and the complaint about missing feature is spammy.
Suggeted-by Dan Williams <[email protected]>Signed-off-by Dave Jiang <[email protected]>--- drivers/cxl/acpi.c | 6 +++--- drivers/cxl/core/region.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)drivers/cxl/acpi.c +0
-0
drivers/cxl/acpi.c static int cxl_acpi_set_cache_size(struct cxl_root_decoder *cxlrd) · line 364
Quoted 9 lines
drivers/cxl/acpi.c +3
-3@@ -359,9 +359,9 @@ static int cxl_acpi_set_cache_size(struct cxl_root_decoder *cxlrd)*/ size = size >>1 ;if (cache_size && size != cache_size) { -dev_warn (&cxld->dev, -"Extended Linear Cache size %pa != CXL size %pa. No Support!" , - &cache_size, &size); +dev_dbg (&cxld->dev, +"Extended Linear Cache size %pa != CXL size %pa. No Support!" , + &cache_size, &size);
The log spam I was seeing was:
"cxl root0: Extended linear cache calculation failed rc:-2"
The concern is whether this mismatch should be reported or result in a more violent fallback of disabling CXL regions altogether and fallback to EFI_MEMORY_SP delineated dax devices. I think at any point where the driver is confused by firmware the CXL subsystem should probably try to fail safely into vanilla device-dax mode. This needs Smita's work, but there is really nothing the user can do about a persistent boot warning unless there is a chance they can get a fix from their BIOS vendor.