Add tls parameter and flag:CLONE_SETTLS cover for clone and clone3 syscall
PATCH v14 1/1 Add tls parameter and flag:CLONE_SETTLS cover for clone and clone3 syscall
tls parameter and related flag:CLONE_SETTLS are missed in the testing, so add them into existed test case
---
Changes in v14:
- Fix clone304 occasional failure on Fedora x86_64 by removing CLONE_THREAD since threads created with CLONE_THREAD are in the same thread group as the caller
Changes in v13:
- Fix clone304 failure on Fedora x86_64 by moving free_tls() into check_tls_in_child method
Changes in v12:
- Fix make check reporting errors and warnings
- Add the __NR_exit
Changes in v11:
- Put the tls init/alloc/free functions into a common header in lapi/tls.h
- Use TST_CHECKPOINT_* for parent/child synchronization
Changes in v10:
- Fix fedora42 failure by adding tcb
- Add missing usleep(1000) in free_tls
Changes in v9:
- allow small delay by using usleep before call free_tls
- validate ./clone10 -i 10 on aarch64 and x86_64, both pass
Changes in v8:
- call free_tls() in touch_tls_in_child instead of cleanup
- remove CFLAGS += -fsanitize=address in Makefile to fix memory double free issue
Changes in v7:
- remove unnecessary in verify_tls()
- add CFLAGS += -fsanitize=address in Makefile to fix memory double free issue
Changes in v6:
- update flag to effective combination
- combine x86_64 with other arches
- rename child function
- remove inproper exit
- remove unused code lines
- remove sleep statement
Changes in v5:
- wrap duplicate code into one single methold
- remove duplicately malloc
Changes in v4:
- remove riscv and loongarch definition
Changes in v3:
- fix missing head file for x86
Changes in v2:
- create separate files for clone and clone3
--- include/lapi/tls.h | 102 ++++++++++++++++++ runtest/syscalls | 2 + testcases/kernel/syscalls/clone/.gitignore | 1 + testcases/kernel/syscalls/clone/clone10.c | 100 ++++++++++++++++++ testcases/kernel/syscalls/clone3/.gitignore | 1 + testcases/kernel/syscalls/clone3/clone304.c | 110 ++++++++++++++++++++ 6 files changed, 316 insertions(+) create mode 100644 include/lapi/tls.h create mode 100644 testcases/kernel/syscalls/clone/clone10.c create mode 100644 testcases/kernel/syscalls/clone3/clone304.c
include/lapi/tls.h new file +102 -0
@@ -0,0 +1,102 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2025 Red Hat Inc. All Rights Reserved. +* Author: Chunfu Wen <[email protected]> +*/ + +/*\ +* tls init/alloc/free common functions +*/ + +#ifndef _LAPI_TLS_H +#define _LAPI_TLS_H + +#include <stdlib.h> +#include <string.h> +#include <stdint.h> +#include <stdio.h> +#include <unistd.h> + +#if defined(__i386__) +#include <asm/ldt.h> +#endif + +#include "tst_test.h" + +#define TLS_SIZE 4096 +#define TLS_ALIGN 16 + +#if defined(__x86_64__) +// Structure mimicking glibc's TCB to be simplified for x86_64 +typedef struct { +void *tcb; +void *dtv; +void *self; +int multiple_threads; +char padding[64 ]; +}tcb_t ; +#endif + +// Global pointers for TLS management +extern void *tls_ptr; +extern struct user_desc *tls_desc; + +static inline void *allocate_tls_area (void ) +{ +void *tls_area =aligned_alloc (TLS_ALIGN ,TLS_SIZE ); +if (!tls_area) +tst_brk (TBROK |TERRNO ,"aligned_alloc failed" ); +memset (tls_area,0 ,TLS_SIZE ); + +#if defined(__x86_64__) +// Set up a minimal TCB for x86_64 +tcb_t *tcb = (tcb_t *)tls_area; + tcb->tcb = tls_area; + tcb->self = tls_area; + tcb->multiple_threads =1 ; +#endif +return tls_area; +} + +static inline void init_tls (void ) +{ +#if defined(__x86_64__) || defined(__aarch64__) || defined(__s390x__) + tls_ptr =allocate_tls_area (); + +#elif defined(__i386__) + tls_ptr =allocate_tls_area (); + tls_desc =SAFE_MALLOC (sizeof (*tls_desc)); +memset (tls_desc,0 ,sizeof (*tls_desc)); + tls_desc->entry_number =-1 ; + tls_desc->base_addr = (unsigned long )tls_ptr; + tls_desc->limit =TLS_SIZE ; + tls_desc->seg_32bit =1 ; + tls_desc->contents =0 ; + tls_desc->read_exec_only =0 ; + tls_desc->limit_in_pages =0 ; + tls_desc->seg_not_present =0 ; + tls_desc->useable =1 ; + +#else +tst_brk (TCONF ,"Unsupported architecture for TLS" ); +#endif +} + +static inline void free_tls (void ) +{ +usleep (1000 ); +#if defined(__x86_64__) || defined(__aarch64__) || defined(__s390x__) +if (tls_ptr) { +free (tls_ptr); + tls_ptr =NULL ; + } +#elif defined(__i386__) +if (tls_desc) { +free ((void *)(uintptr_t )tls_desc->base_addr); +free (tls_desc); + tls_desc =NULL ; + } +#endif +} + +#endif // _LAPI_TLS_H
runtest/syscalls +2 -0
@@ -122,10 +122,12 @@ clone06 clone06 clone07 clone07 clone08 clone08 clone09 clone09 +clone10 clone10 clone301 clone301 clone302 clone302 clone303 clone303 +clone304 clone304 close01 close01 close02 close02
testcases/kernel/syscalls/clone/.gitignore +1 -0
@@ -7,3 +7,4 @@ /clone07 /clone08 /clone09 +/clone10
testcases/kernel/syscalls/clone/clone10.c new file +100 -0
100 lines not on this page · raw message
testcases/kernel/syscalls/clone3/.gitignore +1 -0
@@ -1,3 +1,4 @@ clone301 clone302 clone303 +clone304
testcases/kernel/syscalls/clone3/clone304.c new file +110 -0
110 lines not on this page · raw message
Signature · 5 lines
2.43.5 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Can you please check the CI? The patch-set is not compiling in both opensuse/archive:42.2 and ubuntu:bionic
https://github.com/linux-test-project/ltp/actions/runs/16932202541/job/47980182839
Signature · 7 lines
Andrea Cervesato SUSE QE Automation Engineer Linux [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hello Andrea,
Thank you for reaching out to me.
I submitted a new patch:
https://lists.linux.it/pipermail/ltp/2025-October/045478.html to fix it. Please let me know whether it can work.
Best regards,
Chunfu Wen
Quoted 15 lines · Andrea Cervesato
Hi!
Can you please check the CI? The patch-set is not compiling in both opensuse/archive:42.2 and ubuntu:bionic
https://github.com/linux-test-project/ltp/actions/runs/16932202541/job/47980182839
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp