Skip to contentSkip to conversation

Convert ip6_finish_output to rawfbt

PATCH In review [email protected] 2 participants 2 messages Aug 26, 2025 – Aug 27, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Convert ip6_finish_output to rawfbt

From: Eugene Loh <[email protected]>

With commit fe2101e55 ("fbt: implement based on fentry/fexit probes") test/unittest/ip/tst.ipv6localicmp.sh started to fail. The problem appears to be that fbt::ip6_finish_output:entry, which is needed for ip:::send, does not fire.

Use rawfbt for this probe to revert back to kprobes in this case.

Other fbt probes may also be impacted, but this case showed up in testing.

---
 libdtrace/dt_prov_ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libdtrace/dt_prov_ip.c +1 -1
index e09198061..5384346bd 100644
@@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
 	{ "send",
 	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
 	{ "send",
-	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
+	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
 	{ NULL, }
 };
 
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · On 26/08/2025 23:04, [email protected] wrote:

From: Eugene Loh <[email protected]>

With commit fe2101e55 ("fbt: implement based on fentry/fexit probes") test/unittest/ip/tst.ipv6localicmp.sh started to fail. The problem appears to be that fbt::ip6_finish_output:entry, which is needed for ip:::send, does not fire.

Quoted 5 lines

Use rawfbt for this probe to revert back to kprobes in this case.

Other fbt probes may also be impacted, but this case showed up in testing.

Quoted 17 lines
---
 libdtrace/dt_prov_ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libdtrace/dt_prov_ip.c +1 -1
index e09198061..5384346bd 100644
@@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
 	{ "send",
 	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
 	{ "send",
-	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
+	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
 	{ NULL, }
 };