pcie: starfive: Fix the incorrect use of dev_err()
PATCH 1/1 pcie: starfive: Fix the incorrect use of dev_err()
Use dev_info() instead of dev_err() when finishing the probe function.
--- drivers/pci/pcie_starfive_jh7110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie_starfive_jh7110.c +1 -1
@@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)if (ret)return ret; -dev_err (dev,"Starfive PCIe bus probed.\n" ); +dev_info (dev,"StarFive PCIe bus probed\n" );return 0 ; }
base-commit: 3dc5e9a0108bb114175b6362f9cb22367402f624
Signature · 1 line
2.43.2
Quoted 13 lines · Hal Feng
Use
dev_info()instead ofdev_err()when finishing the probe function.Signed-off-by Hal Feng <[email protected]>--- drivers/pci/pcie_starfive_jh7110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/pcie_starfive_jh7110.c +0
-0
drivers/pci/pcie_starfive_jh7110.c static int starfive_pcie_probe(struct udevice *dev) · line 295
Quoted 5 lines
drivers/pci/pcie_starfive_jh7110.c +1
-1@@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)if (ret)return ret; -dev_err (dev,"Starfive PCIe bus probed.\n" ); +dev_info (dev,"StarFive PCIe bus probed\n" );
Or maybe remove this line.
We don't need drivers stating that they probed successfully.
Probe errors are helpful to print; probe success is not.
Quoted 20 lines · Fabio Estevam
Review
Quoted 9 lines · Hal Feng
Use
dev_info()instead ofdev_err()when finishing the probe function.Signed-off-by Hal Feng <[email protected]>--- drivers/pci/pcie_starfive_jh7110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/pci/pcie_starfive_jh7110.cQuoted 7 lines
index
51aca7359ff..f2256307ab3100644drivers/pci/pcie_starfive_jh7110.c +0
-0@@ -292,7 +292,7 @@ static int starfive_pcie_probe(struct udevice *dev)if (ret)return ret;
Quoted 8 lines
drivers/pci/pcie_starfive_jh7110.c static int starfive_pcie_probe(struct udevice *dev) · line 295
Quoted 2 lines
drivers/pci/pcie_starfive_jh7110.c +1
-1-dev_err (dev,"Starfive PCIe bus probed.\n" ); +dev_info (dev,"StarFive PCIe bus probed\n" );Or maybe remove this line.
We don't need drivers stating that they probed successfully.
Probe errors are helpful to print; probe success is not.
Agree with you. Let's remove this line. Thanks.
Best regards,
Hal