Skip to contentSkip to conversation

net: ethernet: ti: Prevent divide-by-zero in cpts_calc_mult_shift()

PATCH NAK Miaoqian Lin 3 participants 5 messages Aug 28, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: ti: Prevent divide-by-zero in cpts_calc_mult_shift()

cpts_calc_mult_shift() has a potential divide-by-zero in this line:

        do_div(maxsec, freq);

due to the fact that clk_get_rate() can return zero in certain error conditions.
Add an explicit check to fix this.

Fixes 88f0f0b0bebf ("net: ethernet: ti: cpts: calc mult and shift from refclk freq")

---
This follows the same pattern as the fix in commit 7ca59947b5fc ("pwm: mediatek: Prevent divide-by-zero in pwm_mediatek_config()").

---
 drivers/net/ethernet/ti/cpts.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/ti/cpts.c +2 -0
index 2ba4c8795d60..e4e3409e7648 100644
@@ -607,6 +607,8 @@ static void cpts_calc_mult_shift(struct cpts *cpts)
 	u32 freq;
 
 	freq = clk_get_rate(cpts->refclk);
+	if (!freq)
+		return;
 
 	/* Calc the maximum number of seconds which we can run before
 	 * wrapping around.
Signature · 1 line
2.39.5 (Apple Git-154)
#1 lore raw
Quoted 33 lines · Miaoqian Lin

cpts_calc_mult_shift() has a potential divide-by-zero in this line:

        do_div(maxsec, freq);

due to the fact that clk_get_rate() can return zero in certain error conditions.
Add an explicit check to fix this.

Fixes 88f0f0b0bebf ("net: ethernet: ti: cpts: calc mult and shift from refclk freq")

---
This follows the same pattern as the fix in commit 7ca59947b5fc ("pwm: mediatek: Prevent divide-by-zero in pwm_mediatek_config()").

---
 drivers/net/ethernet/ti/cpts.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/ti/cpts.c +2 -0
index 2ba4c8795d60..e4e3409e7648 100644
@@ -607,6 +607,8 @@ static void cpts_calc_mult_shift(struct cpts *cpts)
 	u32 freq;
 
 	freq = clk_get_rate(cpts->refclk);
+	if (!freq)
+		return;
 
 	/* Calc the maximum number of seconds which we can run before
 	 * wrapping around.
Signature · 1 line
2.39.5 (Apple Git-154)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#2 lore raw
In reply to Miaoqian Lin
Quoted 6 lines · Miaoqian Lin

cpts_calc_mult_shift() has a potential divide-by-zero in this line:

         do_div(maxsec, freq);

due to the fact that clk_get_rate() can return zero in certain error conditions.

Have you seen this happening in the real environment, or is it just analysis of the code? I don't see a reason for these "certain error conditions" to happen...

author
#3 lore raw

Hi, Vadim

Quoted 4 lines · Vadim Fedorenko <[email protected]> 于2025年8月28日周四 20:06写道:
Quoted 2 lines · Miaoqian Lin

cpts_calc_mult_shift() has a potential divide-by-zero in this line:

Quoted 8 lines
Quoted 4 lines
         do_div(maxsec, freq);

due to the fact that clk_get_rate() can return zero in certain error conditions.

Have you seen this happening in the real environment, or is it just analysis of the code? I don't see a reason for these "certain error conditions" to happen...

This is from code analysis, not from real environment. The !CONFIG_HAVE_CLK version of clk_get_rate() returns zero. With CONFIG_COMPILE_TEST && !CONFIG_HAVE_CLK could have the problem. This may be theoretical.

#4 lore raw
Quoted 12 lines · æå¦å©

Hi, Vadim

Quoted 9 lines · Vadim Fedorenko <[email protected]> 于2025年8月28日周四 20:06写道:
Quoted 6 lines · Miaoqian Lin

cpts_calc_mult_shift() has a potential divide-by-zero in this line:

          do_div(maxsec, freq);

due to the fact that clk_get_rate() can return zero in certain error conditions.

Quoted 8 lines
Quoted 3 lines

Have you seen this happening in the real environment, or is it just analysis of the code? I don't see a reason for these "certain error conditions" to happen...

This is from code analysis, not from real environment. The !CONFIG_HAVE_CLK version of clk_get_rate() returns zero. With CONFIG_COMPILE_TEST && !CONFIG_HAVE_CLK could have the problem. This may be theoretical.

!CONFIG_HAVE_CLK will have cpts_create() doing nothing as defined in cpts.h and it means the patch fixes impossible scenario.

NAck