drm/amd: Re-enable common modes for eDP and LVDS
Subsystems (3)
PATCH 1/1 drm/amd: Re-enable common modes for eDP and LVDS
[Why]
Although compositors will add their own modes, Xorg won't use it's own modes and will only stick to modes advertised by the driver. This mean a user that used to pick 1024x768 could no longer access it unless the panel's native resolution was 1024x768.
[How]
Revert commit 6d396e7ac1ce3 ("drm/amd/display: Disable common modes for LVDS") and commit 7948afb46af92 ("drm/amd/display: Disable common modes for eDP").
The panel will still use scaling for any non-native modes due to commit 978fa2f6d0b12 ("drm/amd/display: Use scaling for non-native resolutions on eDP")
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -2
@@ -8440,8 +8440,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)drm_add_modes_noedid (connector,1920 ,1080 ); }else {amdgpu_dm_connector_ddc_get_modes (connector, drm_edid); -if (encoder && (connector->connector_type != DRM_MODE_CONNECTOR_eDP) && - (connector->connector_type !=DRM_MODE_CONNECTOR_LVDS )) +if (encoder)amdgpu_dm_connector_add_common_modes (encoder, connector);amdgpu_dm_connector_add_freesync_modes (connector, drm_edid); }
Signature · 1 line
2.43.0
Quoted 12 lines · Mario Limonciello (AMD)
[Why]
Although compositors will add their own modes, Xorg won't use it's own modes and will only stick to modes advertised by the driver. This mean a user that used to pick 1024x768 could no longer access it unless the panel's native resolution was 1024x768.[How]
Revert commit6d396e7ac1ce3("drm/amd/display: Disable common modes for LVDS") and commit7948afb46af92("drm/amd/display: Disable common modes for eDP").
Quoted 7 lines
The panel will still use scaling for any non-native modes due to commit
978fa2f6d0b12("drm/amd/display: Use scaling for non-native resolutions on eDP")
Quoted 21 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-3@@ -8440,8 +8440,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)drm_add_modes_noedid (connector,1920 ,1080 ); }else {amdgpu_dm_connector_ddc_get_modes (connector, drm_edid); -if (encoder && (connector->connector_type != DRM_MODE_CONNECTOR_eDP) && - (connector->connector_type !=DRM_MODE_CONNECTOR_LVDS )) +if (encoder)amdgpu_dm_connector_add_common_modes (encoder, connector);amdgpu_dm_connector_add_freesync_modes (connector, drm_edid); } --2.43.0
Quoted 11 lines · Mario Limonciello (AMD)
[Why]
Although compositors will add their own modes, Xorg won't use it's own modes and will only stick to modes advertised by the driver. This mean a user that used to pick 1024x768 could no longer access it unless the panel's native resolution was 1024x768.[How]
Revert commit6d396e7ac1ce3("drm/amd/display: Disable common modes for LVDS") and commit7948afb46af92("drm/amd/display: Disable common modes for eDP").
Quoted 7 lines
The panel will still use scaling for any non-native modes due to commit
978fa2f6d0b12("drm/amd/display: Use scaling for non-native resolutions on eDP")
Harry
Quoted 18 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-2@@ -8440,8 +8440,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)drm_add_modes_noedid (connector,1920 ,1080 ); }else {amdgpu_dm_connector_ddc_get_modes (connector, drm_edid); -if (encoder && (connector->connector_type != DRM_MODE_CONNECTOR_eDP) && - (connector->connector_type !=DRM_MODE_CONNECTOR_LVDS )) +if (encoder)amdgpu_dm_connector_add_common_modes (encoder, connector);amdgpu_dm_connector_add_freesync_modes (connector, drm_edid); }