Skip to contentSkip to conversation

x86/pvshim: disable PDX compression in PV shim defconfig

PATCH In review Roger Pau Monne 2 participants 5 messages Aug 29, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pvshim: disable PDX compression in PV shim defconfig

There's no need for PDX compression given the memory map provided by Xen to guests is contiguous, turn off the feature by default in the PV shim defconfig.

Fixes c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on region offsets')
---
 xen/arch/x86/configs/pvshim_defconfig | 1 +
 1 file changed, 1 insertion(+)
xen/arch/x86/configs/pvshim_defconfig +1 -0
index c58c29adb0bf..24f4e4857dde 100644
@@ -7,6 +7,7 @@ CONFIG_PV_SHIM_EXCLUSIVE=y
 CONFIG_NR_CPUS=32
 CONFIG_EXPERT=y
 # Disable features not used by the PV shim
+CONFIG_PDX_NONE=y
 # CONFIG_XEN_SHSTK is not set
 # CONFIG_XEN_IBT is not set
 # CONFIG_GRANT_TABLE is not set
Signature · 1 line
2.51.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Roger Pau Monne

There's no need for PDX compression given the memory map provided by Xen to guests is contiguous, turn off the feature by default in the PV shim defconfig.

Fixes c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on region offsets')

Not sure if a Fixes: tag is really appropriate here. The shim is working as is, just carrying code which won't ever be used.

Jan

#2 lore raw
Quoted 5 lines · Jan Beulich
Quoted 4 lines · Roger Pau Monne

There's no need for PDX compression given the memory map provided by Xen to guests is contiguous, turn off the feature by default in the PV shim defconfig.

Quoted 8 lines
Quoted 3 lines
Fixes c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on region offsets')

Not sure if a Fixes: tag is really appropriate here. The shim is working as is, just carrying code which won't ever be used.

I was borderline also, but I felt it was important to notice that the change here should ideally had been part of that commit. Do you have a recommendation of any other tag I could use for that purpose?

Thanks, Roger.

#3 lore raw
Quoted 10 lines · Roger Pau Monné
Quoted 9 lines · Jan Beulich
Quoted 7 lines · Roger Pau Monne

There's no need for PDX compression given the memory map provided by Xen to guests is contiguous, turn off the feature by default in the PV shim defconfig.

Fixes c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on region offsets')
Quoted 8 lines
Quoted 4 lines

Not sure if a Fixes: tag is really appropriate here. The shim is working as is, just carrying code which won't ever be used.

I was borderline also, but I felt it was important to notice that the change here should ideally had been part of that commit. Do you have a recommendation of any other tag I could use for that purpose?

In rare cases I think I've used Amends: (not formally mentioned anywhere, of course).

Jan

#4 lore raw
Quoted 16 lines · Jan Beulich
Quoted 15 lines · Roger Pau Monné
Quoted 13 lines · Jan Beulich
Quoted 7 lines · Roger Pau Monne

There's no need for PDX compression given the memory map provided by Xen to guests is contiguous, turn off the feature by default in the PV shim defconfig.

Fixes c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on region offsets')

Not sure if a Fixes: tag is really appropriate here. The shim is working as is, just carrying code which won't ever be used.

Quoted 6 lines
Quoted 3 lines

I was borderline also, but I felt it was important to notice that the change here should ideally had been part of that commit. Do you have a recommendation of any other tag I could use for that purpose?

In rare cases I think I've used Amends: (not formally mentioned anywhere, of course).

Oh, how would you feel about adding it formally to sending-patches.pandoc?

It's a rare tag, but I would find it useful in contexts like the above.

Thanks, Roger.