usb: usblp: Use min_t() to improve usblp_read()
Subsystems (2)
PATCH 1/1 usb: usblp: Use min_t() to improve usblp_read()
Use min_t() to improve usblp_read() and avoid calculating 'avail - usblp->readcount' twice. Use min_t(ssize_t,,) instead of min() to avoid a signedness error.
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/usb/class/usblp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/class/usblp.c +2 -1
@@ -34,6 +34,7 @@#include <linux/module.h> #include <linux/kernel.h> +#include <linux/minmax.h> #include <linux/sched/signal.h> #include <linux/signal.h> #include <linux/poll.h>
@@ -871,7 +872,7 @@ static ssize_t usblp_read(struct file *file, char __user *buffer, size_t len, lo goto done; } - count = len < avail - usblp->readcount ? len : avail - usblp->readcount; + count =min_t (ssize_t, len, avail - usblp->readcount);if (count !=0 &©_to_user (buffer, usblp->readbuf + usblp->readcount, count)) { count = -EFAULT ;
Signature · 1 line
2.50.1