usb: ucsi: stm32: Use min() to improve ucsi_stm32g0_fw_cb()
Subsystems (3)
PATCH 1/1 usb: ucsi: stm32: Use min() to improve ucsi_stm32g0_fw_cb()
Use min() to improve ucsi_stm32g0_fw_cb() and avoid calculating 'end - data' twice.
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/usb/typec/ucsi/ucsi_stm32g0.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/usb/typec/ucsi/ucsi_stm32g0.c +2 -5
@@ -10,6 +10,7 @@#include <linux/firmware.h> #include <linux/i2c.h> #include <linux/interrupt.h> +#include <linux/minmax.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/unaligned.h>
@@ -523,11 +524,7 @@ static void ucsi_stm32g0_fw_cb(const struct firmware *fw, void *context) data = fw->data; end = fw->data + fw->size;while (data < end) { -if ((end - data) <STM32G0_I2C_BL_SZ ) - size = end - data; -else - size =STM32G0_I2C_BL_SZ ; - + size =min (end - data,STM32G0_I2C_BL_SZ ); ret =ucsi_stm32g0_bl_write (g0->ucsi, addr, data, size);if (ret) {dev_err (g0->dev,"Write failed %d\n" , ret);
Signature · 1 line
2.50.1
Quoted 4 lines · Thorsten Blum
Use
min()to improveucsi_stm32g0_fw_cb()and avoid calculating 'end - data' twice.Signed-off-by Thorsten Blum <[email protected]>
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 31 lines
--- drivers/usb/typec/ucsi/ucsi_stm32g0.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/usb/typec/ucsi/ucsi_stm32g0.c +2
-5@@ -10,6 +10,7 @@#include <linux/firmware.h> #include <linux/i2c.h> #include <linux/interrupt.h> +#include <linux/minmax.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/unaligned.h> @@ -523,11 +524,7 @@ static void ucsi_stm32g0_fw_cb(const struct firmware *fw, void *context) data = fw->data; end = fw->data + fw->size;while (data < end) { -if ((end - data) <STM32G0_I2C_BL_SZ ) - size = end - data; -else - size =STM32G0_I2C_BL_SZ ; - + size =min (end - data,STM32G0_I2C_BL_SZ ); ret =ucsi_stm32g0_bl_write (g0->ucsi, addr, data, size);if (ret) {dev_err (g0->dev,"Write failed %d\n" , ret);Signature · 1 line
2.50.1
Signature · 1 line
heikki