Skip to contentSkip to conversation

selftests: drv-net: csum: fix interface name for remote host

PATCH Applied Jakub Kicinski 4 participants 4 messages Aug 30, 2025 – Sep 1, 2025

Subsystems (3)
Networking Network drivers Kselftest
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: drv-net: csum: fix interface name for remote host

Use cfg.remote_ifname for arguments of remote command. Without this UDP tests fail in NIPA where local interface is called enp1s0 and remote enp0s4.

Fixes 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
Signed-off-by Jakub Kicinski <[email protected]>

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/drivers/net/hw/csum.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/drivers/net/hw/csum.py +2 -2
index cd23af875317..3e3a89a34afe 100755
@@ -17,7 +17,7 @@ from lib.py import bkg, cmd, wait_port_listen
     ip_args = f"-{ipver} -S {cfg.remote_addr_v[ipver]} -D {cfg.addr_v[ipver]}"
 
     rx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -n 100 {ip_args} -r 1 -R {extra_args}"
-    tx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
+    tx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
 
     with bkg(rx_cmd, exit_wait=True):
         wait_port_listen(34000, proto="udp")

@@ -37,7 +37,7 @@ from lib.py import bkg, cmd, wait_port_listen
     if extra_args != "-U -Z":
         extra_args += " -r 1"
 
-    rx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
+    rx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
     tx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -L 1 -n 100 {ip_args} -T {extra_args}"
 
     with bkg(rx_cmd, host=cfg.remote, exit_wait=True):
Signature · 1 line
2.51.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 29 lines · Jakub Kicinski

Use cfg.remote_ifname for arguments of remote command. Without this UDP tests fail in NIPA where local interface is called enp1s0 and remote enp0s4.

Fixes 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
Signed-off-by Jakub Kicinski <[email protected]>

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
  tools/testing/selftests/drivers/net/hw/csum.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/drivers/net/hw/csum.py +1 -1
index cd23af875317..3e3a89a34afe 100755
@@ -17,7 +17,7 @@ from lib.py import bkg, cmd, wait_port_listen
      ip_args = f"-{ipver} -S {cfg.remote_addr_v[ipver]} -D {cfg.addr_v[ipver]}"
 
      rx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -n 100 {ip_args} -r 1 -R {extra_args}"
-    tx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
+    tx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
 
      with bkg(rx_cmd, exit_wait=True):
          wait_port_listen(34000, proto="udp")

tools/testing/selftests/drivers/net/hw/csum.py from lib.py import bkg, cmd, wait_port_listen · line 43

Quoted 8 lines
tools/testing/selftests/drivers/net/hw/csum.py +1 -1
@@ -37,7 +37,7 @@ from lib.py import bkg, cmd, wait_port_listen
      if extra_args != "-U -Z":
          extra_args += " -r 1"
 
-    rx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
+    rx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
      tx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -L 1 -n 100 {ip_args} -T {extra_args}"
 
      with bkg(rx_cmd, host=cfg.remote, exit_wait=True):
Reviewed-by Vadim Fedorenko <[email protected]>
CI Applied
#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Sat, 30 Aug 2025 11:38:42 -0700 you wrote:

Use cfg.remote_ifname for arguments of remote command. Without this UDP tests fail in NIPA where local interface is called enp1s0 and remote enp0s4.

Fixes 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
Signed-off-by Jakub Kicinski <[email protected]>

[...]

Here is the summary with links:
- [net] selftests: drv-net: csum: fix interface name for remote host

    https://git.kernel.org/netdev/net/c/49c2502b5946

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html