clk: samsung: exynos990: Fix USB clock support
v2 cover clk: samsung: exynos990: Fix USB clock support
Hi,
Small fixes for Exynos990 HSI0 USB clocks:
Add missing LHS_ACEL clock ID and implementation, plus two missing USB clock registers. Without these, USB connections fail with errors like device descriptor read timeouts and address response issues.
These changes ensure proper USB operation by adding critical missing clock definitions.
Denzeel Oliva
Changes in v2:
- Removed fixes tags and stable Cc
---
Denzeel Oliva (3):
dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
clk: samsung: exynos990: Add LHS_ACEL gate clock for HSI0 and update CLK_NR_TOP
clk: samsung: exynos990: Add missing USB clock registers to HSI0
drivers/clk/samsung/clk-exynos990.c | 8 +++++++- include/dt-bindings/clock/samsung,exynos990.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-)
---
base-commit: e0edfc39b62e35dfb6d669b1189fa268147345ef
change-id: 20250830-usb-c8d352f5de9f
Best regards,
Signature · 1 line
Denzeel Oliva <[email protected]>
PATCH v2 1/3 dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
Add the missing LHS_ACEL clock ID for the HSI0 block. This clock is required for proper USB operation, as without it, USB connections fail with errors like device descriptor read timeouts and address response issues.
--- include/dt-bindings/clock/samsung,exynos990.h | 1 + 1 file changed, 1 insertion(+)
include/dt-bindings/clock/samsung,exynos990.h +1 -0
@@ -236,6 +236,7 @@#define CLK_GOUT_HSI0_VGEN_LITE_HSI0_CLK 20#define CLK_GOUT_HSI0_CMU_HSI0_PCLK 21#define CLK_GOUT_HSI0_XIU_D_HSI0_ACLK 22 +#define CLK_GOUT_HSI0_LHS_ACEL_D_HSI0_CLK 23/* CMU_PERIS */ #define CLK_MOUT_PERIS_BUS_USER 1
Signature · 1 line
2.50.1
Re: [PATCH v2 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
Quoted 10 lines · Denzeel Oliva
Add the missing
LHS_ACELclock ID for the HSI0 block. This clock is required for proper USB operation, as without it, USB connections fail with errors like device descriptor read timeouts and address response issues.Signed-off-by Denzeel Oliva <[email protected]>--- include/dt-bindings/clock/samsung,exynos990.h | 1 + 1 file changed, 1 insertion(+)
PATCH v2 2/3 clk: samsung: exynos990: Add LHS_ACEL gate clock for HSI0 and update CLK_NR_TOP
In reply to Denzeel OlivaAdd the LHS_ACEL gate clock to the HSI0 clock controller. This clock is critical for USB functionality and mark it as critical to keep it enabled.
Update CLK_NR_TOP to include the new clock.
--- drivers/clk/samsung/clk-exynos990.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/clk/samsung/clk-exynos990.c +5 -1
@@ -18,7 +18,7 @@/* NOTE: Must be equal to the last clock ID increased by one */ #define CLKS_NR_TOP (CLK_DOUT_CMU_CLK_CMUREF + 1) -#define CLKS_NR_HSI0 (CLK_GOUT_HSI0_XIU_D_HSI0_ACLK + 1) +#define CLKS_NR_HSI0 (CLK_GOUT_HSI0_LHS_ACEL_D_HSI0_CLK + 1)#define CLKS_NR_PERIS (CLK_GOUT_PERIS_OTP_CON_TOP_OSCCLK + 1)/* ---- CMU_TOP ------------------------------------------------------------- */
@@ -1332,6 +1332,10 @@ static const struct samsung_gate_clock hsi0_gate_clks[] __initconst = { "gout_hsi0_xiu_d_hsi0_aclk", "mout_hsi0_bus_user",CLK_CON_GAT_GOUT_BLK_HSI0_UID_XIU_D_HSI0_IPCLKPORT_ACLK , 21, CLK_IGNORE_UNUSED, 0), +GATE (CLK_GOUT_HSI0_LHS_ACEL_D_HSI0_CLK , + "gout_hsi0_lhs_acel_d_hsi0_clk", "mout_hsi0_bus_user", +CLK_CON_GAT_GOUT_BLK_HSI0_UID_LHS_ACEL_D_HSI0_IPCLKPORT_I_CLK , + 21, CLK_IS_CRITICAL, 0), };static const struct samsung_cmu_info hsi0_cmu_info__initconst = {
Signature · 1 line
2.50.1
PATCH v2 3/3 clk: samsung: exynos990: Add missing USB clock registers to HSI0
In reply to Denzeel OlivaThese registers are required for proper USB operation and were omitted in the initial clock controller setup.
--- drivers/clk/samsung/clk-exynos990.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/samsung/clk-exynos990.c +2 -0
@@ -1224,6 +1224,8 @@ static const unsigned long hsi0_clk_regs[] __initconst = {CLK_CON_GAT_GOUT_BLK_HSI0_UID_SYSMMU_USB_IPCLKPORT_CLK_S2 ,CLK_CON_GAT_GOUT_BLK_HSI0_UID_SYSREG_HSI0_IPCLKPORT_PCLK ,CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_ACLK_PHYCTRL , +CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_I_USB31DRD_REF_CLK_40 , +CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_I_USBDPPHY_REF_SOC_PLL ,CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_I_USBDPPHY_SCL_APB_PCLK ,CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_I_USBPCS_APB_CLK , CLK_CON_GAT_GOUT_BLK_HSI0_UID_USB31DRD_IPCLKPORT_BUS_CLK_EARLY,
Signature · 1 line
2.50.1
Krzysztof Kozlowski
AppliedQuoted 10 lines · Denzeel Oliva
Small fixes for Exynos990 HSI0 USB clocks:
Add missing
LHS_ACELclock ID and implementation, plus two missing USB clock registers. Without these, USB connections fail with errors like device descriptor read timeouts and address response issues.These changes ensure proper USB operation by adding critical missing clock definitions.
[...]
Applied, thanks!
[1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
https://git.kernel.org/krzk/linux/c/eb9bc162775cabfc4cf2b37cb0d3c2c2bf4c4b54 [2/3] clk: samsung: exynos990: Add LHS_ACEL gate clock for HSI0 and update CLK_NR_TOP https://git.kernel.org/krzk/linux/c/d0563d320b6014a8d56170253fe0aec524658b9f [3/3] clk: samsung: exynos990: Add missing USB clock registers to HSI0 https://git.kernel.org/krzk/linux/c/f00a5dc81744250e7a3f843adfe12d7883282c56
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>