Skip to contentSkip to conversation

python: Correct the upstream status in NODEV patch

PATCH Superseded Khem Raj 3 participants 4 messages Sep 2, 2025 – Sep 5, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 python: Correct the upstream status in NODEV patch

Ensure it is reflecting correct information and status of patch

---
 .../python/python3/test_posix_nodev_disable.patch           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch +5 -1
index 85767e1e898..df60302520e 100644
@@ -1,7 +1,11 @@
 Disable part of test_posix.test_makedev that depends on the NODEV
 macro being defined (missing on musl).
 
-Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
+See https://github.com/python/cpython/pull/31794 where NODEV
+handling is introduced.
+
+Upstream-Status: Inappropriate [Musl-Specific]
+
 Signed-off-by: Khem Raj <[email protected]>
 --- a/Lib/test/test_posix.py
 +++ b/Lib/test/test_posix.py
#1 lore raw
Quoted 16 lines · Khem Raj via lists.openembedded.org

Ensure it is reflecting correct information and status of patch

---
.../python/python3/test_posix_nodev_disable.patch | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)
meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch +0 -0
index 85767e1e898..df60302520e 100644
@@ -1,7 +1,11 @@

Disable part of test_posix.test_makedev that depends on the NODEV macro being defined (missing on musl).

meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch line 7

Quoted 5 lines
meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch +4 -1
-Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
+See https://github.com/python/cpython/pull/31794 where NODEV
+handling is introduced.
+
+Upstream-Status: Inappropriate [Musl-Specific]

Can you file at least a ticket for the issue that the tests don’t work on musl? (I see that alpine also has this patch)

Ross

author
#2 lore raw
Quoted 18 lines · Ross Burton
Quoted 16 lines · Khem Raj via lists.openembedded.org

Ensure it is reflecting correct information and status of patch

---
.../python/python3/test_posix_nodev_disable.patch | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)
meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch +0 -0
index 85767e1e898..df60302520e 100644
@@ -1,7 +1,11 @@

Disable part of test_posix.test_makedev that depends on the NODEV macro being defined (missing on musl).

Quoted 8 lines

meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch line 7

Quoted 5 lines
meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch +4 -1
-Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
+See https://github.com/python/cpython/pull/31794 where NODEV
+handling is introduced.
+
+Upstream-Status: Inappropriate [Musl-Specific]

Can you file at least a ticket for the issue that the tests don’t work on musl? (I see that alpine also has this patch)

right, I have already added to the issue which caused the problem, hopefully that is a better place to call it out.

https://github.com/python/cpython/pull/31794#discussion_r2314773987

Quoted 1 line

Ross