Skip to contentSkip to conversation

pinctrl: eswin: Fix regulator error check and Kconfig dependency

PATCH In review Yulin Lu 2 participants 2 messages Sep 3, 2025 – Sep 4, 2025

Subsystems (2)
lore
Share & tools
lore

Yulin Lu

author
#0 lore raw

PATCH v2 1/1 pinctrl: eswin: Fix regulator error check and Kconfig dependency

Smatch reported the following warning in eic7700_pinctrl_probe():

drivers/pinctrl/pinctrl-eic7700.c:638 eic7700_pinctrl_probe()
warn: passing zero to 'PTR_ERR'

The root cause is that devm_regulator_get() may return NULL when CONFIG_REGULATOR is disabled. In such case, IS_ERR_OR_NULL() triggers PTR_ERR(NULL) which evaluates to 0, leading to passing a success code as an error.

However, this driver cannot work without a regulator. To fix this:

- Change the check from IS_ERR_OR_NULL() to IS_ERR()
- Update Kconfig to explicitly select REGULATOR and REGULATOR_FIXED_VOLTAGE, ensuring that the regulator framework is always available.

This resolves the Smatch warning and enforces the correct dependency.

Fixes 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")

---
Changes in v2:
- Add Reported-by with Closes in the commit message.
- Link to v1:
https://lore.kernel.org/linux-gpio/[email protected]/

---
 drivers/pinctrl/Kconfig           | 2 ++
 drivers/pinctrl/pinctrl-eic7700.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/pinctrl/Kconfig +2 -0
index be1ca8e85754..0402626c4b98 100644
@@ -211,6 +211,8 @@ config PINCTRL_EIC7700
 	depends on ARCH_ESWIN || COMPILE_TEST
 	select PINMUX
 	select GENERIC_PINCONF
+	select REGULATOR
+	select REGULATOR_FIXED_VOLTAGE
 	help
 	  This driver support for the pin controller in ESWIN's EIC7700 SoC,
 	  which supports pin multiplexing, pin configuration,and rgmii voltage
drivers/pinctrl/pinctrl-eic7700.c +1 -1
index 4874b5532343..ffcd0ec5c2dc 100644
@@ -634,7 +634,7 @@ static int eic7700_pinctrl_probe(struct platform_device *pdev)
 		return PTR_ERR(pc->base);
 
 	regulator = devm_regulator_get(dev, "vrgmii");
-	if (IS_ERR_OR_NULL(regulator)) {
+	if (IS_ERR(regulator)) {
 		return dev_err_probe(dev, PTR_ERR(regulator),
 					 "failed to get vrgmii regulator\n");
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 17 lines · Yulin Lu

Smatch reported the following warning in eic7700_pinctrl_probe():

drivers/pinctrl/pinctrl-eic7700.c:638 eic7700_pinctrl_probe()
warn: passing zero to 'PTR_ERR'

The root cause is that devm_regulator_get() may return NULL when CONFIG_REGULATOR is disabled. In such case, IS_ERR_OR_NULL() triggers PTR_ERR(NULL) which evaluates to 0, leading to passing a success code as an error.

However, this driver cannot work without a regulator. To fix this:

- Change the check from IS_ERR_OR_NULL() to IS_ERR()
- Update Kconfig to explicitly select REGULATOR and REGULATOR_FIXED_VOLTAGE, ensuring that the regulator framework is always available.

Quoted 7 lines

This resolves the Smatch warning and enforces the correct dependency.

Fixes 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")

Patch applied!

Yours,
Linus Walleij