Add Meta (Facebook) Ventura BMC (AST2600)
Subsystems (2)
v11 cover Add Meta (Facebook) Ventura BMC (AST2600)
Add Linux device tree entry related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
---
v1:
1. Create ventura dts file.
2. Add commit msg.
3. Use format-patch to generate patch.
4. Add subject prefixes matching the subsystem.
---
v2:
1. Modify email content.
---
v3:
1. Add mail list.
---
v4:
1. Apply git send-email --thread option.
2. Sort nodes in the dts alphanumerically.
---
v5:
1. Run scripts/checkpatch.pl and fix reported warnings.
2. Remove unnecessary 88E6393X CONFIG FRU.
---
v6:
1. Add a new stage for the DTS change.
2. Run scripts/checkpatch.pl and fix reported error.
3. Fix the issue in a separate patch.
---
v7:
1. Fix broken indentation in the device tree file.
2. Sort nodes alphabetically, then by address if equal.
3. Rename fan sensor nodes from 'hwmon' to 'fan-controller'.
---
v8:
1. This patch series has significant changes compared to previous versions, and quite some time has passed since the last submission.Therefore, previously received Acked-by/Reviewed-by/Tested-by tags are not included in this version.
If needed, tags can be added again after review of thisnew version.
---
v9:
1. Reordered the node sequence under i2c5.
2. Added a description of the platform's intended use to the commit messages.
3. Added 3 GPIO expanders to i2c10 and defined the necessary GPIO line names.
---
v10:
1. Added IRQ support in GPIO expanders under i2c10 to handle edge-triggered events.
2. Reordered the nodes.
---
v11:
1. Modified the position for i2c3mux0ch6 and i2c3mux0ch7.
P.K. Lee (2):
dt-bindings: arm:aspeed add Meta Ventura board
ARM: dts: aspeed: ventura: add Meta Ventura BMC
.../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1578 +++++++++++++++++ 3 files changed, 1580 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
base-commit: 533cec246f7f0ccadd7d9fb4e664d38418633c6
branch: dev-6.6
Signature · 1 line
2.43.0
PATCH v11 1/2 dt-bindings: arm:aspeed add Meta Ventura board
Document the new compatibles used on Meta Ventura.
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -91,6 +91,7 @@ properties: - facebook,greatlakes-bmc - facebook,harma-bmc - facebook,minerva-cmc + - facebook,ventura-rmc - facebook,santabarbara-bmc - facebook,yosemite4-bmc - ibm,blueridge-bmc
Signature · 1 line
2.43.0
Re: [PATCH v11 1/2] dt-bindings: arm:aspeed add Meta Ventura board
Quoted 4 lines · P.K. Lee
Document the new compatibles used on Meta Ventura.
Signed-off-by P.K. Lee <[email protected]>
Your subject prefixes got corrupted.
Best regards,
Krzysztof
PATCH v11 2/2 ARM: dts: aspeed: ventura: add Meta Ventura BMC
In reply to P.K. LeeAdd Linux device tree related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
--- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1578 +++++++++++++++++ 2 files changed, 1579 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-santabarbara.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ + aspeed-bmc-facebook-ventura.dts \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ aspeed-bmc-facebook-wedge400-data64.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +1578 -0
1,578 lines not on this page · raw message
Signature · 1 line
2.43.0
Andrew Jeffery
maintainerRe: [PATCH v11 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
Quoted 32 lines · P.K. Lee
Add Linux device tree related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
Signed-off-by P.K. Lee <[email protected]>---
arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1578 +++++++++++++++++2 files changed, 1579 insertions(+)create mode 100644
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtsarch/arm/boot/dts/aspeed/Makefile +1
-0@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-santabarbara.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ + aspeed-bmc-facebook-ventura.dts \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ aspeed-bmc-facebook-wedge400-data64.dtb \arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +0
-0@@ -0,0 +1,1578 @@
*snip*
What follows are the usual references modifying nodes from the DTSI. Recently I've started asking that we order _these_ alphabetically, as it makes it much easier for me to tell if they're following some consistent order (as the unit address is not present).
I realise you've done a bunch of reordering to this point already, please excuse this (hopefully) final request.
However, I also have some further requests below.
Quoted 45 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +45
-0+ +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-128.dtsi" + }; + flash@1 { + status = "okay"; + m25p,fast-read; + label = "alt-bmc"; + spi-max-frequency = <50000000>; + }; +}; + +&mdio0 { + status = "okay"; +}; + +&mac3 { + status = "okay"; + phy-mode = "rmii"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + fixed-link { + speed = <100>; + full-duplex; + }; +}; + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; +
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 715
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +10
-0+&adc0 { + vref-supply = <&p1v8_bmc_aux>; + status = "okay"; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +};
*snip*
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1127
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +9
-0+ +&i2c3 { + status = "okay"; + + i2c-mux@77 { + compatible = "nxp,pca9548"; + reg = <0x77>; + #address-cells = <1>; + #size-cells = <0>;
*snip*
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1236
Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +8
-0+ + i2c3mux0ch5: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + + pwm@20 { + compatible = "max31790";
This causes the following warning:
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtb: /ahb/apb/bus@1e78a000/i2c@200/i2c-mux@77/i2c@5/pwm@20: failed to match any schema with compatible: ['max31790']
The valid compatible string is "maxim,max31790". Please update it.
*snip*
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1431
Quoted 5 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +4
-0+ +&i2c10 { + status = "okay"; +
*snip*
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1519
Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +3
-0+ + power-monitor@69 { + compatible = "pmbus";
Please drop this node, it causes the following warning:
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtb: /ahb/apb/bus@1e78a000/i2c@580/power-monitor@69: failed to match any schema with compatible: ['pmbus']
Cheers,
Andrew
Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +4
-0+ reg = <0x69>; + }; +}; +