selftests/bpf: Introduce experimental bpf_in_interrupt()
Subsystems (3)
v3 cover selftests/bpf: Introduce experimental bpf_in_interrupt()
Filtering pid_tgid is meanlingless when the current task is preempted by an interrupt.
To address this, introduce 'bpf_in_interrupt()' helper function, which allows BPF programs to determine whether they are executing in interrupt context.
'get_preempt_count()':
* On x86, '*(int *) bpf_this_cpu_ptr(&__preempt_count)'.
* On arm64, 'bpf_get_current_task_btf()->thread_info.preempt.count'.
Then 'bpf_in_interrupt()' will be:
* If !PREEMPT_RT, 'get_preempt_count() & (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_MASK)'.
* If PREEMPT_RT, '(get_preempt_count() & (NMI_MASK | HARDIRQ_MASK)) | (bpf_get_current_task_btf()->softirq_disable_cnt & SOFTIRQ_MASK)'.
'bpf_in_interrupt()' runs well when PREEMPT_RT is enabled. But it's difficult for me to test it well because I'm not familiar with PREEMPT_RT.
Changes:
v2 -> v3:
* Address comments from Alexei:
* Move bpf_in_interrupt() to bpf_experimental.h.
* Add support for arm64.
v2: https://lore.kernel.org/bpf/[email protected]/
v1 -> v2:
* Fix a build error reported by test bot.
Leon Hwang (2):
selftests/bpf: Introduce experimental bpf_in_interrupt() selftests/bpf: Add case to test bpf_in_interrupt()
.../testing/selftests/bpf/bpf_experimental.h | 54 +++++++++++++++++++ .../testing/selftests/bpf/prog_tests/timer.c | 30 +++++++++++ .../selftests/bpf/progs/timer_interrupt.c | 48 +++++++++++++++++ 3 files changed, 132 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/timer_interrupt.c
--
2.51.0
PATCH v3 1/2 selftests/bpf: Introduce experimental bpf_in_interrupt()
Filtering pid_tgid is meanlingless when the current task is preempted by an interrupt.
To address this, introduce 'bpf_in_interrupt()' helper function, which allows BPF programs to determine whether they are executing in interrupt context.
'get_preempt_count()':
* On x86, '*(int *) bpf_this_cpu_ptr(&__preempt_count)'.
* On arm64, 'bpf_get_current_task_btf()->thread_info.preempt.count'.
Then 'bpf_in_interrupt()' will be:
* If !PREEMPT_RT, 'get_preempt_count() & (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_MASK)'.
* If PREEMPT_RT, '(get_preempt_count() & (NMI_MASK | HARDIRQ_MASK)) | (bpf_get_current_task_btf()->softirq_disable_cnt & SOFTIRQ_MASK)'.
As for other archs, it can be added support by updating 'get_preempt_count()'.
--- .../testing/selftests/bpf/bpf_experimental.h | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+)
tools/testing/selftests/bpf/bpf_experimental.h +54 -0
@@ -599,4 +599,58 @@ extern void bpf_iter_dmabuf_destroy(struct bpf_iter_dmabuf *it) __weak __ksym; extern int bpf_cgroup_read_xattr(struct cgroup *cgroup, const char *name__str, struct bpf_dynptr *value_p) __weak __ksym; +#define PREEMPT_BITS 8 +#define SOFTIRQ_BITS 8 +#define HARDIRQ_BITS 4 +#define NMI_BITS 4 + +#define PREEMPT_SHIFT 0 +#define SOFTIRQ_SHIFT (PREEMPT_SHIFT + PREEMPT_BITS) +#define HARDIRQ_SHIFT (SOFTIRQ_SHIFT + SOFTIRQ_BITS) +#define NMI_SHIFT (HARDIRQ_SHIFT + HARDIRQ_BITS) + +#define __IRQ_MASK (x) ((1UL << (x))-1) + +#define SOFTIRQ_MASK (__IRQ_MASK(SOFTIRQ_BITS) << SOFTIRQ_SHIFT) +#define HARDIRQ_MASK (__IRQ_MASK(HARDIRQ_BITS) << HARDIRQ_SHIFT) +#define NMI_MASK (__IRQ_MASK(NMI_BITS) << NMI_SHIFT) + +extern bool CONFIG_PREEMPT_RT __kconfig __weak; +#ifdef bpf_target_x86 +extern const int __preempt_count __ksym; +#endif + +struct task_struct___preempt_rt { +int softirq_disable_cnt; +} __attribute__((preserve_access_index)); + +static inline int get_preempt_count (void ) +{ +#if defined(bpf_target_x86) +return *(int *)bpf_this_cpu_ptr (&__preempt_count); +#elif defined(bpf_target_arm64) +return bpf_get_current_task_btf ()->thread_info.preempt.count; +#endif +return 0 ; +} + +/* Description +* Report whether it is in interrupt context. Only works on the following archs: +* * x86 +* * arm64 +*/ +static inline int bpf_in_interrupt (void ) +{ +struct task_struct___preempt_rt *tsk; +int pcnt; + + pcnt =get_preempt_count (); +if (!CONFIG_PREEMPT_RT ) +return pcnt & (NMI_MASK |HARDIRQ_MASK |SOFTIRQ_MASK ); + + tsk = (void *)bpf_get_current_task_btf (); +return (pcnt & (NMI_MASK |HARDIRQ_MASK )) | + (tsk->softirq_disable_cnt &SOFTIRQ_MASK ); +} +#endif
--
2.51.0
PATCH v3 2/2 selftests/bpf: Add case to test bpf_in_interrupt()
In reply to Leon HwangAdd a timer test case to test 'bpf_in_interrupt()'.
cd tools/testing/selftests/bpf
./test_progs -t timer_interrupt
462 timer_interrupt:OK
Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
--- .../testing/selftests/bpf/prog_tests/timer.c | 30 ++++++++++++ .../selftests/bpf/progs/timer_interrupt.c | 48 +++++++++++++++++++ 2 files changed, 78 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/timer_interrupt.c
tools/testing/selftests/bpf/prog_tests/timer.c +30 -0
@@ -3,6 +3,7 @@#include <test_progs.h> #include "timer.skel.h" #include "timer_failure.skel.h" +#include "timer_interrupt.skel.h" #define NUM_THR 8
@@ -95,3 +96,32 @@ void serial_test_timer(void)RUN_TESTS (timer_failure); } + +void test_timer_interrupt (void ) +{ +struct timer_interrupt *skel =NULL ; +int err, prog_fd; +LIBBPF_OPTS (bpf_test_run_opts, opts); + + skel =timer_interrupt__open_and_load (); +if (!ASSERT_OK_PTR (skel,"timer_interrupt__open_and_load" )) +return ; + + err =timer_interrupt__attach (skel); +if (!ASSERT_OK (err,"timer_interrupt__attach" )) + goto out; + + prog_fd =bpf_program__fd (skel->progs.test_timer_interrupt); + err =bpf_prog_test_run_opts (prog_fd, &opts); +if (!ASSERT_OK (err,"bpf_prog_test_run_opts" )) + goto out; + +usleep (50 ); + +ASSERT_EQ (skel->bss->in_interrupt,0 ,"in_interrupt" ); +if (skel->bss->preempt_count) +ASSERT_NEQ (skel->bss->in_interrupt_cb,0 ,"in_interrupt_cb" ); + +out: +timer_interrupt__destroy (skel); +}
tools/testing/selftests/bpf/progs/timer_interrupt.c new file +48 -0
48 lines not on this page · raw message
--
2.51.0