io_uring: Replace kzalloc() + copy_from_user() with memdup_user()
PATCH 1/1 io_uring: Replace kzalloc() + copy_from_user() with memdup_user()
Replace kzalloc() followed by copy_from_user() with memdup_user() to improve and simplify io_probe().
No functional changes intended.
Signed-off-by Thorsten Blum <[email protected]>
--- io_uring/register.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
io_uring/register.c +3 -7
@@ -46,13 +46,9 @@ static __cold int io_probe(struct io_ring_ctx *ctx, void __user *arg, nr_args =IORING_OP_LAST ; size =struct_size (p, ops, nr_args); - p =kzalloc (size,GFP_KERNEL ); -if (!p) -return -ENOMEM ; - - ret = -EFAULT ; -if (copy_from_user (p, arg, size)) - goto out; + p =memdup_user (arg, size); +if (IS_ERR (p)) +return PTR_ERR (p); ret = -EINVAL ;if (memchr_inv (p,0 , size)) goto out;
Signature · 1 line
2.51.0
Quoted 6 lines · Thorsten Blum
Replace
kzalloc()followed bycopy_from_user()withmemdup_user()to improve and simplifyio_probe().No functional changes intended.
Applied, thanks!
[1/1] io_uring: Replace kzalloc() + copy_from_user() with memdup_user()
commit: 7b0604d77a41192316347618cce1d9c795613adb
Best regards,
Signature · 1 line
Jens Axboe