mm/shmem: remove unused entry_order after large swapin rework
Subsystems (2)
PATCH v2 1/1 mm/shmem: remove unused entry_order after large swapin rework
From: Jackie Liu <[email protected]>
After commit 93c0476e7057 ("mm/shmem, swap: rework swap entry and index calculation for large swapin"), xas_get_order() will never return a non-zero value for entry_order in shmem_split_large_entry(). As a result, the local variable entry_order is effectively unused.
Clean up the code by removing entry_order and directly using cur_order. This change is purely a refactor and has no functional impact.
No functional change intended.
Reviewed-by Baolin Wang <[email protected]>
Signed-off-by Jackie Liu <[email protected]>
--- mm/shmem.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
mm/shmem.c +4 -7
@@ -2235,7 +2235,7 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, {struct address_space *mapping = inode->i_mapping;XA_STATE_ORDER (xas, &mapping->i_pages, index,0 ); -int split_order =0 , entry_order; +int split_order =0 ;int i;/* Convert user data gfp flags to xarray node gfp flags */
@@ -2253,15 +2253,12 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, goto unlock; } - entry_order =xas_get_order (&xas); - -if (!entry_order) + cur_order =xas_get_order (&xas); +if (!cur_order) goto unlock;/* Try to split large swap entry in pagecache */ - cur_order = entry_order; - swap_index =round_down (index,1 << entry_order); - + swap_index =round_down (index,1 << cur_order); split_order =xas_try_split_min_order (cur_order);while (cur_order >0 ) {
Signature · 1 line
2.51.0