drm/tiny/bochs: Convert dev_err() to drm_err()
Subsystems (4)
PATCH 1/1 drm/tiny/bochs: Convert dev_err() to drm_err()
The DRM subsystem has a set of preferred, prefixed logging functions (drm_info, drm_warn, drm_err) which improve debuggability by including the driver and function name in the log output.
As part of the ongoing effort to modernize logging calls, convert a dev_err() call in the bochs hardware initialization function to its drm_err() equivalent.
This work was suggested by the DRM TODO list.
--- drivers/gpu/drm/tiny/bochs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tiny/bochs.c +1 -1
@@ -252,7 +252,7 @@ static int bochs_hw_init(struct bochs_device *bochs) } bochs->ioports =1 ; }else { -dev_err (dev->dev,"I/O ports are not supported\n" ); +drm_err (dev,"I/O ports are not supported\n" );return -EIO ; }
Signature · 1 line
2.43.0
Gentle ping on this patch.
Is this change still of interest? I'm happy to make any changes or rebase if needed.
Thanks,
Leander Kieweg
Hi
Am 18.08.25 um 13:35 schrieb Leander Kieweg:
Quoted 11 lines
The DRM subsystem has a set of preferred, prefixed logging functions (
drm_info,drm_warn,drm_err) which improve debuggability by including the driver and function name in the log output.As part of the ongoing effort to modernize logging calls, convert a
dev_err()call in the bochs hardware initialization function to itsdrm_err()equivalent.This work was suggested by the DRM TODO list.
Signed-off-by Leander Kieweg <[email protected]>
I'll soon add the patch to our tree.
Best regards
Thomas
Quoted 17 lines
--- drivers/gpu/drm/tiny/bochs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/tiny/bochs.c +1
-1@@ -252,7 +252,7 @@ static int bochs_hw_init(struct bochs_device *bochs) } bochs->ioports =1 ; }else { -dev_err (dev->dev,"I/O ports are not supported\n" ); +drm_err (dev,"I/O ports are not supported\n" );return -EIO ; }
Signature · 7 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)