Skip to contentSkip to conversation

selftests/kvm: remove stale TODO in xapic_state_test

PATCH In review Sukrut Heroorkar 2 participants 2 messages Sep 8, 2025 – Sep 24, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/kvm: remove stale TODO in xapic_state_test

The TODO about using the number of vCPUs instead of vcpu.id + 1 was already addressed by commit 376bc1b458c9 ("KVM: selftests: Don't assume vcpu->id is '0' in xAPIC state test"). The comment is now stale and can be removed.

---
 tools/testing/selftests/kvm/x86/xapic_state_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/kvm/x86/xapic_state_test.c +2 -2
index fdebff1165c7..3b4814c55722 100644
@@ -120,8 +120,8 @@ static void test_icr(struct xapic_vcpu *x)
 		__test_icr(x, icr | i);
 
 	/*
-	 * Send all flavors of IPIs to non-existent vCPUs.  TODO: use number of
-	 * vCPUs, not vcpu.id + 1.  Arbitrarily use vector 0xff.
+	 * Send all flavors of IPIs to non-existent vCPUs. Arbitrarily use
+	 * vector 0xff.
 	 */
 	icr = APIC_INT_ASSERT | 0xff;
 	for (i = 0; i < 0xff; i++) {
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · Sukrut Heroorkar

The TODO about using the number of vCPUs instead of vcpu.id + 1 was already addressed by commit 376bc1b458c9 ("KVM: selftests: Don't assume vcpu->id is '0' in xAPIC state test"). The comment is now stale and can be removed.

Applied to kvm-x86 selftests, thanks!

[1/1] selftests/kvm: remove stale TODO in xapic_state_test

      https://github.com/kvm-x86/linux/commit/ff86b48d4ce3

--
https://github.com/kvm-x86/linux/tree/next