dt-bindings: lcdif: Document a imx6sx-lcdif fallback
Subsystems (5)
Fabio Estevam
reviewerPATCH RESEND v4 1/3 dt-bindings: lcdif: Document a imx6sx-lcdif fallback
imx6sx.dtsi has the following lcdif entries:
compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
This causes the following dt-schema warning:
['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long
To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible 'fsl,imx6sx-lcdif' fallback.
--- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +5 -2
@@ -19,7 +19,6 @@ properties: - enum: - fsl,imx23-lcdif - fsl,imx28-lcdif - - fsl,imx6sx-lcdif - fsl,imx8mp-lcdif - fsl,imx93-lcdif - items:
@@ -32,6 +31,10 @@ properties: - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif reg: maxItems: 1
@@ -199,7 +202,7 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> display-controller@2220000 { - compatible = "fsl,imx6sx-lcdif"; + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; reg = <0x02220000 0x4000>; interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH RESEND v4 2/3 dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries:
compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback.
['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
The imx6sx-lcdif programming model has more advanced features, such as overlay plane and the CRC32 support than the imx28-lcdif IP.
Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific fsl,imx28-lcdif fallback:
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
This helps keeping DT compatibility as well as using the more advanced lcdif features found on imx6sl and imx6sll.
--- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6 -2
@@ -23,14 +23,18 @@ properties: - fsl,imx93-lcdif - items: - enum: - - fsl,imx6sl-lcdif - - fsl,imx6sll-lcdif - fsl,imx6ul-lcdif - fsl,imx7d-lcdif - fsl,imx8mm-lcdif - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sl-lcdif + - fsl,imx6sll-lcdif + - const: fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif - items: - enum: - fsl,imx6sx-lcdif
Signature · 1 line
2.34.1
Frank Li
maintainerRe: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
Quoted 10 lines · Fabio Estevam
mx6sl.dtsiandimx6sll.dtsihave the following lcdif entries:compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback.
['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
Quoted 7 lines
The imx6sx-lcdif programming model has more advanced features, such as overlay plane and the CRC32 support than the imx28-lcdif IP.
Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific fsl,imx28-lcdif fallback:
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
Anyway, you change dts. If you change dts as
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
needn't update binding here.
Frank
Quoted 39 lines
This helps keeping DT compatibility as well as using the more advanced lcdif features found on imx6sl and imx6sll.
Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Ahmad Fatoum <[email protected]>--- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6
-3@@ -23,14 +23,18 @@ properties: - fsl,imx93-lcdif - items: - enum: - - fsl,imx6sl-lcdif - - fsl,imx6sll-lcdif - fsl,imx6ul-lcdif - fsl,imx7d-lcdif - fsl,imx8mm-lcdif - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sl-lcdif + - fsl,imx6sll-lcdif + - const: fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif - items: - enum: - fsl,imx6sx-lcdif --2.34.1
Fabio Estevam
reviewerRe: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
Quoted 7 lines · Frank Li
Quoted 1 line
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
Anyway, you change dts. If you change dts as
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
needn't update binding here.
This was discussed in previous iterations.
The change you propose may cause regressions for other device tree consumers, such as bootloaders, where the match may occur only aganst "fsl,imx28-lcdif".
That's why "fsl,imx28-lcdif" fallback needs to stay.
Re: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
Quoted 10 lines · Fabio Estevam
Quoted 7 lines · Frank Li
Quoted 1 line
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
Anyway, you change dts. If you change dts as
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
needn't update binding here.
Quoted 7 lines
This was discussed in previous iterations.
The change you propose may cause regressions for other device tree consumers, such as bootloaders, where the match may occur only aganst "fsl,imx28-lcdif".
That's why "fsl,imx28-lcdif" fallback needs to stay.
Okay
Fabio Estevam
reviewerPATCH RESEND v4 3/3 ARM: dts: imx6sl: Provide a more specific lcdif compatible
In reply to Fabio EstevamThe LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX.
Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility.
--- arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++- arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/boot/dts/nxp/imx/imx6sl.dtsi +2 -1
@@ -776,7 +776,8 @@ epdc: epdc@20f4000 { }; lcdif: lcdif@20f8000 { - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
arch/arm/boot/dts/nxp/imx/imx6sll.dtsi +2 -1
@@ -657,7 +657,8 @@ pxp: pxp@20f0000 { }; lcdif: lcd-controller@20f8000 { - compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
Signature · 1 line
2.34.1
Re: [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible
Quoted 7 lines · Fabio Estevam
The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX.
Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility.
Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Ahmad Fatoum <[email protected]>
Quoted 36 lines
--- arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++- arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)arch/arm/boot/dts/nxp/imx/imx6sl.dtsi +2
-1@@ -776,7 +776,8 @@ epdc: epdc@20f4000 { }; lcdif: lcdif@20f8000 { - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,arch/arm/boot/dts/nxp/imx/imx6sll.dtsi +2
-2@@ -657,7 +657,8 @@ pxp: pxp@20f0000 { }; lcdif: lcd-controller@20f8000 { - compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>, --2.34.1