Skip to contentSkip to conversation

selftests: Disable dad for ipv6 in fcnal-test.sh

PATCH Applied David Ahern 3 participants 5 messages Sep 10, 2025 – Sep 12, 2025

Subsystems (3)
Networking Network drivers Kselftest
lore
Share & tools
lore

David Ahern

author
#0 lore raw

PATCH 1/2 selftests: Disable dad for ipv6 in fcnal-test.sh

Constrained test environment; duplicate address detection is not needed and causes races so disable it.

Signed-off-by David Ahern <[email protected]>
---
 tools/testing/selftests/net/fcnal-test.sh | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/net/fcnal-test.sh +2 -0
index 69941520e8e5..068379a79651 100755
@@ -424,6 +424,8 @@ create_ns()
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.forwarding=1
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.default.forwarding=1
+	ip netns exec ${ns} sysctl -qw net.ipv6.conf.default.accept_dad=0
+	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.accept_dad=0
 }
 
 # create veth pair to connect namespaces and apply addresses.
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 2/2 selftests: Replace sleep with slowwait

Replace the sleep in kill_procs with slowwait.

Signed-off-by David Ahern <[email protected]>
---
 tools/testing/selftests/net/fcnal-test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/fcnal-test.sh +1 -1
index 068379a79651..a527e3556763 100755
@@ -189,7 +189,7 @@ show_hint()
 kill_procs()
 {
 	killall nettest ping ping6 >/dev/null 2>&1
-	sleep 1
+	slowwait 2 sh -c 'test -z "$(pgrep '"'^(nettest|ping|ping6)$'"')"'
 }
 
 set_ping_group()
Signature · 1 line
2.43.0
CI Applied
#4 lore raw
In reply to David Ahern
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Tue, 9 Sep 2025 20:58:27 -0600 you wrote:

Constrained test environment; duplicate address detection is not needed and causes races so disable it.

Signed-off-by David Ahern <[email protected]>
---
 tools/testing/selftests/net/fcnal-test.sh | 2 ++
 1 file changed, 2 insertions(+)

Here is the summary with links:
- [net-next,1/2] selftests: Disable dad for ipv6 in fcnal-test.sh

    https://git.kernel.org/netdev/net-next/c/53d591730ea3
  - [net-next,2/2] selftests: Replace sleep with slowwait
    https://git.kernel.org/netdev/net-next/c/2f186dd5585c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html