ACPI: SPCR: Support Precise Baud Rate filed
PATCH 1/1 ACPI: SPCR: Support Precise Baud Rate filed
From: Chen Pei <[email protected]>
The Microsoft Serial Port Console Redirection (SPCR) specification revision 1.09 comprises additional field: Precise Baud Rate [1].
It is used to describe non-traditional baud rates (such as those used by high-speed UARTs).
It contains a specific non-zero baud rate which overrides the value of the Configured Baud Rate field. If this field is zero or not present, Configured Baud Rate is used.
--- drivers/acpi/spcr.c | 56 ++++++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 23 deletions(-)
drivers/acpi/spcr.c +33 -23
@@ -146,29 +146,39 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) goto done; } -switch (table->baud_rate) { -case 0 : -/* -* SPCR 1.04 defines 0 as a preconfigured state of UART. -* Assume firmware or bootloader configures console correctly. -*/ - baud_rate =0 ; -break ; -case 3 : - baud_rate =9600 ; -break ; -case 4 : - baud_rate =19200 ; -break ; -case 6 : - baud_rate =57600 ; -break ; -case 7 : - baud_rate =115200 ; -break ; -default : - err = -ENOENT ; - goto done; +/* +* SPCR 1.09 defines Precise Baud Rate Filed contains a specific +* non-zero baud rate which overrides the value of the Configured +* Baud Rate field. If this field is zero or not present, Configured +* Baud Rate is used. +*/ +if (table->precise_baudrate) + baud_rate = table->precise_baudrate; +else { +switch (table->baud_rate) { +case 0 : +/* +* SPCR 1.04 defines 0 as a preconfigured state of UART. +* Assume firmware or bootloader configures console correctly. +*/ + baud_rate =0 ; +break ; +case 3 : + baud_rate =9600 ; +break ; +case 4 : + baud_rate =19200 ; +break ; +case 6 : + baud_rate =57600 ; +break ; +case 7 : + baud_rate =115200 ; +break ; +default : + err = -ENOENT ; + goto done; + } }/*
Signature · 1 line
2.49.0
Rafael J. Wysocki
maintainerQuoted 50 lines · On Fri, Sep 12, 2025 at 10:58 AM <[email protected]> wrote:
From: Chen Pei <[email protected]>
The Microsoft Serial Port Console Redirection (SPCR) specification revision 1.09 comprises additional field: Precise Baud Rate [1].
It is used to describe non-traditional baud rates (such as those used by high-speed UARTs).
It contains a specific non-zero baud rate which overrides the value of the Configured Baud Rate field. If this field is zero or not present, Configured Baud Rate is used.
Signed-off-by Chen Pei <[email protected]>--- drivers/acpi/spcr.c | 56 ++++++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 23 deletions(-)drivers/acpi/spcr.c +0
-22@@ -146,29 +146,39 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) goto done; } -switch (table->baud_rate) { -case 0 : -/* -* SPCR 1.04 defines 0 as a preconfigured state of UART. -* Assume firmware or bootloader configures console correctly. -*/ - baud_rate =0 ; -break ; -case 3 : - baud_rate =9600 ; -break ; -case 4 : - baud_rate =19200 ; -break ; -case 6 : - baud_rate =57600 ; -break ; -case 7 : - baud_rate =115200 ; -break ; -default : - err = -ENOENT ;
drivers/acpi/spcr.c int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) · line 157
Quoted 10 lines
drivers/acpi/spcr.c +9
-1- goto done; +/* +* SPCR 1.09 defines Precise Baud Rate Filed contains a specific +* non-zero baud rate which overrides the value of the Configured +* Baud Rate field. If this field is zero or not present, Configured +* Baud Rate is used. +*/ +if (table->precise_baudrate) + baud_rate = table->precise_baudrate; +else {
The outer braces here are redundant and if you combined the "else" above with the "switch ()" statement below in one line, the patch would be smaller.
Quoted 28 lines
drivers/acpi/spcr.c +24
-1+switch (table->baud_rate) { +case 0 : +/* +* SPCR 1.04 defines 0 as a preconfigured state of UART. +* Assume firmware or bootloader configures console correctly. +*/ + baud_rate =0 ; +break ; +case 3 : + baud_rate =9600 ; +break ; +case 4 : + baud_rate =19200 ; +break ; +case 6 : + baud_rate =57600 ; +break ; +case 7 : + baud_rate =115200 ; +break ; +default : + err = -ENOENT ; + goto done; + } }/* --
Quoted 10 lines · On Fri, 12 Sep 2025 11:29:44 +0200, [email protected] wrote:
Review
Quoted 3 lines
(quoted diff) +3
-0+ if (table->precise_baudrate) + baud_rate =3D table->precise_baudrate; + else {>The outer braces here are redundant and if you combined the "else" above with the "switch ()" statement below in one line, the patch would be smaller.>
Quoted 2 lines
drivers/acpi/spcr.c +2
-0+switch (table->baud_rate) { +case 0 :
Thanks for your suggestion. I will modify it.