Skip to contentSkip to conversation

media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

PATCH Superseded Pavan Bobba 2 participants 3 messages Sep 12, 2025 – Sep 13, 2025 Media (V4L/DVB)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: v4l2-ctrls: add full AV1 profile validation in validate_av1_sequence()

The AV1 stateless decoder API provides the control V4L2_CID_STATELESS_AV1_SEQUENCE to pass sequence header parameters from userspace. The current validator only checked that seq_profile ≤ 2 and that monochrome was not signaled in profile 1.

This patch completes the "TODO: PROFILES" by enforcing all profile-specific constraints as defined by the AV1 specification (Section 5.5.2, "Color config syntax"):

- Profile 0: 8/10-bit only, 4:2:0 subsampling, no monochrome
- Profile 1: 8/10-bit only, 4:4:4 only, no monochrome
- Profile 2: 8/10/12-bit, 4:2:0 / 4:2:2 / 4:4:4 allowed, monochrome allowed

Additionally, when the MONO_CHROME flag is set:
- subsampling_x and subsampling_y must both be 1
- separate_uv_delta_q must be 0

These checks prevent userspace from providing invalid AV1 sequence headers that would otherwise be accepted, leading to undefined driver or hardware behavior.

---
 drivers/media/v4l2-core/v4l2-ctrls-core.c | 54 +++++++++++++++++++++--
 1 file changed, 50 insertions(+), 4 deletions(-)
drivers/media/v4l2-core/v4l2-ctrls-core.c +50 -4
index 98b960775e87..3283ed04cc36 100644
@@ -852,14 +852,60 @@ static int validate_av1_sequence(struct v4l2_ctrl_av1_sequence *s)
 	 V4L2_AV1_SEQUENCE_FLAG_SEPARATE_UV_DELTA_Q))
 		return -EINVAL;
 
-	if (s->seq_profile == 1 && s->flags & V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME)
-		return -EINVAL;
-
 	/* reserved */
 	if (s->seq_profile > 2)
 		return -EINVAL;
 
-	/* TODO: PROFILES */
+	/* Profile-specific checks */
+	switch (s->seq_profile) {
+	case 0:
+		/* Bit depth: 8 or 10 */
+		if (s->bit_depth != 8 && s->bit_depth != 10)
+			return -EINVAL;
+
+		/* Subsampling must be 4:2:0 → x=1, y=1 */
+		if (!(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    !(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+		break;
+
+	case 1:
+		/* Monochrome is forbidden in profile 1 */
+		if (s->flags & V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME)
+			return -EINVAL;
+
+		/* Bit depth: 8 or 10 */
+		if (s->bit_depth != 8 && s->bit_depth != 10)
+			return -EINVAL;
+
+		/* Subsampling must be 4:4:4 → x=0, y=0 */
+		if ((s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    (s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+		break;
+
+	case 2:
+		/* Bit depth: 8, 10, or 12 */
+		if (s->bit_depth != 8 && s->bit_depth != 10 &&
+		    s->bit_depth != 12)
+			return -EINVAL;
+
+		/* Subsampling: 4:2:0, 4:2:2, or 4:4:4 allowed → no extra check */
+		break;
+	}
+
+	/* If monochrome flag is set, enforce spec rules */
+	if (s->flags & V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME) {
+		/* Must signal subsampling_x=1, subsampling_y=1 */
+		if (!(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    !(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+
+		/* separate_uv_delta_q must be 0 in monochrome */
+		if (s->flags & V4L2_AV1_SEQUENCE_FLAG_SEPARATE_UV_DELTA_Q)
+			return -EINVAL;
+	}
+
 	return 0;
 }
 
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Le vendredi 12 septembre 2025 à 18:44 +0530, Pavan Bobba a écrit :

Quoted 17 lines

The AV1 stateless decoder API provides the control V4L2_CID_STATELESS_AV1_SEQUENCE to pass sequence header parameters from userspace. The current validator only checked that seq_profile ≤ 2 and that monochrome was not signaled in profile 1.

This patch completes the "TODO: PROFILES" by enforcing all profile-specific constraints as defined by the AV1 specification (Section 5.5.2, "Color config syntax"):

- Profile 0: 8/10-bit only, 4:2:0 subsampling, no monochrome
- Profile 1: 8/10-bit only, 4:4:4 only, no monochrome
- Profile 2: 8/10/12-bit, 4:2:0 / 4:2:2 / 4:4:4 allowed, monochrome allowed

Additionally, when the MONO_CHROME flag is set:
- subsampling_x and subsampling_y must both be 1
- separate_uv_delta_q must be 0

Quoted 5 lines

These checks prevent userspace from providing invalid AV1 sequence headers that would otherwise be accepted, leading to undefined driver or hardware behavior.

The changes looks good and seems safer. I will have to run some tests to make sure we don't regress anything. About your commit message, there is a push to make things more imperative, so that would mean reformatting to the following and dropping the first paragraph:

Complete the "TODO: PROFILES" by enforcing all profile-specific constraints as defined by the AV1 specification (Section 5.5.2, "Color config syntax"):

- Profile 0: 8/10-bit only, 4:2:0 subsampling, no monochrome
- Profile 1: 8/10-bit only, 4:4:4 only, no monochrome
- Profile 2: 8/10/12-bit, 4:2:0 / 4:2:2 / 4:4:4 allowed, monochrome allowed

Additionally, when the MONO_CHROME flag is set:
- subsampling_x and subsampling_y must both be 1
- separate_uv_delta_q must be 0

These checks prevent userspace from providing invalid AV1 sequence headers that would otherwise be accepted, leading to undefined driver or hardware behavior.

If you are fine with this change I can apply. Otherwise please include my Rb in your v2.

regards,
Nicolas

Quoted 77 lines

---
 drivers/media/v4l2-core/v4l2-ctrls-core.c | 54 +++++++++++++++++++++--

 1 file changed, 50 insertions(+), 4 deletions(-)
drivers/media/v4l2- renamed from drivers/media/v4l2-core/v4l2-ctrls-core.c +0 -0

core/v4l2-ctrls-core.c
index 98b960775e87..3283ed04cc36 100644

drivers/media/v4l2-core/v4l2-ctrls-core.c +0 -0
@@ -852,14 +852,60 @@ static int validate_av1_sequence(struct
 v4l2_ctrl_av1_sequence *s)
  	 V4L2_AV1_SEQUENCE_FLAG_SEPARATE_UV_DELTA_Q))
  		return -EINVAL;

drivers/media/v4l2-core/v4l2-ctrls-core.c +0 -1
-	if (s->seq_profile == 1 && s->flags &

V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME)

drivers/media/v4l2-core/v4l2-ctrls-core.c +0 -2
-		return -EINVAL;
-

  /* reserved */
  if (s->seq_profile > 2)
  return -EINVAL;

drivers/media/v4l2-core/v4l2-ctrls-core.c +35 -1
-	/* TODO: PROFILES */
+	/* Profile-specific checks */
+	switch (s->seq_profile) {
+	case 0:
+		/* Bit depth: 8 or 10 */
+		if (s->bit_depth != 8 && s->bit_depth != 10)
+			return -EINVAL;
+
+		/* Subsampling must be 4:2:0 → x=1, y=1 */
+		if (!(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    !(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+		break;
+
+	case 1:
+		/* Monochrome is forbidden in profile 1 */
+		if (s->flags & V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME)
+			return -EINVAL;
+
+		/* Bit depth: 8 or 10 */
+		if (s->bit_depth != 8 && s->bit_depth != 10)
+			return -EINVAL;
+
+		/* Subsampling must be 4:4:4 → x=0, y=0 */
+		if ((s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    (s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+		break;
+
+	case 2:
+		/* Bit depth: 8, 10, or 12 */
+		if (s->bit_depth != 8 && s->bit_depth != 10 &&
+		    s->bit_depth != 12)
+			return -EINVAL;
+
+		/* Subsampling: 4:2:0, 4:2:2, or 4:4:4 allowed → no extra

check */

drivers/media/v4l2-core/v4l2-ctrls-core.c +15 -0
+		break;
+	}
+
+	/* If monochrome flag is set, enforce spec rules */
+	if (s->flags & V4L2_AV1_SEQUENCE_FLAG_MONO_CHROME) {
+		/* Must signal subsampling_x=1, subsampling_y=1 */
+		if (!(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X) ||
+		    !(s->flags & V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y))
+			return -EINVAL;
+
+		/* separate_uv_delta_q must be 0 in monochrome */
+		if (s->flags & V4L2_AV1_SEQUENCE_FLAG_SEPARATE_UV_DELTA_Q)
+			return -EINVAL;
+	}
+

  return 0;
 }

#2 lore raw
Quoted 16 lines · Nicolas Dufresne

The changes looks good and seems safer. I will have to run some tests to make sure we don't regress anything. About your commit message, there is a push to make things more imperative, so that would mean reformatting to the following and dropping the first paragraph:

Complete the "TODO: PROFILES" by enforcing all profile-specific constraints as defined by the AV1 specification (Section 5.5.2, "Color config syntax"):

- Profile 0: 8/10-bit only, 4:2:0 subsampling, no monochrome
- Profile 1: 8/10-bit only, 4:4:4 only, no monochrome
- Profile 2: 8/10/12-bit, 4:2:0 / 4:2:2 / 4:4:4 allowed, monochrome allowed

Additionally, when the MONO_CHROME flag is set:
- subsampling_x and subsampling_y must both be 1
- separate_uv_delta_q must be 0

Quoted 8 lines

These checks prevent userspace from providing invalid AV1 sequence headers that would otherwise be accepted, leading to undefined driver or hardware behavior.

If you are fine with this change I can apply. Otherwise please include my Rb in your v2.

Thank you for your feedback. I’ve added some more changes and sent patch v3 in this series.
Could you please review it?

Regards,
Pavan Bobba