Skip to contentSkip to conversation

staging: rtl8723bs: fix coding style in hal_com_phycfg.c

PATCH Superseded Akiyoshi Kurita 3 participants 4 messages Sep 8, 2025 – Sep 12, 2025 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: fix coding style in hal_com_phycfg.c

The function definition for phy_StoreTxPowerByRateBase() did not follow the kernel coding style.

Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1 -3
index d5649e7d8f99..f137ec747ab3 100644
@@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
 }
 
 static void
-phy_StoreTxPowerByRateBase(
-struct adapter *padapter
-	)
+phy_StoreTxPowerByRateBase(struct adapter *padapter)
 {
 	u8 path, base;
 
Signature · 1 line
2.47.3
#1 lore raw
Quoted 8 lines · Akiyoshi Kurita

The function definition for phy_StoreTxPowerByRateBase() did not follow the kernel coding style.

Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.

---

There are so many other functions which are declared in exactly this same format. Fix the others like this in the file as well in one patch.

regards,
dan carpenter

#2 lore raw
In reply to Akiyoshi Kurita
Quoted 16 lines · Akiyoshi Kurita

The function definition for phy_StoreTxPowerByRateBase() did not follow the kernel coding style.

Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +0 -0
index d5649e7d8f99..f137ec747ab3 100644

drivers/staging/rtl8723bs/hal/hal_com_phycfg.c phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, · line 63

Quoted 7 lines
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1 -3
@@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
 }
 
 static void
-phy_StoreTxPowerByRateBase(
-struct adapter *padapter
-	)
+phy_StoreTxPowerByRateBase(struct adapter *padapter)

This really should end up being:

static void phy_StoreTxPowerByRateBase(struct adapter *padapter)

right?

thanks,

greg k-h

#3 lore raw

PATCH v2 1/1 staging: rtl8723bs: hal: put return type and function name on one line

Make the function definition of phy_StoreTxPowerByRateBase() follow the kernel coding style by placing the return type and function name on a single line.

No functional change.

---
v2:
- Keep return type and function name on the same line (per review).
- Drop stray blank line before the opening brace.

---
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1 -4
index d5649e7d8f99..cd76e26e868f 100644
@@ -59,10 +59,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
 	}
 }
 
-static void
-phy_StoreTxPowerByRateBase(
-struct adapter *padapter
-	)
+static void phy_StoreTxPowerByRateBase(struct adapter *padapter)
 {
 	u8 path, base;
 
Signature · 1 line
2.47.3