staging: rtl8723bs: fix coding style in hal_com_phycfg.c
PATCH 1/1 staging: rtl8723bs: fix coding style in hal_com_phycfg.c
The function definition for phy_StoreTxPowerByRateBase() did not follow the kernel coding style.
Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.
--- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1 -3
@@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, }static void -phy_StoreTxPowerByRateBase ( -struct adapter *padapter - ) +phy_StoreTxPowerByRateBase (struct adapter *padapter) {u8 path, base;
Signature · 1 line
2.47.3
Quoted 8 lines · Akiyoshi Kurita
The function definition for
phy_StoreTxPowerByRateBase()did not follow the kernel coding style.Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.
Signed-off-by Akiyoshi Kurita <[email protected]>---
There are so many other functions which are declared in exactly this same format. Fix the others like this in the file as well in one patch.
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 16 lines · Akiyoshi Kurita
The function definition for
phy_StoreTxPowerByRateBase()did not follow the kernel coding style.Move the closing parenthesis to the same line as the argument to fix the style issue reported by checkpatch.pl.
Signed-off-by Akiyoshi Kurita <[email protected]>--- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +0
-0
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, · line 63
Quoted 7 lines
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1
-3@@ -60,9 +60,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, }static void -phy_StoreTxPowerByRateBase ( -struct adapter *padapter - ) +phy_StoreTxPowerByRateBase (struct adapter *padapter)
This really should end up being:
static void phy_StoreTxPowerByRateBase(struct adapter *padapter)
right?
thanks,
greg k-h
PATCH v2 1/1 staging: rtl8723bs: hal: put return type and function name on one line
Make the function definition of phy_StoreTxPowerByRateBase() follow the kernel coding style by placing the return type and function name on a single line.
No functional change.
---
v2:
- Keep return type and function name on the same line (per review).
- Drop stray blank line before the opening brace.
--- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +1 -4
@@ -59,10 +59,7 @@ phy_SetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, } } -static void -phy_StoreTxPowerByRateBase ( -struct adapter *padapter - ) +static void phy_StoreTxPowerByRateBase (struct adapter *padapter) {u8 path, base;
Signature · 1 line
2.47.3