mm-damon-core-introduce-damon_call_control-dealloc_on_cancel.patch removed from -mm tree
The quilt patch titled
Subject: mm/damon/core: introduce damon_call_control->dealloc_on_cancel
has been removed from the -mm tree. Its filename was
mm-damon-core-introduce-damon_call_control-dealloc_on_cancel.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/core: introduce damon_call_control->dealloc_on_cancel
Date: Mon, 8 Sep 2025 13:15:12 -0700
Patch series "mm/damon/sysfs: fix refresh_ms control overwriting on multi-kdamonds usages".
Automatic esssential DAMON/DAMOS status update feature of DAMON sysfs interface (refresh_ms) is broken [1] for multiple DAMON contexts (kdamonds) use case, since it uses a global single damon_call_control object for all created DAMON contexts. The fields of the object, particularly the list field is over-written for the contexts and it makes unexpected results including user-space hangup and kernel crashes [2]. Fix it by extending damon_call_control for the use case and updating the usage on DAMON sysfs interface to use per-context dynamically allocated damon_call_control object.
This patch (of 2):
When damon_call_control->repeat is set, damon_call() is executed asynchronously, and is eventually canceled when kdamond finishes. If the damon_call_control object is dynamically allocated, finding the place to deallocate the object is difficult. Introduce a new damon_call_control field, namely dealloc_on_cancel, to ask the kdamond deallocates those dynamically allocated objects when those are canceled.
---
include/linux/damon.h | 2 ++ mm/damon/core.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-)
include/linux/damon.h renamed from include/linux/damon.h~mm-damon-core-introduce-damon_call_control-dealloc_on_cancel +2 -0
@@ -636,6 +636,7 @@ struct damon_operations {* @data: Data that will be passed to @fn. * @repeat: Repeat invocations. * @return_code: Return code from @fn invocation. +* @dealloc_on_cancel: De-allocate when canceled. * * Control damon_call(), which requests specific kdamond to invoke a given * function. Refer to damon_call() for more details.
@@ -645,6 +646,7 @@ struct damon_call_control {void *data;bool repeat;int return_code; +bool dealloc_on_cancel;/* private: internal use only */ /* informs if the kdamond finished handling of the request */ struct completion completion;
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-introduce-damon_call_control-dealloc_on_cancel +6 -2
@@ -2479,10 +2479,14 @@ static void kdamond_call(struct damon_ctmutex_lock (&ctx->call_controls_lock);list_del (&control->list);mutex_unlock (&ctx->call_controls_lock); -if (!control->repeat) +if (!control->repeat) {complete (&control->completion); -else + }else if (control->canceled && control->dealloc_on_cancel) { +kfree (control); +continue ; + }else {list_add (&control->list, &repeat_controls); + } } control =list_first_entry_or_null (&repeat_controls, struct damon_call_control, list);
_
Patches currently in -mm which might be from [email protected] are
mm-zswap-store-page_size-compression-failed-page-as-is.patch mm-zswap-store-page_size-compression-failed-page-as-is-fix.patch mm-zswap-store-page_size-compression-failed-page-as-is-v5.patch mm-zswap-store-page_size-compression-failed-page-as-is-fix-2.patch mm-damon-core-add-damon_ctx-addr_unit.patch mm-damon-paddr-support-addr_unit-for-access-monitoring.patch mm-damon-paddr-support-addr_unit-for-damos_pageout.patch mm-damon-paddr-support-addr_unit-for-damos_lru_prio.patch mm-damon-paddr-support-addr_unit-for-migrate_hotcold.patch mm-damon-paddr-support-addr_unit-for-damos_stat.patch mm-damon-sysfs-implement-addr_unit-file-under-context-dir.patch docs-mm-damon-design-document-address-unit-parameter.patch docs-admin-guide-mm-damon-usage-document-addr_unit-file.patch docs-abi-damon-document-addr_unit-file.patch