Skip to contentSkip to conversation

FAILED: patch "[PATCH] mm/damon/reclaim: avoid divide-by-zero in" failed to apply to 6.16-stable tree

PATCH New [email protected] 2 participants 2 messages Sep 13, 2025 – Sep 14, 2025

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 6.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.16.y
git checkout FETCH_HEAD
git cherry-pick -x e6b543ca9806d7bced863f43020e016ee996c057
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025091327-cyclist-impeach-ca7c@gregkh' --subject-prefix 'PATCH 6.16.y' HEAD^..

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From e6b543ca9806d7bced863f43020e016ee996c057 Mon Sep 17 00:00:00 2001
From: Quanmin Yan <[email protected]>
Date: Wed, 27 Aug 2025 19:58:58 +0800
Subject: [PATCH] mm/damon/reclaim: avoid divide-by-zero in
damon_reclaim_apply_parameters()

When creating a new scheme of DAMON_RECLAIM, the calculation of 'min_age_region' uses 'aggr_interval' as the divisor, which may lead to division-by-zero errors. Fix it by directly returning -EINVAL when such a case occurs.

Fixes f5a79d7c0c87 ("mm/damon: introduce struct damos_access_pattern")
Cc Kefeng Wang <[email protected]>
Cc ze zuo <[email protected]>
Cc <[email protected]> [6.1+]
mm/damon/reclaim.c +5 -0
index 3c71b4596676..fb7c982a0018 100644
@@ -194,6 +194,11 @@ static int damon_reclaim_apply_parameters(void)
 	if (err)
 		return err;
 
+	if (!damon_reclaim_mon_attrs.aggr_interval) {
+		err = -EINVAL;
+		goto out;
+	}
+
 	err = damon_set_attrs(param_ctx, &damon_reclaim_mon_attrs);
 	if (err)
 		goto out;
maintainer
#1 lore raw

PATCH 1/1 mm/damon/reclaim: avoid divide-by-zero in damon_reclaim_apply_parameters()

From: Quanmin Yan <[email protected]>

When creating a new scheme of DAMON_RECLAIM, the calculation of 'min_age_region' uses 'aggr_interval' as the divisor, which may lead to division-by-zero errors. Fix it by directly returning -EINVAL when such a case occurs.

Fixes f5a79d7c0c87 ("mm/damon: introduce struct damos_access_pattern")
Cc Kefeng Wang <[email protected]>
Cc ze zuo <[email protected]>
Cc <[email protected]> [6.1+]
(cherry picked from commit e6b543ca9806d7bced863f43020e016ee996c057)
---
 mm/damon/reclaim.c | 5 +++++
 1 file changed, 5 insertions(+)
mm/damon/reclaim.c +5 -0
index a675150965e0..ade3ff724b24 100644
@@ -194,6 +194,11 @@ static int damon_reclaim_apply_parameters(void)
 	if (err)
 		return err;
 
+	if (!damon_reclaim_mon_attrs.aggr_interval) {
+		err = -EINVAL;
+		goto out;
+	}
+
 	err = damon_set_attrs(ctx, &damon_reclaim_mon_attrs);
 	if (err)
 		goto out;
Signature · 1 line
2.39.5