sunxi: extend R528/T113-s3/D1(s) DRAM initialisation
PATCH v2 1/1 sunxi: extend R528/T113-s3/D1(s) DRAM initialisation
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e758/inc/clocks.h#L250
And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 {
compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid";
reg = <0x0 0x03006000 0 0x1000>;
#address-cells = <1>;
#size-cells = <1>;
chipid {
reg = <0x0 0>;
offset = <0x200>;
size = <0x10>;
};
...
};---
Changes in v2:
- Use uint32_t instead of u32 for sid_read_soc_chipid return type
- Add descriptive comment about source of Chip-ID list and register
drivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)
drivers/ram/sunxi/dram_sun20i_d1.c +12 -1
@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void dram_voltage_set (const dram_para_t *para) {int vol;
@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para, fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse ==15 )
@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];break ; +case 10 : +if (sid_read_soc_chipid () ==SUNXI_CHIPID_T113M4020DC0 ) + cfg = ac_remapping_tables[0 ]; +else + cfg = ac_remapping_tables[5 ]; +break ;case 11 : cfg = ac_remapping_tables[4 ];break ;default :case 12 : cfg = ac_remapping_tables[1 ];break ;
drivers/ram/sunxi/dram_sun20i_d1.h +7 -0
@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +/* * This structure contains a mixture of fixed configuration settings, * variables that are used at runtime to communicate settings between
Signature · 1 line
2.39.5
On Tue, 16 Sep 2025 01:40:26 +0100
Andre Przywara <[email protected]> wrote:
Hi Lukas,
please remember to wait for a bit before sending out a v2, to give other people time to respond, to the patch itself and also the comments to that. Given the current U-Boot development state, this is October material, so there is no real rush.
Quoted 8 lines
Quoted 5 lines · On Mon, 15 Sep 2025 21:20:35 +0200 Lukas Schmid <[email protected]> wrote:
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e758/inc/clocks.h#L250
I am not sure a random github repo is necessarily a good reference. What's more important here is our observation that the -s4 chips we have seen use that identifier, which is different from the -s3 ones.
I wonder if we should include the 0x6800 identifier, since it's apparently used out there in the wild for some -s4 batches, too?
Quoted 10 lines
Quoted 10 lines
And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 { compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid"; reg = <0x0 0x03006000 0 0x1000>; #address-cells = <1>; #size-cells = <1>;
Quoted 8 lines
Quoted 7 lines
chipid { reg = <0x0 0>; offset = <0x200>; size = <0x10>; }; ... };
I understand you did this after John's comment, but I am replying here since it's the newest version of the patch: that's a lot of words for something that has been widely known for almost a decade now: "The first word of the SID carries some batch/package information." So I don't think that deserves some lengthy paragraph, and I would like to avoid proliferating unreviewed and undocumented BSP DT snippets.
So I think the wording should be more along the line of "certain batches or packages, identifiable by the SID chip ID, require a different remapping table".
Cheers,
Andre
Quoted 72 lines
Quoted 71 lines
Signed-off-by Lukas Schmid <[email protected]>Tested-by John Watts <[email protected]>Reviewed-by John Watts <[email protected]>Reviewed-by Jernej Skrabec <[email protected]>---
Changes in v2:
- Useuint32_tinstead of u32 forsid_read_soc_chipidreturn type
- Add descriptive comment about source of Chip-ID list and registerdrivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)drivers/ram/sunxi/dram_sun20i_d1.c +12
-1@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void dram_voltage_set (const dram_para_t *para) {int vol;@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para, fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse ==15 )@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];break ; +case 10 : +if (sid_read_soc_chipid () ==SUNXI_CHIPID_T113M4020DC0 ) + cfg = ac_remapping_tables[0 ]; +else + cfg = ac_remapping_tables[5 ]; +break ;case 11 : cfg = ac_remapping_tables[4 ];break ;default :case 12 : cfg = ac_remapping_tables[1 ];break ;drivers/ram/sunxi/dram_sun20i_d1.h +7
-0@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +/* * This structure contains a mixture of fixed configuration settings, * variables that are used at runtime to communicate settings between
On Mon, 15 Sep 2025 21:20:35 +0200
Lukas Schmid <[email protected]> wrote:
Hi Lukas, John,
so looking at the code again, table 0 is special in that it's all 0's, which apparently means no remapping, according to some comments. We already bail out earlier of this function for configurations that do not require remapping, so can you test whether this works here as well? Just do the chip ID test early, after the DRAM type check, and before the fuse is read. And if it's 0x7200, then just return;
I think that would look better than the odd fuse special case.
Thanks,
Andre
Quoted 93 lines
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e758/inc/clocks.h#L250And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 { compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid"; reg = <0x0 0x03006000 0 0x1000>; #address-cells = <1>; #size-cells = <1>; chipid { reg = <0x0 0>; offset = <0x200>; size = <0x10>; }; ... };Signed-off-by Lukas Schmid <[email protected]>Tested-by John Watts <[email protected]>Reviewed-by John Watts <[email protected]>Reviewed-by Jernej Skrabec <[email protected]>---
Changes in v2:
- Useuint32_tinstead of u32 forsid_read_soc_chipidreturn type
- Add descriptive comment about source of Chip-ID list and registerdrivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)drivers/ram/sunxi/dram_sun20i_d1.c +12
-1@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void dram_voltage_set (const dram_para_t *para) {int vol;@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para, fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse ==15 )@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];break ; +case 10 : +if (sid_read_soc_chipid () ==SUNXI_CHIPID_T113M4020DC0 ) + cfg = ac_remapping_tables[0 ]; +else + cfg = ac_remapping_tables[5 ]; +break ;case 11 : cfg = ac_remapping_tables[4 ];break ;default :case 12 : cfg = ac_remapping_tables[1 ];break ;drivers/ram/sunxi/dram_sun20i_d1.h +7
-0@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +/* * This structure contains a mixture of fixed configuration settings, * variables that are used at runtime to communicate settings between
Quoted 93 lines · On Mittwoch, 17. September 2025 23:48:26 Mitteleuropäische Sommerzeit Andre…
On Mon, 15 Sep 2025 21:20:35 +0200
Lukas Schmid <[email protected]> wrote:Hi Lukas, John,
so looking at the code again, table 0 is special in that it's all 0's, which apparently means no remapping, according to some comments. We already bail out earlier of this function for configurations that do not require remapping, so can you test whether this works here as well? Just do the chip ID test early, after the DRAM type check, and before the fuse is read. And if it's
0x7200, then just return;I think that would look better than the odd fuse special case.
Thanks,
AndreQuoted 76 lines
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e
758/inc/clocks.h#L250And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 {
compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid"; reg = <0x0 0x03006000 0 0x1000>; #address-cells = <1>; #size-cells = <1>; chipid { reg = <0x0 0>; offset = <0x200>; size = <0x10>; }; ...};
Signed-off-by Lukas Schmid <[email protected]>Tested-by John Watts <[email protected]>Reviewed-by John Watts <[email protected]>Reviewed-by Jernej Skrabec <[email protected]>---
Changes in v2:
- Useuint32_tinstead of u32 forsid_read_soc_chipidreturn type
- Add descriptive comment about source of Chip-ID list and registerdrivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.cindexa1794032f3b..381eeb87e2e100644drivers/ram/sunxi/dram_sun20i_d1.c +5
-0@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void
dram_voltage_set(const dram_para_t *para){drivers/ram/sunxi/dram_sun20i_d1.c +1
-0int vol;@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,> fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse == 15)
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 680
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-1@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,>switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];
break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 687
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+case 10 : + if (sid_read_soc_chipid() ==
SUNXI_CHIPID_T113M4020DC0)
Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 688
Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+ cfg =
ac_remapping_tables[0];
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 690
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+else + cfg =
ac_remapping_tables[5];
Quoted 3 lines
Quoted 3 lines
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+break ;case 11: cfg = ac_remapping_tables[4];
break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-0default :case 12 : cfg = ac_remapping_tables[1 ];
break;
Quoted 20 lines
Quoted 20 lines
(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.hindex91383f6cf10..7bd8f67a77a100644drivers/ram/sunxi/dram_sun20i_d1.h +7
-0@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +
Quoted 4 lines
Quoted 4 lines
/*
* This structure contains a mixture of fixed configuration settings,
* variables that are used at runtime to communicate settings between
Hi Andre,
I finally got some time to look into this patch again.
Dropping out of the DRAM type check earlier sounds like a good move here. I can definitely do that and also test it on my board.
About the other changes. Is the patch itself in a good state right now (except the commit message) or would you (or anyone else here for that matter) like to see something changed?
I'll change/update the commit message to have a smaller footprint regarding the SID chip ID, and also remove the reference to the "random" git repo.
Best regards,
Lukas
On Thu, 16 Oct 2025 17:30:41 +0200
Lukas Schmid <[email protected]> wrote:
Hi Lukas,
Quoted 4 lines
I finally got some time to look into this patch again.
Dropping out of the DRAM type check earlier sounds like a good move here. I can definitely do that and also test it on my board.
Yes, please do, and send a v3 if that works for you.
Quoted 6 lines
About the other changes. Is the patch itself in a good state right now (except the commit message) or would you (or anyone else here for that matter) like to see something changed?
I'll change/update the commit message to have a smaller footprint regarding the SID chip ID, and also remove the reference to the "random" git repo.
What's more important than the sources is some background and some description about what the patch does, like this:
==================
The T113-s4 SoC is using the same die as the T113-s3, but comes with 256MiB of co-packaged DRAM. Besides the doubled size, the DRAM chip seems to be connected slightly differently, which requires to use a different pin remapping.
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID, which is stored in the first word of the SID efuses.
==================
So no lengthy dumps or links. You might want to put the link to the github repo as a comment before the enum in dram_sun20i_d1.h.
Thanks,
Andre
Quoted 147 lines
Best regards,
LukasQuoted 93 lines · On Mittwoch, 17. September 2025 23:48:26 Mitteleuropäische Sommerzeit Andre…
On Mon, 15 Sep 2025 21:20:35 +0200
Lukas Schmid <[email protected]> wrote:Hi Lukas, John,
so looking at the code again, table 0 is special in that it's all 0's, which apparently means no remapping, according to some comments. We already bail out earlier of this function for configurations that do not require remapping, so can you test whether this works here as well? Just do the chip ID test early, after the DRAM type check, and before the fuse is read. And if it's
0x7200, then just return;I think that would look better than the odd fuse special case.
Thanks,
AndreQuoted 76 lines
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e
758/inc/clocks.h#L250And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 {
compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid"; reg = <0x0 0x03006000 0 0x1000>; #address-cells = <1>; #size-cells = <1>; chipid { reg = <0x0 0>; offset = <0x200>; size = <0x10>; }; ...};
Signed-off-by Lukas Schmid <[email protected]>Tested-by John Watts <[email protected]>Reviewed-by John Watts <[email protected]>Reviewed-by Jernej Skrabec <[email protected]>---
Changes in v2:
- Useuint32_tinstead of u32 forsid_read_soc_chipidreturn type
- Add descriptive comment about source of Chip-ID list and registerdrivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.cindexa1794032f3b..381eeb87e2e100644drivers/ram/sunxi/dram_sun20i_d1.c +5
-0@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void
dram_voltage_set(const dram_para_t *para){drivers/ram/sunxi/dram_sun20i_d1.c +1
-0int vol;@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,> fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse == 15)
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 680
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-1@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,>switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 687
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+case 10 : + if (sid_read_soc_chipid() ==
SUNXI_CHIPID_T113M4020DC0)Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 688
Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+ cfg =ac_remapping_tables[0];
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 690
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+else + cfg =ac_remapping_tables[5];
Quoted 3 lines
Quoted 3 lines
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+break ;case 11: cfg = ac_remapping_tables[4];
break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-0default :case 12 : cfg = ac_remapping_tables[1 ];break;
Quoted 24 lines
Quoted 24 lines
(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.hindex91383f6cf10..7bd8f67a77a100644drivers/ram/sunxi/dram_sun20i_d1.h +7
-0@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +/*
* This structure contains a mixture of fixed configuration settings,
* variables that are used at runtime to communicate settings between
Hi,
I can confirm this code works:
fuse = (readl(SUNXI_SID_BASE + 0x28) & 0xf00) >> 8;
debug("DDR efuse: 0x%x\n", fuse);
debug("SoC Chip ID: 0x%08x\n", sid_read_soc_chipid());
if (sid_read_soc_chipid() == SUNXI_CHIPID_T113M4020DC0)
return;
if (para->dram_type == SUNXI_DRAM_TYPE_DDR2) {
if (fuse == 15)
return;
cfg = ac_remapping_tables[6];
} else {
if (config->dram_tpr13 & 0xc0000) {
cfg = ac_remapping_tables[7];
} else {
switch (fuse) {
case 8: cfg = ac_remapping_tables[2]; break;
case 9: cfg = ac_remapping_tables[3]; break;
case 10: cfg = ac_remapping_tables[5]; break;
case 11: cfg = ac_remapping_tables[4]; break;
default:
case 12: cfg = ac_remapping_tables[1]; break;
case 13:
case 14: cfg = ac_remapping_tables[0]; break;
}John.
Quoted 187 lines · Andre Przywara
On Thu, 16 Oct 2025 17:30:41 +0200
Lukas Schmid <[email protected]> wrote:Hi Lukas,
Quoted 4 lines
I finally got some time to look into this patch again.
Dropping out of the DRAM type check earlier sounds like a good move here. I can definitely do that and also test it on my board.
Yes, please do, and send a v3 if that works for you.
Quoted 6 lines
About the other changes. Is the patch itself in a good state right now (except the commit message) or would you (or anyone else here for that matter) like to see something changed?
I'll change/update the commit message to have a smaller footprint regarding the SID chip ID, and also remove the reference to the "random" git repo.
What's more important than the sources is some background and some description about what the patch does, like this:
==================
The T113-s4 SoC is using the same die as the T113-s3, but comes with 256MiB of co-packaged DRAM. Besides the doubled size, the DRAM chip seems to be connected slightly differently, which requires to use a different pin remapping.Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID, which is stored in the first word of the SID efuses.
==================So no lengthy dumps or links. You might want to put the link to the github repo as a comment before the enum in
dram_sun20i_d1.h.Thanks,
AndreQuoted 147 lines
Best regards,
LukasQuoted 93 lines · On Mittwoch, 17. September 2025 23:48:26 Mitteleuropäische Sommerzeit Andre…
On Mon, 15 Sep 2025 21:20:35 +0200
Lukas Schmid <[email protected]> wrote:Hi Lukas, John,
so looking at the code again, table 0 is special in that it's all 0's, which apparently means no remapping, according to some comments. We already bail out earlier of this function for configurations that do not require remapping, so can you test whether this works here as well? Just do the chip ID test early, after the DRAM type check, and before the fuse is read. And if it's
0x7200, then just return;I think that would look better than the odd fuse special case.
Thanks,
AndreQuoted 76 lines
Extend the DRAM initialisation code to add support for the T113-S4 aka T113M4020DC0 by checking the SoC's CHIPID.
The list of Chip-IDs came from
https://github.com/ua1arn/hftrx/blob/25d8cb9e4cfe1d7d0e4a2f641025c88a9ec5e
758/inc/clocks.h#L250And the chipid register address was something I heard through apritzel altough it seems that, according to Jookia, the Tina Device Tree seems to agree:
sid@3006000 {
compatible = "allwinner,sun20iw1p1-sid", "allwinner,sunxi-sid"; reg = <0x0 0x03006000 0 0x1000>; #address-cells = <1>; #size-cells = <1>; chipid { reg = <0x0 0>; offset = <0x200>; size = <0x10>; }; ...};
Signed-off-by Lukas Schmid <[email protected]>Tested-by John Watts <[email protected]>Reviewed-by John Watts <[email protected]>Reviewed-by Jernej Skrabec <[email protected]>---
Changes in v2:
- Useuint32_tinstead of u32 forsid_read_soc_chipidreturn type
- Add descriptive comment about source of Chip-ID list and registerdrivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ 2 files changed, 19 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.cindexa1794032f3b..381eeb87e2e100644drivers/ram/sunxi/dram_sun20i_d1.c +5
-0@@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para)clrsetbits_le32 (0x3000150 ,0xff00 , reg <<8 ); } +static uint32_t sid_read_soc_chipid (void ) +{ +return readl (SUNXI_SID_BASE +0x00 ) &0xffff ; +} +static void
dram_voltage_set(const dram_para_t *para){drivers/ram/sunxi/dram_sun20i_d1.c +1
-0int vol;@@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,> fuse = (readl (SUNXI_SID_BASE +0x28 ) &0xf00 ) >>8 ;debug ("DDR efuse: 0x%x\n" , fuse); +debug ("SoC Chip ID: 0x%08x\n" ,sid_read_soc_chipid ());if (para->dram_type ==SUNXI_DRAM_TYPE_DDR2 ) {if (fuse == 15)
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 680
Quoted 7 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-1@@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t *para,>switch (fuse) {case 8 : cfg = ac_remapping_tables[2 ];break ;case 9 : cfg = ac_remapping_tables[3 ];break ; -case 10 : cfg = ac_remapping_tables[5 ];break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 687
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+case 10 : + if (sid_read_soc_chipid() ==
SUNXI_CHIPID_T113M4020DC0)Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 688
Quoted 1 line
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+ cfg =ac_remapping_tables[0];
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c static void mctl_phy_ac_remapping(const dram_para_t · line 690
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +2
-0+else + cfg =ac_remapping_tables[5];
Quoted 3 lines
Quoted 3 lines
drivers/ram/sunxi/dram_sun20i_d1.c +1
-0+break ;case 11: cfg = ac_remapping_tables[4];
break;
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c
Quoted 2 lines
drivers/ram/sunxi/dram_sun20i_d1.c +0
-0default :case 12 : cfg = ac_remapping_tables[1 ];break;
Quoted 24 lines
Quoted 24 lines
(quoted diff) +0
-0
b/drivers/ram/sunxi/dram_sun20i_d1.hindex91383f6cf10..7bd8f67a77a100644drivers/ram/sunxi/dram_sun20i_d1.h +7
-0@@ -19,6 +19,13 @@ enum sunxi_dram_type { SUNXI_DRAM_TYPE_LPDDR3 = 7, }; +enum sunxi_soc_chipid { +SUNXI_CHIPID_F133A =0x5C00 , +SUNXI_CHIPID_D1S =0x5E00 , +SUNXI_CHIPID_T113S3 =0x6000 , +SUNXI_CHIPID_T113M4020DC0 =0x7200 , +}; +/*
* This structure contains a mixture of fixed configuration settings,
* variables that are used at runtime to communicate settings between