dt-bindings: nvmem: Introduce nvmem efuse binding for TI K3 SoCs
Subsystems (2)
RFC PATCH 1/1 dt-bindings: nvmem: Introduce nvmem efuse binding for TI K3 SoCs
On K3 SoCs there are efuse registers scattered across the memory map. In order to reference these efuse registers like gp-sw which may store SW REV information or other general purpose information for drivers to consume, treat them appropriately as efuse devices with nvmem framework.
---
This patch is not complete and is sent as an RFC to get some initial thoughts on this implementation to solve [0].
[0] https://lore.kernel.org/linux-mmc/[email protected]
--- .../devicetree/bindings/nvmem/ti,efuses.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/ti,efuses.yaml
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +36 -0
@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/ti,efuses.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI SoC eFuse-based NVMEM + +maintainers: + - Judith Mendez <[email protected]> + +allOf: + - $ref: nvmem.yaml# + - $ref: nvmem-deprecated-cells.yaml# + +properties: + compatible: + - const: ti,am62p-efuse + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + efuse@43000230 { + compatible = "ti,am62p-efuse"; + reg = <0x43000230 0x4>; + }; + +...
Signature · 1 line
2.51.0
Quoted 27 lines · Judith Mendez
On K3 SoCs there are efuse registers scattered across the memory map. In order to reference these efuse registers like gp-sw which may store SW REV information or other general purpose information for drivers to consume, treat them appropriately as efuse devices with nvmem framework.
Signed-off-by Judith Mendez <[email protected]>---
This patch is not complete and is sent as an RFC to get some initial thoughts on this implementation to solve [0].[0] https://lore.kernel.org/linux-mmc/[email protected]
--- .../devicetree/bindings/nvmem/ti,efuses.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)create mode 100644
Documentation/devicetree/bindings/nvmem/ti,efuses.yamlDocumentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +4
-0@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/ti,efuses.yaml#
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 14
Quoted 10 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI SoC eFuse-based NVMEM + +maintainers: + - Judith Mendez <[email protected]> + +allOf: + - $ref: nvmem.yaml# + - $ref: nvmem-deprecated-cells.yaml#
As the name suggests, this old fix-layout is deprecated, you should look at using the newer NVMEM layouts style for this node.
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 18
Quoted 4 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +4
-0+ +properties: + compatible: + - const: ti,am62p-efuse
You mention in the commit message, there are a couple efuse regions in the AM62P SoC, so does this apply generally to all of them, or should you have this be specific to the "gp-sw" efuse region you are describing here?
Quoted 5 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +5
-0+ + reg: + maxItems: 1 + +required:
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +10
-0+ - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + efuse@43000230 { + compatible = "ti,am62p-efuse"; + reg = <0x43000230 0x4>;
The efuse region at 0x43000230 is 96bits, so this should be 0xc not 0x4 size.
Andrew
Quoted 3 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +3
-0+ }; + +...
Hi Andrew,
Quoted 33 lines · Andrew Davis
Quoted 32 lines · Judith Mendez
On K3 SoCs there are efuse registers scattered across the memory map. In order to reference these efuse registers like gp-sw which may store SW REV information or other general purpose information for drivers to consume, treat them appropriately as efuse devices with nvmem framework.
Signed-off-by Judith Mendez <[email protected]>---
This patch is not complete and is sent as an RFC to get some initial thoughts on this implementation to solve [0].[0] https://lore.kernel.org/linux- mmc/[email protected]
---
.../devicetree/bindings/nvmem/ti,efuses.yaml | 36 +++++++++++++++++++1 file changed, 36 insertions(+)create mode 100644
Documentation/devicetree/bindings/nvmem/ti,efuses.yamlDocumentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +9
-0@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/ti,efuses.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI SoC eFuse-based NVMEM + +maintainers:
Quoted 8 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 14
Quoted 5 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +5
-0+ - Judith Mendez <[email protected]> + +allOf: + - $ref: nvmem.yaml# + - $ref: nvmem-deprecated-cells.yaml#As the name suggests, this old fix-layout is deprecated, you should look at using the newer NVMEM layouts style for this node.
Fair point, this can be fixed.
Quoted 10 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 18
Quoted 5 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +4
-0+ +properties: + compatible: + - const: ti,am62p-efuseYou mention in the commit message, there are a couple efuse regions in the AM62P SoC, so does this apply generally to all of them, or should you have this be specific to the "gp-sw" efuse region you are describing here?
I think it is better if this can be more generic, so not only should it apply to gp-sw, gp-sw is only one example register we could treat as efuse register.
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +9
-0+ + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false
Quoted 8 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 33
Quoted 6 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +6
-0+ +examples: + - | + efuse@43000230 { + compatible = "ti,am62p-efuse"; + reg = <0x43000230 0x4>;The efuse region at
0x43000230is 96bits, so this should be0xcnot0x4size.
oop, this will be fixed, thanks.
~ Judith
Rob Herring (Arm)
maintainerQuoted 11 lines · Judith Mendez
On K3 SoCs there are efuse registers scattered across the memory map. In order to reference these efuse registers like gp-sw which may store SW REV information or other general purpose information for drivers to consume, treat them appropriately as efuse devices with nvmem framework.
Signed-off-by Judith Mendez <[email protected]>---
This patch is not complete and is sent as an RFC to get some initial thoughts on this implementation to solve [0].
Quoted 6 lines
[0] https://lore.kernel.org/linux-mmc/[email protected]
--- .../devicetree/bindings/nvmem/ti,efuses.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/ti,efuses.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/ti,efuses.yaml: ignoring, error in schema: properties: compatible /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/ti,efuses.yaml: properties:compatible: [{'const': 'ti,am62p-efuse'}] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/ti,efuses.yaml: properties:compatible: [{'const': 'ti,am62p-efuse'}] is not of type 'object', 'boolean'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#Documentation/devicetree/bindings/nvmem/ti,efuses.example.dtb: /example-0/efuse@43000230: failed to match any schema with compatible: ['ti,am62p-efuse']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Krzysztof,
Quoted 49 lines · Judith Mendez
On K3 SoCs there are efuse registers scattered across the memory map. In order to reference these efuse registers like gp-sw which may store SW REV information or other general purpose information for drivers to consume, treat them appropriately as efuse devices with nvmem framework.
Signed-off-by Judith Mendez <[email protected]>---
This patch is not complete and is sent as an RFC to get some initial thoughts on this implementation to solve [0].[0] https://lore.kernel.org/linux-mmc/[email protected]
--- .../devicetree/bindings/nvmem/ti,efuses.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)create mode 100644
Documentation/devicetree/bindings/nvmem/ti,efuses.yamlDocumentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +26
-0@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/ti,efuses.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI SoC eFuse-based NVMEM + +maintainers: + - Judith Mendez <[email protected]> + +allOf: + - $ref: nvmem.yaml# + - $ref: nvmem-deprecated-cells.yaml# + +properties: + compatible: + - const: ti,am62p-efuse + + reg: + maxItems: 1 + +required: + - compatible + - reg +
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml line 36
Quoted 10 lines
Documentation/devicetree/bindings/nvmem/ti,efuses.yaml new file +10
-0+unevaluatedProperties: false + +examples: + - | + efuse@43000230 { + compatible = "ti,am62p-efuse"; + reg = <0x43000230 0x4>; + }; + +...
Ignoring the errors for now, do you think this could be a good solution to solve [0]?
[0] https://lore.kernel.org/linux-mmc/[email protected]
regards,
~ Judith