Skip to contentSkip to conversation

extend lobf test for supported connectors

PATCH In review Kunal Joshi 2 participants 7 messages Sep 18, 2025 – Sep 22, 2025 Library code

lore
Share & tools
lore
#0 lore raw

cover extend lobf test for supported connectors

Extend lobf test for all connectors that
exposes i915_edp_lobf_status debugfs

Kunal Joshi (3):
lib/igt_kms: add helper to check presence of lobf debugfs tests/kms_vrr: extend lobf test for supported connectors tests/kms_vrr: remove check for PR support in sink

 lib/igt_kms.c   | 20 ++++++++++++++++++++
 lib/igt_kms.h   |  1 +
 tests/kms_vrr.c |  8 ++++----
 3 files changed, 25 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 lib/igt_kms: add helper to check presence of lobf debugfs

Added helper to check if i915_edp_lobf_info debugfs exists for given output.

---
 lib/igt_kms.c | 20 ++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 21 insertions(+)
lib/igt_kms.c +20 -0
index df4a96a17..699562810 100644
@@ -6210,6 +6210,26 @@ void igt_dump_crtcs_fd(int drmfd)
 	drmModeFreeResources(mode_resources);
 }
 
+/**
+ * Checks if the lobf debugfs
+ * is available for a specific output.
+ *
+ * @drmfd: file descriptor of the DRM device.
+ * @output: output to check.
+ * Returns:
+ *  true if the debugfs is available, false otherwise.
+ */
+bool igt_has_lobf_debugfs(int drmfd, igt_output_t *output)
+{
+        char buf[512];
+        int res;
+
+        res = igt_debugfs_read_connector_file(drmfd, output->name,
+                                              "i915_edp_lobf_info",
+                                              buf, sizeof(buf));
+        return res == 0;
+}
+
 /**
  * igt_get_i915_edp_lobf_status
  * @drmfd: A drm file descriptor
lib/igt_kms.h +1 -0
index 6ef6871d5..7121ab985 100644
@@ -1232,6 +1232,7 @@ void igt_dump_connectors_fd(int drmfd);
 void igt_dump_crtcs_fd(int drmfd);
 bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
 bool igt_fit_modes_in_bw(igt_display_t *display);
+bool igt_has_lobf_debugfs(int drmfd, igt_output_t *output);
 bool igt_get_i915_edp_lobf_status(int drmfd, char *connector_name);
 unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
 unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
Signature · 1 line
2.25.1
#2 lore raw

RE: [PATCH i-g-t 1/3] lib/igt_kms: add helper to check presence of lobf debugfs

Quoted 50 lines

-----Original Message-----
From: Joshi, Kunal1 <[email protected]>
Sent: Thursday, September 18, 2025 2:47 PM
To: [email protected]
Cc: B, Jeevan <[email protected]>; Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 1/3] lib/igt_kms: add helper to check presence of lobf debugfs

Added helper to check if i915_edp_lobf_info debugfs exists for given output.

---
 lib/igt_kms.c | 20 ++++++++++++++++++++  lib/igt_kms.h |  1 +
 2 files changed, 21 insertions(+)
lib/igt_kms.c index df4a96a17..699562810 renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +19 -0
@@ -6210,6 +6210,26 @@ void igt_dump_crtcs_fd(int drmfd)
 	drmModeFreeResources(mode_resources);
 }
 
+/**
+ * Checks if the lobf debugfs
+ * is available for a specific output.
+ *
+ * @drmfd: file descriptor of the DRM device.
+ * @output: output to check.
+ * Returns:
+ *  true if the debugfs is available, false otherwise.
+ */
+bool igt_has_lobf_debugfs(int drmfd, igt_output_t *output) {
+        char buf[512];
+        int res;
+
+        res = igt_debugfs_read_connector_file(drmfd, output->name,
+                                              "i915_edp_lobf_info",
+                                              buf, sizeof(buf));
+        return res == 0;
+}
+
 /**
  * igt_get_i915_edp_lobf_status
  * @drmfd: A drm file descriptor
lib/igt_kms.h index 6ef6871d5..7121ab985 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +0 -0
@@ -1232,6 +1232,7 @@ void igt_dump_connectors_fd(int drmfd);  void
Quoted 7 lines

igt_dump_crtcs_fd(int drmfd); bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display); bool igt_fit_modes_in_bw(igt_display_t *display);
+bool igt_has_lobf_debugfs(int drmfd, igt_output_t *output);
bool igt_get_i915_edp_lobf_status(int drmfd, char *connector_name);
unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name); unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);

Change looks ok, But build failure seen please check.

Quoted 2 lines

--
2.25.1

#3 lore raw

PATCH 2/3 tests/kms_vrr: extend lobf test for supported connectors

In reply to Kunal Joshi

Extend lobf test for all connectors that
exposes i915_edp_lobf_status debugfs

---
 tests/kms_vrr.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
tests/kms_vrr.c +6 -1
index 233143770..820a982d0 100644
@@ -948,7 +948,7 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
 {
 	data->debugfs_fd = igt_debugfs_dir(data->drm_fd);
 
-	if ((flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS | TEST_CMRR | TEST_LINK_OFF)) &&
+	if ((flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS | TEST_CMRR)) &&
 	    output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) {
 		igt_info("%s: Connected panel is not eDP.\n", igt_output_name(output));
 		return false;
@@ -961,6 +961,11 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
 	}
 
 	if (flags & TEST_LINK_OFF) {
+		if (igt_has_lobf_debugfs(data->drm_fd, output)) {
+			igt_info("i915_edp_lobf_status not present for %s\n",
+				 igt_output_name(output));
+			return false;
+		}
 		if (!psr_sink_support(data->drm_fd,
 				      data->debugfs_fd, PR_MODE, NULL)) {
 			igt_info("LOBF not supported\n");
Signature · 1 line
2.25.1
#4 lore raw

RE: [PATCH i-g-t 2/3] tests/kms_vrr: extend lobf test for supported connectors

Quoted 34 lines

-----Original Message-----
From: Joshi, Kunal1 <[email protected]>
Sent: Thursday, September 18, 2025 2:47 PM
To: [email protected]
Cc: B, Jeevan <[email protected]>; Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 2/3] tests/kms_vrr: extend lobf test for supported connectors

Extend lobf test for all connectors that exposes i915_edp_lobf_status debugfs

---
 tests/kms_vrr.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
tests/kms_vrr.c index 233143770..820a982d0 renamed from tests/kms_vrr.c +0 -0

100644

tests/kms_vrr.c +0 -1
@@ -948,7 +948,7 @@ static bool output_constraint(data_t *data,
 igt_output_t *output, uint32_t flags  {
 	data->debugfs_fd = igt_debugfs_dir(data->drm_fd);
 
-	if ((flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS |

TEST_CMRR | TEST_LINK_OFF)) &&

tests/kms_vrr.c +1 -0
+	if ((flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS |

TEST_CMRR)) &&
output->config.connector->connector_type !=
DRM_MODE_CONNECTOR_eDP) {
igt_info("%s: Connected panel is not eDP.\n",
igt_output_name(output));

tests/kms_vrr.c +0 -0
 		return false;
@@ -961,6 +961,11 @@ static bool output_constraint(data_t *data,

igt_output_t *output, uint32_t flags

tests/kms_vrr.c static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags · line 968

Quoted 8 lines
tests/kms_vrr.c +5 -0
 	}
 
 	if (flags & TEST_LINK_OFF) {
+		if (igt_has_lobf_debugfs(data->drm_fd, output)) {
+			igt_info("i915_edp_lobf_status not present for %s\n",
+				 igt_output_name(output));
+			return false;
+		}

New Line needed.

Quoted 5 lines
tests/kms_vrr.c +0 -1
 		if (!psr_sink_support(data->drm_fd,
 				      data->debugfs_fd, PR_MODE, NULL)) {
 			igt_info("LOBF not supported\n");
--

2.25.1

#5 lore raw

PATCH 3/3 tests/kms_vrr: remove check for PR support in sink

In reply to Kunal Joshi

LOBF can be enabled on sinks that do not support PR as well.

---
 tests/kms_vrr.c | 5 -----
 1 file changed, 5 deletions(-)
tests/kms_vrr.c +0 -5
index 820a982d0..ce75c7123 100644
@@ -966,11 +966,6 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
 				 igt_output_name(output));
 			return false;
 		}
-		if (!psr_sink_support(data->drm_fd,
-				      data->debugfs_fd, PR_MODE, NULL)) {
-			igt_info("LOBF not supported\n");
-			return false;
-		}
 
 		if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
 		    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
Signature · 1 line
2.25.1
Reviewed-by on v1 3/3
#6 lore raw

RE: [PATCH i-g-t 3/3] tests/kms_vrr: remove check for PR support in sink

Quoted 21 lines

-----Original Message-----
From: Joshi, Kunal1 <[email protected]>
Sent: Thursday, September 18, 2025 2:47 PM
To: [email protected]
Cc: B, Jeevan <[email protected]>; Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 3/3] tests/kms_vrr: remove check for PR support in sink

LOBF can be enabled on sinks that do not support PR as well.

---
 tests/kms_vrr.c | 5 -----
 1 file changed, 5 deletions(-)
tests/kms_vrr.c index 820a982d0..ce75c7123 renamed from tests/kms_vrr.c +0 -0

100644

tests/kms_vrr.c +0 -0
@@ -966,11 +966,6 @@ static bool output_constraint(data_t *data,

igt_output_t *output, uint32_t flags

tests/kms_vrr.c static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags · line 973

Quoted 8 lines
tests/kms_vrr.c +0 -5
 				 igt_output_name(output));
 			return false;
 		}
-		if (!psr_sink_support(data->drm_fd,
-				      data->debugfs_fd, PR_MODE, NULL)) {
-			igt_info("LOBF not supported\n");
-			return false;
-		}

Please add spec link. With this patch LGTM.

Quoted 6 lines

if (psr_sink_support(data->drm_fd, data->debugfs_fd,
PSR_MODE_1, NULL) ||
psr_sink_support(data->drm_fd, data->debugfs_fd,
PR_MODE, NULL))
--
2.25.1