arm64: tegra: Add pinctrl definition for PCIe C4 EP
Subsystems (2)
PATCH 1/1 arm64: tegra: Add pinctrl definition for PCIe C4 EP
From: Gautham Srinivasan <[email protected]>
Commit 0580286d0d22 ("arm64: tegra: Add Tegra234 PCIe C4 EP definition") added the device tree entry "pcie-ep@14160000" for C4 endpoint. However, it missed pinctrl definition. Without the pinctl definition, the C4 endpoint of Jetson Orin Nano does not work. Add the missing definition.
--- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +14 -0
@@ -9,6 +9,7 @@ #include <dt-bindings/power/tegra234-powergate.h> #include <dt-bindings/reset/tegra234-reset.h> #include <dt-bindings/thermal/tegra234-bpmp-thermal.h> +#include <dt-bindings/pinctrl/pinctrl-tegra.h> / { compatible = "nvidia,tegra234";
@@ -127,6 +128,17 @@ gpio: gpio@2200000 { pinmux: pinmux@2430000 { compatible = "nvidia,tegra234-pinmux"; reg = <0x0 0x2430000 0x0 0x19100>; + + pex_rst_c4_in_state: pex_rst_c4_in { + pex_rst { + nvidia,pins = "pex_l4_rst_n_pl1"; + nvidia,function = "rsvd1"; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + nvidia,enable-input = <TEGRA_PIN_ENABLE>; + nvidia,lpdr = <TEGRA_PIN_DISABLE>; + }; + }; }; gpcdma: dma-controller@2600000 {
@@ -4881,6 +4893,8 @@ pcie-ep@14160000 { <&bpmp TEGRA234_RESET_PEX0_CORE_4>; reset-names = "apb", "core"; + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c4_in_state>; interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ interrupt-names = "intr"; nvidia,bpmp = <&bpmp 4>;
Signature · 1 line
2.51.0
Rob Herring (Arm)
maintainerQuoted 7 lines · Niklas Cassel
From: Gautham Srinivasan <[email protected]>
Commit
0580286d0d22("arm64: tegra: Add Tegra234 PCIe C4 EP definition") added the device tree entry "pcie-ep@14160000" for C4 endpoint. However, it missed pinctrl definition. Without the pinctl definition, the C4 endpoint of Jetson Orin Nano does not work. Add the missing definition.
Quoted 7 lines
Signed-off-by Gautham Srinivasan <[email protected]>[cassel: add to the existing nodes instead of creating new ones]Signed-off-by Niklas Cassel <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250917 (exact match)
If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for [email protected]:
arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: pinmux@2430000 (nvidia,tegra234-pinmux): Unevaluated properties are not allowed ('pex_rst_c4_in' was unexpected)
from schema $id: http://devicetree.org/schemas/pinctrl/nvidia,tegra234-pinmux.yaml#