Skip to contentSkip to conversation

Display manager proposal for x11 and wayland

PATCH Superseded [email protected] 5 participants 23 messages Sep 18, 2025 – Sep 23, 2025 4 messages not in the archive

v9 of 16 Superseded Latest is v16 →

lore
Share & tools
lore
#0 lore raw

v9 cover Display manager proposal for x11 and wayland

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
Signature · 1 line
2.51.0
#1 lore raw

PATCH v9 1/6 libx11: create tmpfile dir for x11 domain socket

From: Randolph Sapp <[email protected]>

Register a volatile directory entry for the x11 domain socket when not using systemd. This will make sure the directory is always created with the correct permissions. Systemd already provides their own tmpfile.d entry for the same behavior.

Currently some x11 related applications will create this directory if it doesn't already exist, but this is not true for everything. In addition, if the application in question isn't started as root, it's possible this directory can be owned by a non-root user. This isn't an issue by itself, but it can potentially lead to problems in a multi-user environment.

---
 meta/recipes-graphics/xorg-lib/libx11/99_x11    |  1 +
 meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
meta/recipes-graphics/xorg-lib/libx11/99_x11 new file +1 -0
new file mode 100644
index 0000000000..53c5b49d10
@@ -0,0 +1 @@
+d root root 1777 /tmp/.X11-unix none
meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb +13 -2
index 580e44889d..78713f4ac5 100644
@@ -21,7 +21,8 @@ PE = "1"
 
 XORG_PN = "libX11"
 
-SRC_URI += "file://disable_tests.patch"
+SRC_URI += "file://disable_tests.patch \
+            file://99_x11"
 
 SRC_URI[sha256sum] = "fa026f9bb0124f4d6c808f9aef4057aad65e7b35d8ff43951cef0abe06bb9a9a"
 
@@ -35,7 +36,17 @@ PACKAGECONFIG[xcms] = "--enable-xcms,--disable-xcms"
 
 PACKAGES =+ "${PN}-xcb"
 
-FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt"
+do_install:append() {
+	# temporary directory required for x11 domain sockets
+        # systemd provides their own definition using tmpfiles.d
+	if ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'systemd', 'false', 'true', d)}; then
+		install -d ${D}${sysconfdir}/default/volatiles
+		install -m 0644 ${UNPACKDIR}/99_x11 ${D}${sysconfdir}/default/volatiles/99_x11
+	fi
+}
+
+FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt \
+                ${libdir}/tmpfiles.d/x11.conf ${sysconfdir}/default/volatiles/99_x11"
 FILES:${PN}-xcb += "${libdir}/libX11-xcb.so.*"
 FILES:${PN}-locale += "${datadir}/X11/locale ${libdir}/X11/locale"
 
Signature · 1 line
2.51.0
#2 lore raw

PATCH v9 2/6 go: fix sigaction usage on i386 platforms

In reply to [email protected]

From: Randolph Sapp <[email protected]>

In upstream the following commit [1] was submitted to resolve issues with sigaction being used in linked libraries with cgo applications.

runtime: when using cgo on 386, call C sigaction function

This should address the previously reported issues with pam authentication of go applications on related x86 platforms.

[1] https://github.com/golang/go/commit/c5737dc21bbac9fbefc35ac9313e66291d66b382

---
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++++++++
 2 files changed, 249 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
meta/recipes-devtools/go/go-1.25.0.inc +1 -0
index f562fbb34b..1558b4623d 100644
@@ -16,5 +16,6 @@ SRC_URI += "\
     file://0009-go-Filter-build-paths-on-staticly-linked-arches.patch \
     file://0010-cmd-go-clear-GOROOT-for-func-ldShared-when-trimpath-.patch \
     file://0011-cmd-link-stop-forcing-binutils-gold-dependency-on-aa.patch \
+    file://0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch \
 "
 SRC_URI[main.sha256sum] = "4bd01e91297207bfa450ea40d4d5a93b1b531a5e438473b2a06e18e077227225"
meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch new file +248 -0

248 lines not on this page · raw message

Signature · 1 line
2.51.0
#3 lore raw

PATCH v9 3/6 emptty: add version 0.14.0

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Add emptty, a "Dead simple CLI Display Manager on TTY". This is a relatively lightweight display manager that supports x11 as well as wayland through both a CLI and an automatic login mechanism.

This can effectively replace the custom init scripts for both x11 (xserver-nodm-init) and wayland (weston-init) with a single tool with more verbose logging capabilities.

This is split into two recipes. The emptty package provides the binary and various agnostic configs while the emptty-conf package provides the default configuration for the application itself. This RPROVIDES virtual-emptty-conf, allowing other recipes to provide their own configurations to override the default behavior.

---
 .../conf/distro/include/default-providers.inc |  1 +
 meta/conf/distro/include/maintainers.inc      |  2 +
 meta/recipes-graphics/emptty/emptty-conf.bb   | 14 +++++
 meta/recipes-graphics/emptty/emptty.inc       | 26 +++++++++
 .../recipes-graphics/emptty/emptty/emptty.tab |  1 +
 meta/recipes-graphics/emptty/emptty/pamconf   | 10 ++++
 meta/recipes-graphics/emptty/emptty_0.14.0.bb | 53 +++++++++++++++++++
 7 files changed, 107 insertions(+)
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
meta/conf/distro/include/default-providers.inc +1 -0
index 3f113543cd..820a5d1342 100644
@@ -69,3 +69,4 @@ PREFERRED_PROVIDER_virtual/nativesdk-libsdl2 ?= "nativesdk-libsdl2"
 PREFERRED_RPROVIDER_virtual-libegl-icd ?= "mesa"
 PREFERRED_RPROVIDER_virtual-libglx-icd ?= "mesa"
 PREFERRED_RPROVIDER_virtual-x-terminal-emulator ?= "rxvt-unicode"
+PREFERRED_RPROVIDER_virtual-emptty-conf ?= "emptty-conf"
meta/conf/distro/include/maintainers.inc +2 -0
index e80959749e..db5e2fa9c9 100644
@@ -171,6 +171,8 @@ RECIPE_MAINTAINER:pn-efivar = "Ross Burton <[email protected]>"
 RECIPE_MAINTAINER:pn-efibootmgr = "Ross Burton <[email protected]>"
 RECIPE_MAINTAINER:pn-elfutils = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-ell = "Unassigned <[email protected]>"
+RECIPE_MAINTAINER:pn-emptty = "Randolph Sapp <[email protected]>"
+RECIPE_MAINTAINER:pn-emptty-conf = "Randolph Sapp <[email protected]>"
 RECIPE_MAINTAINER:pn-enchant2 = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-encodings = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-epiphany = "Unassigned <[email protected]>"
meta/recipes-graphics/emptty/emptty-conf.bb new file +14 -0
new file mode 100644
index 0000000000..0aacb086cd
@@ -0,0 +1,14 @@
+require emptty.inc
+
+SUMMARY += " (Default config)"
+
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
+
+do_install () {
+    oe_runmake -C ${S}/src/${GO_IMPORT} DESTDIR=${D} install-config
+}
+
+FILES:${PN}-conf = "${sysconfdir}/emptty/conf"
+CONFFILES:${PN}-conf = "${sysconfdir}/emptty/conf"
+RPROVIDES:${PN}-conf += "virtual-emptty-conf"
meta/recipes-graphics/emptty/emptty.inc new file +26 -0
new file mode 100644
index 0000000000..11d5770f3a
@@ -0,0 +1,26 @@
+SUMMARY = "Dead simple CLI Display Manager on TTY"
+DESCRIPTION = "Emptty is a simple display manager with a command line greeter \
+It supports both X11 and Wayland sessions, exporting required variables and \
+creating user paths as necessary."
+
+HOMEPAGE = "https://github.com/tvrzna/emptty"
+BUGTRACKER = "https://github.com/tvrzna/emptty/issues"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=d1e4d12c7d1d17367ba5668706a405ba"
+
+S = "${UNPACKDIR}"
+
+FILESEXTRAPATHS:append = ":${THISDIR}/emptty"
+
+GO_IMPORT = "github.com/tvrzna/emptty"
+GO_IMPORT_pam = "github.com/msteinert/pam"
+SRC_URI = "\
+    git://${GO_IMPORT}.git;protocol=https;branch=master;destsuffix=src/${GO_IMPORT} \
+    git://${GO_IMPORT_pam}.git;protocol=https;branch=master;name=pam;destsuffix=src/${GO_IMPORT_pam} \
+    file://pamconf \
+    file://emptty.tab \
+    "
+SRCREV = "d162bef75fadc8ae1d8e33dbb3de5e2795a196e0"
+SRCREV_pam = "50ded1b0e7864b9bf75005eb945a8ec826bcf69d"
+
+SRCREV_FORMAT .= "_pam"
meta/recipes-graphics/emptty/emptty/emptty.tab new file +1 -0
new file mode 100644
index 0000000000..6359c7224d
@@ -0,0 +1 @@
+7:5:respawn:/usr/bin/emptty -t 7 -d
meta/recipes-graphics/emptty/emptty/pamconf new file +10 -0
new file mode 100644
index 0000000000..9cbfd6c4a5
@@ -0,0 +1,10 @@
+#%PAM-1.0
+auth            sufficient      pam_succeed_if.so user ingroup nopasswdlogin
+auth            include         common-auth
+-auth           optional        pam_gnome_keyring.so
+-auth           optional        pam_kwallet5.so
+account         include         common-account
+session         include         common-session
+-session        optional        pam_gnome_keyring.so auto_start
+-session        optional        pam_kwallet5.so auto_start force_run
+password        include         common-password
meta/recipes-graphics/emptty/emptty_0.14.0.bb new file +53 -0

53 lines not on this page · raw message

Signature · 1 line
2.51.0
#4 lore raw

PATCH v9 4/6 weston-init: convert to virtual-emptty-conf

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Convert this script package into a simple config for emptty using the same weston user but leveraging the nopasswdlogin session provided by emptty. Runtime provide virtual-emptty-conf as we need to set parameters for the default session.

---
 meta/lib/oeqa/runtime/cases/weston.py         | 18 +++--
 meta/recipes-graphics/wayland/weston-init.bb  | 61 +++------------
 .../wayland/weston-init/emptty.conf           | 77 +++++++++++++++++++
 .../recipes-graphics/wayland/weston-init/init | 54 -------------
 .../wayland/weston-init/weston-autologin      | 11 ---
 .../wayland/weston-init/weston-socket.sh      | 20 -----
 .../wayland/weston-init/weston-start          | 76 ------------------
 .../wayland/weston-init/weston.env            |  0
 .../wayland/weston-init/weston.service        | 71 -----------------
 .../wayland/weston-init/weston.socket         | 14 ----
 10 files changed, 101 insertions(+), 301 deletions(-)
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
meta/lib/oeqa/runtime/cases/weston.py +12 -6
index ee4d336482..69be1f65e3 100644
@@ -37,7 +37,7 @@ class WestonTest(OERuntimeTestCase):
 
     def run_weston_init(self):
         if 'systemd' in self.tc.td['VIRTUAL-RUNTIME_init_manager']:
-            self.target.run('systemd-run --collect --unit=weston-ptest.service --uid=0 -p PAMName=login -p TTYPath=/dev/tty6 -E XDG_RUNTIME_DIR=/tmp -E WAYLAND_DISPLAY=wayland-0 /usr/bin/weston --socket=wayland-1 --log=%s' % self.weston_log_file)
+            self.target.run(self.get_weston_command('systemd-run --collect --unit=weston-ptest.service --uid=0 -p PAMName=login -p TTYPath=/dev/tty6 -E XDG_RUNTIME_DIR -E WAYLAND_DISPLAY /usr/bin/weston --socket=wayland-2 --log=%s' % self.weston_log_file))
         else:
             self.target.run(self.get_weston_command('openvt -- weston --socket=wayland-2 --log=%s' % self.weston_log_file))
 
@@ -55,12 +55,18 @@ class WestonTest(OERuntimeTestCase):
 
     @OEHasPackage(['wayland-utils'])
     def test_wayland_info(self):
-        if 'systemd' in self.tc.td['VIRTUAL-RUNTIME_init_manager']:
-            command = 'XDG_RUNTIME_DIR=/run wayland-info'
-        else:
-            command = self.get_weston_command('wayland-info')
+        command = self.get_weston_command('wayland-info')
         status, output = self.target.run(command)
-        self.assertEqual(status, 0, msg='wayland-info error: %s' % output)
+        msg = 'wayland-info error: %s' % output
+
+        # dump last 20 lines of emptty log in case of failure
+        log_cmd = 'tail -n 20 /var/log/emptty/7.log'
+        msg += '\n\n===== start: snippet =====\n\n'
+        msg += 'file: /var/log/emptty/7.log\n\n'
+        msg += '\n\n%s\n\n' % self.target.run(log_cmd)[1]
+        msg += '\n\n===== end: snippet =====\n\n'
+
+        self.assertEqual(status, 0, msg=msg)
 
     @OEHasPackage(['weston'])
     def test_weston_can_initialize_new_wayland_compositor(self):
meta/recipes-graphics/wayland/weston-init.bb +12 -49

93 lines not on this page · raw message

meta/recipes-graphics/wayland/weston-init/emptty.conf new file +77 -0

77 lines not on this page · raw message

meta/recipes-graphics/wayland/weston-init/init deleted +0 -54

54 lines not on this page · raw message

meta/recipes-graphics/wayland/weston-init/weston-autologin deleted +0 -11
deleted file mode 100644
index f6e6d106de..0000000000
@@ -1,11 +0,0 @@
-auth      required  pam_nologin.so
-auth      required  pam_unix.so     try_first_pass nullok
-
-account   required  pam_nologin.so
-account   required  pam_unix.so
-
-session   required  pam_env.so
-session   required  pam_unix.so
--session  optional  pam_systemd.so type=wayland class=user desktop=weston
--session  optional  pam_loginuid.so
-
meta/recipes-graphics/wayland/weston-init/weston-socket.sh deleted +0 -20
deleted file mode 100755
index 86389d63a3..0000000000
@@ -1,20 +0,0 @@
-#!/bin/sh
-
-# set weston variables for use with global weston socket
-global_socket="/run/wayland-0"
-if [ -e "$global_socket" ]; then
-	weston_group=$(stat -c "%G" "$global_socket")
-	if [ "$(id -u)" = "0" ]; then
-		export WAYLAND_DISPLAY="$global_socket"
-	else
-		case "$(groups "$USER")" in
-			*"$weston_group"*)
-				export WAYLAND_DISPLAY="$global_socket"
-				;;
-			*)
-				;;
-		esac
-	fi
-	unset weston_group
-fi
-unset global_socket
meta/recipes-graphics/wayland/weston-init/weston-start deleted +0 -76

76 lines not on this page · raw message

meta/recipes-graphics/wayland/weston-init/weston.env deleted +0 -0
deleted file mode 100644
index e69de29bb2..0000000000
meta/recipes-graphics/wayland/weston-init/weston.service deleted +0 -71

71 lines not on this page · raw message

meta/recipes-graphics/wayland/weston-init/weston.socket deleted +0 -14
deleted file mode 100644
index c1bdc83c05..0000000000
@@ -1,14 +0,0 @@
-[Unit]
-Description=Weston socket
-RequiresMountsFor=/run
-
-[Socket]
-ListenStream=/run/wayland-0
-SocketMode=0775
-SocketUser=weston
-SocketGroup=wayland
-RemoveOnStop=yes
-
-[Install]
-WantedBy=sockets.target
-
Signature · 1 line
2.51.0
#5 lore raw

Patchtest results for [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/PATCHv9-4-6-weston-init-convert-to-virtual-emptty-conf.patch

FAIL: test max line length: Patch line too long (current length 256, maximum is 200) (test_metadata.TestMetadata.test_max_line_length)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!

#6 lore raw

PATCH v9 5/6 weston: remove deprecated weston-start scripts

In reply to [email protected]

From: Randolph Sapp <[email protected]>

The weston-start scripts are not parsed unless using the old version of weston-init. These files are no longer required since weston-init moved to a virtual-emptty-conf.

---
 .../wayland/weston/systemd-notify.weston-start         |  9 ---------
 .../wayland/weston/xwayland.weston-start               |  6 ------
 meta/recipes-graphics/wayland/weston_14.0.2.bb         | 10 ----------
 3 files changed, 25 deletions(-)
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
meta/recipes-graphics/wayland/weston/systemd-notify.weston-start deleted +0 -9
deleted file mode 100644
index a97e7b38d9..0000000000
@@ -1,9 +0,0 @@
-#!/bin/sh
-  
-# SPDX-FileCopyrightText: Huawei Inc.
-# SPDX-License-Identifier: Apache-2.0
-
-
-if [[ -x "/usr/lib/weston/systemd-notify.so" ]]; then
-        add_weston_module "systemd-notify.so"
-fi
meta/recipes-graphics/wayland/weston/xwayland.weston-start deleted +0 -6
deleted file mode 100644
index 342ac8d129..0000000000
@@ -1,6 +0,0 @@
-#!/bin/sh
-
-if type Xwayland  >/dev/null 2>/dev/null; then
-	mkdir -m 775 -p /tmp/.X11-unix
-	chown root:video /tmp/.X11-unix
-fi
meta/recipes-graphics/wayland/weston_14.0.2.bb +0 -10
index 451fb961a1..7a9d7f63f0 100644
@@ -9,8 +9,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d79ee9e66bb0f95d3386a7acae780b70 \
 SRC_URI = "https://gitlab.freedesktop.org/wayland/weston/-/releases/${PV}/downloads/${BPN}-${PV}.tar.xz \
            file://weston.png \
            file://weston.desktop \
-           file://xwayland.weston-start \
-           file://systemd-notify.weston-start \
            "
 
 SRC_URI[sha256sum] = "b47216b3530da76d02a3a1acbf1846a9cd41d24caa86448f9c46f78f20b6e0ac"
@@ -107,14 +105,6 @@ do_install:append() {
 		install ${UNPACKDIR}/weston.png ${D}${datadir}/icons/hicolor/48x48/apps
 	fi
 
-	if [ "${@bb.utils.contains('PACKAGECONFIG', 'xwayland', 'yes', 'no', d)}" = "yes" ]; then
-		install -Dm 644 ${UNPACKDIR}/xwayland.weston-start ${D}${datadir}/weston-start/xwayland
-	fi
-
-	if [ "${@bb.utils.contains('PACKAGECONFIG', 'systemd', 'yes', 'no', d)}" = "yes" ]; then
-		install -Dm 644 ${UNPACKDIR}/systemd-notify.weston-start ${D}${datadir}/weston-start/systemd-notify
-	fi
-
 	if [ "${@bb.utils.contains('PACKAGECONFIG', 'launch', 'yes', 'no', d)}" = "yes" ]; then
 		chmod u+s ${D}${bindir}/weston-launch
 	fi
Signature · 1 line
2.51.0
#7 lore raw

PATCH v9 6/6 xserver-nodm-init: convert to virtual-emptty-conf

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Convert this script package into a simple config for emptty. This is capable of using either the root user or the underprivileged xuser account based on the same ROOTLESS_X variable. The xuser will leverage the nopasswdlogin session provided by emptty for automatic logins. Runtime provide virtual-emptty-conf as we need to set parameters for the default session.

This also gets rid of the xuser security/capability override since emptty sets up required components as root before decending into the specified user. This does not currently handle loading of autostart applications in "/etc/xdg/autostart".

License-Update: GPLv2 scripts were replaced with MIT based config files

---
 meta/conf/distro/include/maintainers.inc      |   4 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in}         |   8 +-
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 16 files changed, 37 insertions(+), 594 deletions(-)
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 copy meta/recipes-graphics/{wayland/weston-init/emptty.conf => x11-common/xserver-nodm-init/emptty.conf.in} (95%)
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
meta/conf/distro/include/maintainers.inc +2 -2
index db5e2fa9c9..621bf32066 100644
@@ -926,12 +926,12 @@ RECIPE_MAINTAINER:pn-xorgproto = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xprop = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xrandr = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xrestop = "Unassigned <[email protected]>"
-RECIPE_MAINTAINER:pn-xserver-nodm-init = "Unassigned <[email protected]>"
+RECIPE_MAINTAINER:pn-xserver-nodm-init = "Randolph Sapp <[email protected]>"
 RECIPE_MAINTAINER:pn-xserver-xf86-config = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xserver-xorg = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xset = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xtrans = "Unassigned <[email protected]>"
-RECIPE_MAINTAINER:pn-xuser-account = "Unassigned <[email protected]>"
+RECIPE_MAINTAINER:pn-xuser-account = "Randolph Sapp <[email protected]>"
 RECIPE_MAINTAINER:pn-xvinfo = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xwayland = "Unassigned <[email protected]>"
 RECIPE_MAINTAINER:pn-xwininfo = "Unassigned <[email protected]>"
meta/lib/oeqa/runtime/cases/xorg.py +8 -0
index 09afb1e3d1..8593be5b77 100644
@@ -20,4 +20,12 @@ class XorgTest(OERuntimeTestCase):
         status, output = self.target.run(cmd)
         msg = ('Xorg does not appear to be running %s' %
               self.target.run(self.tc.target_cmds['ps'])[1])
+
+        # dump last 20 lines of emptty log in case of failure
+        log_cmd = 'tail -n 20 /var/log/emptty/7.log'
+        msg += '\n\n===== start: snippet =====\n\n'
+        msg += 'file: /var/log/emptty/7.log\n\n'
+        msg += '\n\n%s\n\n' % self.target.run(log_cmd)[1]
+        msg += '\n\n===== end: snippet =====\n\n'
+
         self.assertEqual(status, 0, msg=msg)
meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession deleted +0 -38
deleted file mode 100644
index 0b73127ae1..0000000000
@@ -1,38 +0,0 @@
-#!/bin/sh
-
-if [ -x /usr/bin/dbus-launch ]; then
-    # As this is the X session script, always start a new DBus session.
-    eval `dbus-launch --sh-syntax --exit-with-session </dev/null`
-    echo "D-BUS per-session daemon address is: $DBUS_SESSION_BUS_ADDRESS"
-fi
-
-. /etc/profile
-
-if [ -f $HOME/.profile ]; then
-    . $HOME/.profile
-fi
-
-SYSSESSIONDIR=/etc/X11/Xsession.d
-
-export CLUTTER_DISABLE_MIPMAPPED_TEXT=1
-
-for SESSIONFILE in $SYSSESSIONDIR/*; do
-    set +e
-    case "$SESSIONFILE" in
-        *.sh)
-            . "$SESSIONFILE"
-            ;;
-        *.shbg)
-            "$SESSIONFILE" &
-            ;;
-        *~)
-            # Ignore backup files
-            ;;
-        *)
-            "$SESSIONFILE"
-            ;;
-    esac
-    set -e
-done
-
-exit 0
meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh deleted +0 -19
deleted file mode 100644
index 912f79761c..0000000000
@@ -1,19 +0,0 @@
-# Minimal/stub implementation of the XDG Base Directory specification.
-# http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
-
-# If the runtime directory hasn't been set already (for example by systemd,
-# elogind, or pam) create a directory in TMPDIR.
-if [ -z "$XDG_RUNTIME_DIR" ]; then
-    XDG_RUNTIME_DIR=/run/user/$(id -u)
-    export XDG_RUNTIME_DIR
-fi
-
-if [ -d "$XDG_RUNTIME_DIR" ]; then
-    # If the directory exists, check the permissions and ownership
-    if [ "$(stat -c %u-%a "$XDG_RUNTIME_DIR")" != "$(id -u)-700" ]; then
-        echo "ERROR: $XDG_RUNTIME_DIR has incorrect permissions"
-        exit 1
-    fi
-else
-    mkdir --mode 0700 --parents "${XDG_RUNTIME_DIR}"
-fi
meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh deleted +0 -7
deleted file mode 100644
index 3d7008ca45..0000000000
@@ -1,7 +0,0 @@
-XDGAUTOSTART=/etc/xdg/autostart
-if [ -d $XDGAUTOSTART ]; then
-    for SCRIPT in $XDGAUTOSTART/*; do
-        CMD=`grep ^Exec= $SCRIPT | cut -d '=' -f 2`
-        $CMD &
-    done
-fi
meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh deleted +0 -7
deleted file mode 100644
index b936dedf3b..0000000000
@@ -1,7 +0,0 @@
-if [ -x $HOME/.Xsession ]; then
-    exec $HOME/.Xsession
-elif [ -x /usr/bin/x-session-manager ]; then
-    exec /usr/bin/x-session-manager
-else
-    exec /usr/bin/x-window-manager
-fi
meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver deleted +0 -25
deleted file mode 100644
index 0edbfbfc20..0000000000
@@ -1,25 +0,0 @@
-#!/bin/sh
-
-# This script is only needed to make sure /etc/X11/xserver-common
-# can affect XSERVER, ARGS & DPI: otherwise systemd could just use
-# /etc/default/xserver-nodm as EnvironmentFile and sysvinit could just
-# source the same file
-
-. /etc/profile
-
-# load default values for XSERVER, ARGS, DISPLAY...
-. /etc/default/xserver-nodm
-
-# Allow xserver-common to override ARGS, XSERVER, DPI
-if [ -e /etc/X11/xserver-common ] ; then
-    . /etc/X11/xserver-common
-    if [ ! -e $XSERVER ] ; then
-        XSERVER=$(which $XSERVER)
-    fi
-fi
-
-if [ -n "$DPI" ] ; then
-    ARGS="$ARGS -dpi $DPI"
-fi
-
-exec xinit /etc/X11/Xsession -- $XSERVER $DISPLAY $ARGS $*
meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf deleted +0 -2
deleted file mode 100644
index 7ab7460816..0000000000
@@ -1,2 +0,0 @@
-cap_sys_admin	@USER@
-none	*
meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop new file +5 -0
new file mode 100644
index 0000000000..3357cd9a7f
@@ -0,0 +1,5 @@
+[Desktop Entry]
+Encoding=UTF-8
+Type=Application
+Name=Default X11 Desktop
+Exec=x-session-manager
meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in renamed from meta/recipes-graphics/wayland/weston-init/emptty.conf +4 -4
similarity index 95%
copy from meta/recipes-graphics/wayland/weston-init/emptty.conf
copy to meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
index 1918cc02a7..406a6d1249 100644
@@ -11,13 +11,13 @@ PRINT_ISSUE=true
 PRINT_MOTD=true
 
 # Preselected user, if AUTOLOGIN is enabled, this user is logged in.
-DEFAULT_USER=weston
+DEFAULT_USER=@USER@
 
 # Enables Autologin, if DEFAULT_USER is defined and part of nopasswdlogin group. Possible values are "true" or "false".
 AUTOLOGIN=true
 
 # The default session used, if Autologin is enabled. If session is not found in list of session, it proceeds to manual selection.
-AUTOLOGIN_SESSION=Weston
+AUTOLOGIN_SESSION=Default X11 Desktop
 
 # If Autologin is enabled and session does not start correctly, the number of retries in short period is kept to eventually stop the infinite loop of restarts. -1 is for infinite retries, 0 is for no retry.
 # AUTOLOGIN_MAX_RETRY=2
@@ -41,7 +41,7 @@ VERTICAL_SELECTION=false
 #LOGGING_FILE=/var/log/emptty/[TTY_NUMBER].log
 
 # Arguments passed to Xorg server.
-#XORG_ARGS=
+XORG_ARGS=@NO_CURSOR_ARG@ @BLANK_ARGS@
 
 # Allows to use dynamic motd script to generate custom MOTD.
 #DYNAMIC_MOTD=false
@@ -71,7 +71,7 @@ SESSION_ERROR_LOGGING=rotate
 #DEFAULT_XAUTHORITY=false
 
 #If set true, Xorg will be started as rootless, if system allows and emptty is running in daemon mode.
-#ROOTLESS_XORG=false
+ROOTLESS_XORG=@ROOTLESS_X_ARG@
 
 #If set true, environmental groups are printed to differ Xorg/Wayland/Custom/UserCustom desktops.
 IDENTIFY_ENVS=false
meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch deleted +0 -355

355 lines not on this page · raw message

meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm deleted +0 -75

75 lines not on this page · raw message

meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in deleted +0 -7
deleted file mode 100644
index 4a9670d8d2..0000000000
@@ -1,7 +0,0 @@
-# common environment file for sysvinit and systemd
-
-XSERVER=/usr/bin/Xorg
-DISPLAY=:0
-ARGS=" -br -pn @BLANK_ARGS@ @NO_CURSOR_ARG@ "
-HOME=@HOME@
-USER=@USER@
meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in deleted +0 -11
deleted file mode 100644
index 87dc4f8fcd..0000000000
@@ -1,11 +0,0 @@
-[Unit]
-Description=Xserver startup without a display manager
-
-[Service]
-EnvironmentFile=/etc/default/xserver-nodm
-User=@USER@
-ExecStart=/etc/xserver-nodm/Xserver
-Restart=always
-
-[Install]
-Alias=display-manager.service
meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb +16 -41

84 lines not on this page · raw message

meta/recipes-support/user-creation/xuser-account_0.1.bb +2 -1
index 04f506e7a3..f1e4cb674f 100644
@@ -24,7 +24,8 @@ FILES:${PN} = "${sysconfdir}/dbus-1/system.d/system-xuser.conf"
 
 USERADD_PACKAGES = "${PN}"
 USERADD_PARAM:${PN} = "--create-home \
-                       --groups video,tty,audio,input,shutdown,disk \
+                       --groups video,tty,audio,input,shutdown,disk,nopasswdlogin \
                        --user-group xuser"
+GROUPADD_PARAM:${PN} = "-r nopasswdlogin"
 
 ALLOW_EMPTY:${PN} = "1"
Signature · 1 line
2.51.0
#8 lore raw
In reply to [email protected]
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

Quoted 140 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#9 lore raw
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

Quoted 139 lines
Quoted 139 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#10 lore raw
Quoted 25 lines · Randolph Sapp
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

Quoted 4 lines

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

For the systemd parts, is it also possible to solve this with e.g.

Requires=dev-dri-card0.device
After=dev-dri-card0.device

(or similar) ? Seems like anything emptty would be doing would be a reimplementation of the logic that already exists in systemd to do that.

Quoted 141 lines
Quoted 140 lines
Quoted 140 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#11 lore raw
Quoted 31 lines · Joshua Watt
Quoted 25 lines · Randolph Sapp
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

Quoted 4 lines

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

Quoted 8 lines

For the systemd parts, is it also possible to solve this with e.g.

Requires=dev-dri-card0.device
After=dev-dri-card0.device

(or similar) ? Seems like anything emptty would be doing would be a reimplementation of the logic that already exists in systemd to do that.

It gets messy. A udev rule needs to be made to make systemd track that device. In a multi-card environment a device without an actual display may be picked. Systemd cannot directly solve the issue on it's own.

Quoted 140 lines
Quoted 140 lines
Quoted 139 lines
Quoted 139 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

A message that is not in the archive (sent off-list or not yet received): [email protected]

#13 lore raw
Quoted 37 lines · Randolph Sapp via lists.openembedded.org
Quoted 36 lines · Joshua Watt
Quoted 25 lines · Randolph Sapp
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

Quoted 4 lines

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

For the systemd parts, is it also possible to solve this with e.g.

Requires=dev-dri-card0.device
After=dev-dri-card0.device

Quoted 7 lines
Quoted 3 lines

(or similar) ? Seems like anything emptty would be doing would be a reimplementation of the logic that already exists in systemd to do that.

It gets messy. A udev rule needs to be made to make systemd track that device. In a multi-card environment a device without an actual display may be picked. Systemd cannot directly solve the issue on it's own.

Additionally, there are more init systems supported here than just systemd...

Quoted 134 lines
Quoted 134 lines
Quoted 134 lines
Quoted 133 lines
Quoted 133 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

#14 lore raw
Quoted 36 lines · Randolph Sapp
Quoted 34 lines · Randolph Sapp via lists.openembedded.org
Quoted 33 lines · Joshua Watt
Quoted 25 lines · Randolph Sapp
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

Quoted 4 lines

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

For the systemd parts, is it also possible to solve this with e.g.

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

Requires=dev-dri-card0.device
After=dev-dri-card0.device

(or similar) ? Seems like anything emptty would be doing would be a reimplementation of the logic that already exists in systemd to do that.

It gets messy. A udev rule needs to be made to make systemd track that device.

Ya, that's pretty normal.

Quoted 2 lines
Quoted 2 lines

In a multi-card environment a device without an actual display may be picked. Systemd cannot directly solve the issue on it's own.

Sure, but isn't that what udev is for? I don't think adding selection of a drm device makes sense in emptty. Regardless of init system, it really feels like selection of the correct device to use for display should be a udev problem.

Quoted 138 lines

Additionally, there are more init systems supported here than just systemd...

Quoted 134 lines
Quoted 134 lines
Quoted 134 lines
Quoted 133 lines
Quoted 133 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

#15 lore raw
Quoted 40 lines · Joshua Watt
Quoted 39 lines · Randolph Sapp
Quoted 37 lines · Randolph Sapp via lists.openembedded.org
Quoted 36 lines · Joshua Watt
Quoted 25 lines · Randolph Sapp
Quoted 11 lines · Joshua Watt
Quoted 8 lines · Randolph Sapp via lists.openembedded.org

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

Quoted 5 lines

It's not clear how switching to emptty actually solves that problem; I don't see anything in my (brief) look at the emptty code that would lead me to believe it actually cares about any drm devices being present or handles devices showing up dynamically. Can you maybe elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to look into adding that, but what it currently does is add a retry event counter and a small delay between retries that is better than the current console implementations. Especially considering authentication is handled separately from this retry process.

Quoted 4 lines

By centralizing display manager specific code, common checks and fallback logic can be more easily implemented in the future. I'm hoping this lays the groundwork to let me address some other issues I've seen in multi-card environments as well.

For the systemd parts, is it also possible to solve this with e.g.

Requires=dev-dri-card0.device
After=dev-dri-card0.device

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

(or similar) ? Seems like anything emptty would be doing would be a reimplementation of the logic that already exists in systemd to do that.

It gets messy. A udev rule needs to be made to make systemd track that device.

Ya, that's pretty normal.

Udev is dependent on systemd. Eudev exists, but why would we pull that in simply to manage displays. It's not necessary for anything else at the moment.

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

In a multi-card environment a device without an actual display may be picked. Systemd cannot directly solve the issue on it's own.

Sure, but isn't that what udev is for? I don't think adding selection of a drm device makes sense in emptty. Regardless of init system, it really feels like selection of the correct device to use for display should be a udev problem.

Udev can track events but it does not report existing states. If a display is already plugged in during boot then we won't know. We can catch the plug event and operate on it, but otherwise it's a guess to see what we can do at boot.

For quite some time there has been a service to *manage displays* prior to starting the desktop environment. GDM is a good example of that. Greetd is another. Lightdm is another. Emptty is just an example of a useful all-rounder with a permissive license I thought people would appreciate.

Quoted 137 lines
Quoted 137 lines

Additionally, there are more init systems supported here than just systemd...

Quoted 134 lines
Quoted 134 lines
Quoted 134 lines
Quoted 133 lines
Quoted 133 lines

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
- Address spelling issues in commit messages
- Attempt to resolve some test related issues with weston
- Add additional logs to X11 related tests
v3:
- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running under QEMU the first auth attempt almost always fails.
v4:
- Add a tmpfile entry for the x11 domain socket directory.
- Remove some scripts associated with weston-init that were being shipped with weston
v5:
- Move tmpfile data to individual files
- Add explicit entries for these in the FILES variable
v6:
- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
- Include a backported fix for go/runtime to address segfault issues reported on x86 platforms in previous revisions
v8:
- Sign-off backported patch
v9:
- Resolve merge conflict in maintainers file

Randolph Sapp (6):
libx11: create tmpfile dir for x11 domain socket
go: fix sigaction usage on i386 platforms
emptty: add version 0.14.0
weston-init: convert to virtual-emptty-conf
weston: remove deprecated weston-start scripts
xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

--
2.51.0

#16 lore raw
In reply to [email protected]
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running PID USER VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#17 lore raw
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running PID USER VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#19 lore raw
Quoted 83 lines · Randolph Sapp via lists.openembedded.org
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running PID USER VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

Quoted 8 lines

meta-poky/conf/templates/default

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

Whoops, I see the issue now. v10 inbound.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#21 lore raw
Quoted 86 lines · Randolph Sapp via lists.openembedded.org
Quoted 85 lines · Randolph Sapp via lists.openembedded.org
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
return func(*args, **kwargs)
File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running PID USER VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Quoted 8 lines
Quoted 6 lines

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to address it. Currently, that test expect a root x11 instance to autostart. I have it attempt to do that currently, and my old test images were being built with "empty-root-password allow-empty-password allow-root-login" features enabled, allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the nopasswdlogin group, as it makes it clear that the user has unprotected GUI access.

I'm not sure either of these should really be allowed in a production environment though. Technically we can disable this behavior outright when ROOTLESS_X is set, but it's still a little odd to me.

3. Should the test images explicitly enable the empty-root-password allow-empty-password? That means the x11 test will have to move from an arbitrary runtime test to something like the way locales are currently tested.

Seems like solution 2 is the easiest and preserves the expected behavior for that test, assuming people are okay with that behavior.

- Randolph

#22 lore raw
Quoted 113 lines · Randolph Sapp
Quoted 86 lines · Randolph Sapp via lists.openembedded.org
Quoted 85 lines · Randolph Sapp via lists.openembedded.org
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Quoted 8 lines
Quoted 6 lines

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to address it. Currently, that test expect a root x11 instance to autostart. I have it attempt to do that currently, and my old test images were being built with "empty-root-password allow-empty-password allow-root-login" features enabled, allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the nopasswdlogin group, as it makes it clear that the user has unprotected GUI access.

I'm not sure either of these should really be allowed in a production environment though. Technically we can disable this behavior outright when ROOTLESS_X is set, but it's still a little odd to me.

Quoted 6 lines

3. Should the test images explicitly enable the empty-root-password allow-empty-password? That means the x11 test will have to move from an arbitrary runtime test to something like the way locales are currently tested.

Seems like solution 2 is the easiest and preserves the expected behavior for that test, assuming people are okay with that behavior.

Ideally, we'd create a normal user and have the tests use that normal user. The "root" based tests are historical and were done as testing something was better than nothing. The world expects better security practises and it would be good to ideally update the tests to better match real world usage.

I say ideally since I appreciate it sometimes can be too much work but in this case it might not be, I haven't dug into the details though and I'm a bit distracted. I just thought that info might be helpful for direction.

Cheers,

Richard

#23 lore raw
Quoted 127 lines · Richard Purdie
Quoted 113 lines · Randolph Sapp
Quoted 86 lines · Randolph Sapp via lists.openembedded.org
Quoted 85 lines · Randolph Sapp via lists.openembedded.org
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Quoted 8 lines
Quoted 6 lines

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to address it. Currently, that test expect a root x11 instance to autostart. I have it attempt to do that currently, and my old test images were being built with "empty-root-password allow-empty-password allow-root-login" features enabled, allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the nopasswdlogin group, as it makes it clear that the user has unprotected GUI access.

I'm not sure either of these should really be allowed in a production environment though. Technically we can disable this behavior outright when ROOTLESS_X is set, but it's still a little odd to me.

Quoted 6 lines

3. Should the test images explicitly enable the empty-root-password allow-empty-password? That means the x11 test will have to move from an arbitrary runtime test to something like the way locales are currently tested.

Seems like solution 2 is the easiest and preserves the expected behavior for that test, assuming people are okay with that behavior.

Ideally, we'd create a normal user and have the tests use that normal user. The "root" based tests are historical and were done as testing something was better than nothing. The world expects better security practises and it would be good to ideally update the tests to better match real world usage.

Quoted 8 lines

I say ideally since I appreciate it sometimes can be too much work but in this case it might not be, I haven't dug into the details though and I'm a bit distracted. I just thought that info might be helpful for direction.

Cheers,

Richard

Thanks for the feedback Richard. There is currently already an xuser account that is pulled in when ROOTLESS_X = 0. I assume the default behavior of x11 running as root is a holdover from that period before rootless x was possible.

I can rework these tests and drop the root x11 compatibility path if everyone is alright with that.

- Randolph

A message that is not in the archive (sent off-list or not yet received): [email protected]

#25 lore raw
Quoted 137 lines · Randolph Sapp via lists.openembedded.org
Quoted 127 lines · Richard Purdie
Quoted 113 lines · Randolph Sapp
Quoted 86 lines · Randolph Sapp via lists.openembedded.org
Quoted 85 lines · Randolph Sapp via lists.openembedded.org
Quoted 57 lines · Mathieu Dubois-Briand
Quoted 24 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston prior to all drm devices being registered. There's not really a good, scriptable mechanism to listen in to device registration events that works with the existing weston-init package. Well, at least one that doesn't involve polling files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11, xserver-nodm-init, that (from my limited review) should experience the same issue.

I'd like to introduce the following display manager for oe-core, emptty [1]. This display manager is, as described upstream, a "Dead simple CLI Display Manager on TTY". It supports both x11 and wayland sessions, with togglable build parameters to completely remove x11 and pam dependencies. It's licensed MIT, which shouldn't be an issue for any users. (It is written in Go, if you have opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned to leverage this display manager and simply add a user and emptty config for an autologin session. This can resolve the current behavior across init systems without additional scripting, and move some development out of this layer.

Quoted 7 lines

This lists myself as a maintainer of emptty as well as xserver-nodm-init and xuser-account since these are currently unassigned and I've reworked them significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only with altcfg distro:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current system time (of which the default would be the kernel build time if it is unable to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with both root and rootless x11. I reset my cache and did another local build to match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Quoted 8 lines
Quoted 6 lines

Is that automation setting anything that could possibly play with the build time or system time values for the testimage? I'm not seeing anything in the logs, but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function regardless.

Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to address it. Currently, that test expect a root x11 instance to autostart. I have it attempt to do that currently, and my old test images were being built with "empty-root-password allow-empty-password allow-root-login" features enabled, allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the nopasswdlogin group, as it makes it clear that the user has unprotected GUI access.

I'm not sure either of these should really be allowed in a production environment though. Technically we can disable this behavior outright when ROOTLESS_X is set, but it's still a little odd to me.

Quoted 6 lines

3. Should the test images explicitly enable the empty-root-password allow-empty-password? That means the x11 test will have to move from an arbitrary runtime test to something like the way locales are currently tested.

Seems like solution 2 is the easiest and preserves the expected behavior for that test, assuming people are okay with that behavior.

Ideally, we'd create a normal user and have the tests use that normal user. The "root" based tests are historical and were done as testing something was better than nothing. The world expects better security practises and it would be good to ideally update the tests to better match real world usage.

Quoted 8 lines

I say ideally since I appreciate it sometimes can be too much work but in this case it might not be, I haven't dug into the details though and I'm a bit distracted. I just thought that info might be helpful for direction.

Cheers,

Richard

Quoted 8 lines

Thanks for the feedback Richard. There is currently already an xuser account that is pulled in when ROOTLESS_X = 0. I assume the default behavior of x11 running as root is a holdover from that period before rootless x was possible.

I can rework these tests and drop the root x11 compatibility path if everyone is alright with that.

- Randolph

Ah, should have proof read that a little more.
... when ROOTLESS_X = 1 ...

Point still stands. I'll drop the root x11 path unless anyone objects.

#26 lore raw
Quoted 211 lines · Randolph Sapp
Quoted 209 lines · Randolph Sapp via lists.openembedded.org
Quoted 193 lines · Richard Purdie
Quoted 170 lines · Randolph Sapp
Quoted 128 lines · Randolph Sapp via lists.openembedded.org
Quoted 126 lines · Randolph Sapp via lists.openembedded.org
Quoted 86 lines · Mathieu Dubois-Briand
Quoted 46 lines · rs

From: Randolph Sapp <[email protected]>

We've recently run into some issues with weston-init attempting to start Weston
prior to all drm devices being registered. There's not really a good, scriptable
mechanism to listen in to device registration events that works with the
existing weston-init package. Well, at least one that doesn't involve polling
files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11,
xserver-nodm-init, that (from my limited review) should experience the same
issue.

I'd like to introduce the following display manager for oe-core, emptty [1].
This display manager is, as described upstream, a "Dead simple CLI Display
Manager on TTY". It supports both x11 and wayland sessions, with togglable build
parameters to completely remove x11 and pam dependencies. It's licensed MIT,
which shouldn't be an issue for any users. (It is written in Go, if you have
opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned
to leverage this display manager and simply add a user and emptty config for an
autologin session. This can resolve the current behavior across init systems
without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and
xuser-account since these are currently unassigned and I've reworked them
significantly here.

Quoted 4 lines

Sorry for the delay on this series. I found a few bugs in emptty that I wanted
to address before submitting this officially.

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only
with altcfg distro:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86- alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86- alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86- alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86- alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
    self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials 2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

Quoted 7 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

In the past auth issues can occur if the user was created after the current
system time (of which the default would be the kernel build time if it is unable
to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with
both root and rootless x11. I reset my cache and did another local build to
match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Is that automation setting anything that could possibly play with the build time
or system time values for the testimage? I'm not seeing anything in the logs,
but I'm also not seeing anything that reports the current config outright.

Quoted 5 lines
Quoted 3 lines

I guess I should add some messages for that as part of the test function
regardless.

Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to
address it. Currently, that test expect a root x11 instance to autostart. I have
it attempt to do that currently, and my old test images were being built with
"empty-root-password allow-empty-password allow-root-login" features enabled,
allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for
emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the
nopasswdlogin group, as it makes it clear that the user has unprotected GUI
access.

I'm not sure either of these should really be allowed in a production
environment though. Technically we can disable this behavior outright when
ROOTLESS_X is set, but it's still a little odd to me.

3. Should the test images explicitly enable the empty-root- password
allow-empty-password? That means the x11 test will have to move from an
arbitrary runtime test to something like the way locales are currently tested.

Quoted 3 lines

Seems like solution 2 is the easiest and preserves the expected behavior for
that test, assuming people are okay with that behavior.

Ideally, we'd create a normal user and have the tests use that normal
user. The "root" based tests are historical and were done as testing
something was better than nothing. The world expects better security
practises and it would be good to ideally update the tests to better
match real world usage.

I say ideally since I appreciate it sometimes can be too much work but
in this case it might not be, I haven't dug into the details though and
I'm a bit distracted. I just thought that info might be helpful for
direction.

Quoted 3 lines

Cheers,

Richard

Thanks for the feedback Richard. There is currently already an xuser account
that is pulled in when ROOTLESS_X = 0. I assume the default behavior of x11
running as root is a holdover from that period before rootless x was possible.

I can rework these tests and drop the root x11 compatibility path if everyone is
alright with that.

Quoted 7 lines
Quoted 1 line

- Randolph

Ah, should have proof read that a little more.
... when ROOTLESS_X = 1 ...

Point still stands. I'll drop the root x11 path unless anyone objects.

I think it works on some architectures but not all so dropping it may not be quite that simple.

Cheers,

Richard