hwrng: fix division by zero in ks_sa_rng_init
Subsystems (2)
PATCH 1/1 hwrng: fix division by zero in ks_sa_rng_init
Fix division by zero in ks_sa_rng_init caused by missing clock pointer initialization. The clk_get_rate() call is performed on an uninitialized clk pointer, resulting in division by zero when calculating delay values.
Add clock initialization code before using the clock.
drivers/char/hw_random/ks-sa-rng.c | 7 +++++++ 1 file changed, 7 insertions(+)
---
Noticed this when looking at kci logs:
https://dashboard.kernelci.org/log-viewer?itemId=ti%3A0af42187f4b24261b0c102f0&org=ti&type=test&url=http%3A%2F%2Ffiles.kernelci.org%2F%2Fti%2Fmainline%2Fmaster%2Fv6.17-rc6-43-g8b789f2b7602%2Farm%2Fmulti_v7_defconfig%2BCONFIG_EFI%3Dy%2BCONFIG_ARM_LPAE%3Dy%2Bdebug%2Bkselftest%2Btinyconfig%2Fgcc-12%2Fbaseline-nfs-boot.nfs-k2hk-evm.txt.gz
Fixed version boot:
https://gist.github.com/nmenon/0996e5f7bdbcd3b014cee9921a60d88c
drivers/char/hw_random/ks-sa-rng.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/char/hw_random/ks-sa-rng.c +4 -0
@@ -231,6 +231,10 @@ static int ks_sa_rng_probe(struct platform_device *pdev)if (IS_ERR (ks_sa_rng->regmap_cfg))return dev_err_probe (dev, -EINVAL ,"syscon_node_to_regmap failed\n" ); + ks_sa_rng->clk =devm_clk_get_enabled (dev,NULL ); +if (IS_ERR (ks_sa_rng->clk)) +return dev_err_probe (dev,PTR_ERR (ks_sa_rng->clk),"Failed to get clock\n" ); +pm_runtime_enable (dev); ret =pm_runtime_resume_and_get (dev);if (ret <0 ) {
Signature · 1 line
2.47.0
Hi Nishanth,
Quoted 9 lines · Nishanth Menon
Fix division by zero in
ks_sa_rng_initcaused by missing clock pointer initialization. Theclk_get_rate()call is performed on an uninitialized clk pointer, resulting in division by zero when calculating delay values.Add clock initialization code before using the clock.
Fixes 6d01d8511dce ("hwrng: ks-sa - Add minimum sleep time before ready-polling")Signed-off-by Nishanth Menon <[email protected]>
Quoted 28 lines
drivers/char/hw_random/ks-sa-rng.c | 7 +++++++
1 file changed, 7 insertions(+)---
Noticed this when looking at kci logs:
https://dashboard.kernelci.org/log-viewer?itemId=ti%3A0af42187f4b24261b0c102f0&org=ti&type=test&url=http%3A%2F%2Ffiles.kernelci.org%2F%2Fti%2Fmainline%2Fmaster%2Fv6.17-rc6-43-g8b789f2b7602%2Farm%2Fmulti_v7_defconfig%2BCONFIG_EFI%3Dy%2BCONFIG_ARM_LPAE%3Dy%2Bdebug%2Bkselftest%2Btinyconfig%2Fgcc-12%2Fbaseline-nfs-boot.nfs-k2hk-evm.txt.gzFixed version boot:
https://gist.github.com/nmenon/0996e5f7bdbcd3b014cee9921a60d88cdrivers/char/hw_random/ks-sa-rng.c | 4 ++++
1 file changed, 4 insertions(+)drivers/char/hw_random/ks-sa-rng.c +0
-0@@ -231,6 +231,10 @@ static int ks_sa_rng_probe(struct platform_device *pdev) if (IS_ERR(ks_sa_rng->regmap_cfg)) return dev_err_probe(dev, -EINVAL, "syscon_node_to_regmap failed\n");drivers/char/hw_random/ks-sa-rng.c +4
-0+ ks_sa_rng->clk =devm_clk_get_enabled (dev,NULL ); +if (IS_ERR (ks_sa_rng->clk)) +return dev_err_probe (dev,PTR_ERR (ks_sa_rng->clk),"Failed to get clock\n" ); +
pm_runtime_enable(dev);
ret =pm_runtime_resume_and_get(dev);
if (ret < 0) {
Signature · 1 line
Alexander Sverdlin.
Herbert Xu
maintainerQuoted 14 lines · Nishanth Menon
Fix division by zero in
ks_sa_rng_initcaused by missing clock pointer initialization. Theclk_get_rate()call is performed on an uninitialized clk pointer, resulting in division by zero when calculating delay values.Add clock initialization code before using the clock.
Fixes 6d01d8511dce ("hwrng: ks-sa - Add minimum sleep time before ready-polling")Signed-off-by Nishanth Menon <[email protected]>drivers/char/hw_random/ks-sa-rng.c | 7 +++++++ 1 file changed, 7 insertions(+)---
Quoted 8 lines
Noticed this when looking at kci logs:
https://dashboard.kernelci.org/log-viewer?itemId=ti%3A0af42187f4b24261b0c102f0&org=ti&type=test&url=http%3A%2F%2Ffiles.kernelci.org%2F%2Fti%2Fmainline%2Fmaster%2Fv6.17-rc6-43-g8b789f2b7602%2Farm%2Fmulti_v7_defconfig%2BCONFIG_EFI%3Dy%2BCONFIG_ARM_LPAE%3Dy%2Bdebug%2Bkselftest%2Btinyconfig%2Fgcc-12%2Fbaseline-nfs-boot.nfs-k2hk-evm.txt.gzFixed version boot:
https://gist.github.com/nmenon/0996e5f7bdbcd3b014cee9921a60d88cdrivers/char/hw_random/ks-sa-rng.c | 4 ++++ 1 file changed, 4 insertions(+)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt