Skip to contentSkip to conversation

huge_memory-return-einval-in-folio-split-functions-when-thp-is-disabled.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Sep 21, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: huge_memory: return -EINVAL in folio split functions when THP is disabled
has been removed from the -mm tree. Its filename was
huge_memory-return-einval-in-folio-split-functions-when-thp-is-disabled.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Pankaj Raghav <[email protected]>
Subject: huge_memory: return -EINVAL in folio split functions when THP is disabled
Date: Fri, 5 Sep 2025 17:00:12 +0200

split_huge_page_to_list_[to_order](), split_huge_page() and try_folio_split() return 0 on success and error codes on failure.

When THP is disabled, these functions return 0 indicating success even though an error code should be returned as it is not possible to split a folio when THP is disabled.

Make all these functions return -EINVAL to indicate failure instead of 0. As large folios depend on CONFIG_THP, issue warning as this function should not be called without a large folio.

---

 include/linux/huge_mm.h |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
include/linux/huge_mm.h renamed from include/linux/huge_mm.h~huge_memory-return-einval-in-folio-split-functions-when-thp-is-disabled +8 -4
@@ -588,22 +588,26 @@ static inline int
 split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
 		unsigned int new_order)
 {
-	return 0;
+	VM_WARN_ON_ONCE_PAGE(1, page);
+	return -EINVAL;
 }
 static inline int split_huge_page(struct page *page)
 {
-	return 0;
+	VM_WARN_ON_ONCE_PAGE(1, page);
+	return -EINVAL;
 }
 
 static inline int split_folio_to_list(struct folio *folio, struct list_head *list)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, folio);
+	return -EINVAL;
 }
 
 static inline int try_folio_split(struct folio *folio, struct page *page,
 		struct list_head *list)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, folio);
+	return -EINVAL;
 }
 
 static inline void deferred_split_folio(struct folio *folio, bool partially_mapped) {}

_

Patches currently in -mm which might be from [email protected] are