Skip to contentSkip to conversation

rtc: fix error return in pm80x_rtc_set_alarm()

PATCH New Alexandr Sapozhnkiov 1 participant 1 message Sep 22, 2025

Subsystems (2)
Media (V4L/DVB) Real time clock (RTC)
lore
Share & tools
lore

Alexandr Sapozhnkiov

author
#0 lore raw

PATCH 1/1 rtc: fix error return in pm80x_rtc_set_alarm()

From: Alexandr Sapozhnikov <[email protected]>

Return value of function 'regmap_raw_write', called at rtc-88pm80x.c:205, is not checked, but it is usually checked for this function

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by Alexandr Sapozhnikov <[email protected]>
---
 drivers/rtc/rtc-88pm80x.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/rtc/rtc-88pm80x.c +4 -2
index f40cc06b0979..82984a58dca7 100644
@@ -173,7 +173,7 @@ static int pm80x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 	struct rtc_time now_tm, alarm_tm;
 	unsigned long ticks, base, data;
 	unsigned char buf[4];
-	int mask;
+	int mask, ret;
 
 	regmap_update_bits(info->map, PM800_RTC_CONTROL, PM800_ALARM1_EN, 0);
 

@@ -202,7 +202,9 @@ static int pm80x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 	buf[1] = (data >> 8) & 0xff;
 	buf[2] = (data >> 16) & 0xff;
 	buf[3] = (data >> 24) & 0xff;
-	regmap_raw_write(info->map, PM800_RTC_EXPIRE1_1, buf, 4);
+	ret = regmap_raw_write(info->map, PM800_RTC_EXPIRE1_1, buf, 4);
+	if (ret)
+		return ret;
 	if (alrm->enabled) {
 		mask = PM800_ALARM | PM800_ALARM_WAKEUP | PM800_ALARM1_EN;
 		regmap_update_bits(info->map, PM800_RTC_CONTROL, mask, mask);
Signature · 1 line
2.43.0