mm: convert folio_page() back to a macro
Subsystems (2)
PATCH 1/1 mm: convert folio_page() back to a macro
In commit 73b3294b1152 ("mm: simplify folio_page() and folio_page_idx()") we converted folio_page() into a static inline function. However briefly afterwards in commit a847b17009ec ("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.
So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a _Generic() similar to page_folio(), but there is not a lot of benefit compared to just using a simple macro.
--- include/linux/page-flags.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
include/linux/page-flags.h +1 -4
@@ -316,10 +316,7 @@ static __always_inline unsigned long _compound_head(const struct page *page)* check that the page number lies within @folio; the caller is presumed * to have a reference to the page. */ -static inline struct page *folio_page (const struct folio *folio,unsigned long n) -{ -return (struct page *)(&folio->page + n); -} +#define folio_page (folio, n) (&(folio)->page + (n)) static __always_inline int PageTail(const struct page *page) {
Signature · 1 line
2.51.0
Quoted 12 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.
Quoted 8 lines
Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Signature · 1 line
Kiryl Shutsemau / Kirill A. Shutemov
Quoted 21 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 1 line
---
LGTM. Feel free to add:
Quoted 23 lines
include/linux/page-flags.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)include/linux/page-flags.h +1
-5@@ -316,10 +316,7 @@ static __always_inline unsigned long _compound_head(const struct page *page)* check that the page number lies within @folio; the caller is presumed * to have a reference to the page. */ -static inline struct page *folio_page (const struct folio *folio,unsigned long n) -{ -return (struct page *)(&folio->page + n); -} +#define folio_page (folio, n) (&(folio)->page + (n)) static __always_inline int PageTail(const struct page *page) { --2.51.0
Quoted 12 lines · On Tue, 23 Sep 2025 16:00:58 +0200 David Hildenbrand <[email protected]> wrote:
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.
Quoted 8 lines
Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Thanks,
SJ
[...]
Quoted 20 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 1 line
---
Quoted 15 lines · Dev Jain
Quoted 12 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.
Quoted 8 lines
Quoted 8 lines
Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 4 lines
Quoted 1 line
---
Reviewed-by Dev Jain <[email protected]>
Quoted 20 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 1 line
---
Quoted 12 lines · David Hildenbrand
In commit
73b3294b1152("mm: simplifyfolio_page()andfolio_page_idx()") we convertedfolio_page()into a static inline function. However briefly afterwards in commita847b17009ec("mm: constify highmem related functions for improved const-correctness") we had to add some nasty const-away casting to make the compiler happy when checking const correctness.So let's just convert it back to a simple macro so the compiler can check const correctness properly. There is the alternative of using a
_Generic()similar topage_folio(), but there is not a lot of benefit compared to just using a simple macro.
Quoted 8 lines
Cc Andrew Morton <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc "Liam R. Howlett" <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Mike Rapoport <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Michal Hocko <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Signature · 2 lines
Wei Yang Help you, Help me