Enhance UFS Mediatek Driver
Subsystems (4)
[email protected]
maintainerv2 cover Enhance UFS Mediatek Driver
From: Peter Wang <[email protected]>
Improves the UFS Mediatek driver by correcting clock scaling with PM QoS, and adjusting power management flows. It addresses shutdown/suspend race conditions, and removes redundant functions. Support for new platforms is added with the MMIO_OTSD_CTRL register, and MT6991 performance is optimized with MRTT and random improvements. These changes collectively enhance driver performance, stability, and compatibility.
Changes since v1:
1. Remove two patches that will be fixed in UFS core.
ufs: host: mediatek: Fix runtime suspend error deadlock
ufs: host: mediatek: Enable interrupts for MCQ mode
2. Use hba->shutting_down instead of ufshcd_is_user_access_allowed
Peter Wang (7):
ufs: host: mediatek: Correct clock scaling with PM QoS flow
ufs: host: mediatek: Adjust clock scaling for PM flow
ufs: host: mediatek: Handle clock scaling for high gear in PM flow
ufs: host: mediatek: Adjust sync length for FASTAUTO mode
ufs: host: mediatek: Fix shutdown/suspend race condition
ufs: host: mediatek: Remove duplicate function
ufs: host: mediatek: Add support for new platform with MMIO_OTSD_CTR
Naomi Chu (1):
ufs: host: mediatek: Support new feature for MT6991
drivers/ufs/core/ufs-sysfs.c | 3 +- drivers/ufs/core/ufshcd.c | 3 +- drivers/ufs/host/ufs-mediatek.c | 119 ++++++++++++++++++++++++++------ drivers/ufs/host/ufs-mediatek.h | 4 ++ include/ufs/ufshcd.h | 2 + include/ufs/unipro.h | 7 +- 6 files changed, 115 insertions(+), 23 deletions(-)
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 1/8 ufs: host: mediatek: Correct clock scaling with PM QoS flow
From: Peter Wang <[email protected]>
Correct clock scaling with PM QoS during suspend and resume. Ensure PM QoS is released during suspend if scaling up and re-applied after resume. This prevents performance issues and maintains proper power management.
--- drivers/ufs/core/ufshcd.c | 3 ++- drivers/ufs/host/ufs-mediatek.c | 10 ++++++++++ include/ufs/ufshcd.h | 1 + 3 files changed, 13 insertions(+), 1 deletion(-)
drivers/ufs/core/ufshcd.c +2 -1
@@ -1075,13 +1075,14 @@ void ufshcd_pm_qos_exit(struct ufs_hba *hba)* @hba: per adapter instance * @on: If True, vote for perf PM QoS mode otherwise power save mode */ -static void ufshcd_pm_qos_update (struct ufs_hba *hba,bool on) +void ufshcd_pm_qos_update (struct ufs_hba *hba,bool on) {if (!hba->pm_qos_enabled)return ;cpu_latency_qos_update_request (&hba->pm_qos_req, on ?0 :PM_QOS_DEFAULT_VALUE ); } +EXPORT_SYMBOL_GPL (ufshcd_pm_qos_update);/** * ufshcd_set_clk_freq - set UFS controller clock frequencies
drivers/ufs/host/ufs-mediatek.c +10 -0
@@ -1744,6 +1744,7 @@ static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op, {int err;struct arm_smccc_res res; +struct ufs_mtk_host *host =ufshcd_get_variant (hba);if (status ==PRE_CHANGE ) {if (ufshcd_is_auto_hibern8_supported (hba))
@@ -1773,6 +1774,10 @@ static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op,ufs_mtk_sram_pwr_ctrl (false, res); +/* Release pm_qos if in scale-up mode during suspend */ +if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) +ufshcd_pm_qos_update (hba, false); +return 0 ; fail:/*
@@ -1788,6 +1793,7 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op) {int err;struct arm_smccc_res res; +struct ufs_mtk_host *host =ufshcd_get_variant (hba);if (hba->ufshcd_state !=UFSHCD_STATE_OPERATIONAL )ufs_mtk_dev_vreg_set_lpm (hba, false);
@@ -1798,6 +1804,10 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)if (err) goto fail; +/* Request pm_qos if in scale-up mode after resume */ +if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) +ufshcd_pm_qos_update (hba, true); +if (ufshcd_is_link_hibern8 (hba)) { err =ufs_mtk_link_set_hpm (hba);if (err)
include/ufs/ufshcd.h +1 -0
@@ -1483,5 +1483,6 @@ int ufshcd_write_ee_control(struct ufs_hba *hba);int ufshcd_update_ee_control (struct ufs_hba *hba,u16 *mask,const u16 *other_mask,u16 set,u16 clr);void ufshcd_force_error_recovery (struct ufs_hba *hba); +void ufshcd_pm_qos_update (struct ufs_hba *hba,bool on);#endif /* End of Header */
Signature · 1 line
2.45.2
Re: [PATCH v2 1/8] ufs: host: mediatek: Correct clock scaling with PM QoS flow
Quoted 4 lines · On 9/24/25 2:43 AM, [email protected] wrote:
Correct clock scaling with PM QoS during suspend and resume. Ensure PM QoS is released during suspend if scaling up and re-applied after resume. This prevents performance issues and maintains proper power management.
[email protected]
maintainerPATCH v2 2/8 ufs: host: mediatek: Adjust clock scaling for PM flow
In reply to [email protected]From: Peter Wang <[email protected]>
Adjust clock scaling during suspend and resume in the UFS Mediatek driver. Ensure that the clock scales down during suspend if it was scaled up, and scales up again after resume. This adjustment maintains proper power management.
--- drivers/ufs/host/ufs-mediatek.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/ufs/host/ufs-mediatek.c +8 -4
@@ -1774,9 +1774,11 @@ static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op,ufs_mtk_sram_pwr_ctrl (false, res); -/* Release pm_qos if in scale-up mode during suspend */ -if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) +/* Release pm_qos/clk if in scale-up mode during suspend */ +if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) {ufshcd_pm_qos_update (hba, false); +_ufs_mtk_clk_scale (hba, false); + }return 0 ; fail:
@@ -1804,9 +1806,11 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)if (err) goto fail; -/* Request pm_qos if in scale-up mode after resume */ -if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) +/* Request pm_qos/clk if in scale-up mode after resume */ +if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) {ufshcd_pm_qos_update (hba, true); +_ufs_mtk_clk_scale (hba, true); + }if (ufshcd_is_link_hibern8 (hba)) { err =ufs_mtk_link_set_hpm (hba);
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 3/8 ufs: host: mediatek: Handle clock scaling for high gear in PM flow
In reply to [email protected]From: Peter Wang <[email protected]>
Add clock scaling down for power management flow in the UFS Mediatek driver. If clock scaling is disabled and fixed in high gear, ensure the clock scales down during suspend and scales up again after resume to support high gear. This adjustment maintains proper power management.
--- drivers/ufs/host/ufs-mediatek.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/ufs/host/ufs-mediatek.c +6 -0
@@ -1778,6 +1778,9 @@ static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op,if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) {ufshcd_pm_qos_update (hba, false);_ufs_mtk_clk_scale (hba, false); + }else if ((!ufshcd_is_clkscaling_supported (hba) && + hba->pwr_info.gear_rx >=UFS_HS_G5 )) { +_ufs_mtk_clk_scale (hba, false); }return 0 ;
@@ -1810,6 +1813,9 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)if (ufshcd_is_clkscaling_supported (hba) && (host->clk_scale_up)) {ufshcd_pm_qos_update (hba, true);_ufs_mtk_clk_scale (hba, true); + }else if ((!ufshcd_is_clkscaling_supported (hba) && + hba->pwr_info.gear_rx >=UFS_HS_G5 )) { +_ufs_mtk_clk_scale (hba, true); }if (ufshcd_is_link_hibern8 (hba)) {
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 4/8 ufs: host: mediatek: Adjust sync length for FASTAUTO mode
In reply to [email protected]From: Peter Wang <[email protected]>
Set the sync length for FASTAUTO G1 mode in the UFS Mediatek driver. This ensures the sync length meets minimum values for high-speed gears, improving stability during power mode changes.
--- drivers/ufs/host/ufs-mediatek.c | 32 ++++++++++++++++++++++++++++++++ include/ufs/unipro.h | 7 ++++++- 2 files changed, 38 insertions(+), 1 deletion(-)
drivers/ufs/host/ufs-mediatek.c +32 -0
@@ -1332,6 +1332,36 @@ static bool ufs_mtk_pmc_via_fastauto(struct ufs_hba *hba,return true; } +static void ufs_mtk_adjust_sync_length (struct ufs_hba *hba) +{ +int i; +u32 value; +u32 cnt, att, min; +struct attr_min { +u32 attr; +u32 min_value; + } pa_min_sync_length[] = { + {PA_TXHSG1SYNCLENGTH ,0x48 }, + {PA_TXHSG2SYNCLENGTH ,0x48 }, + {PA_TXHSG3SYNCLENGTH ,0x48 }, + {PA_TXHSG4SYNCLENGTH ,0x48 }, + {PA_TXHSG5SYNCLENGTH ,0x48 } + }; + + cnt =sizeof (pa_min_sync_length) /sizeof (struct attr_min ); +for (i =0 ; i < cnt; i++) { + att = pa_min_sync_length[i].attr; + min = pa_min_sync_length[i].min_value; +ufshcd_dme_get (hba,UIC_ARG_MIB (att), &value); +if (value < min) +ufshcd_dme_set (hba,UIC_ARG_MIB (att), min); + +ufshcd_dme_peer_get (hba,UIC_ARG_MIB (att), &value); +if (value < min) +ufshcd_dme_peer_set (hba,UIC_ARG_MIB (att), min); + } +} +static int ufs_mtk_pre_pwr_change (struct ufs_hba *hba,const struct ufs_pa_layer_attr *dev_max_params,struct ufs_pa_layer_attr *dev_req_params)
@@ -1355,6 +1385,8 @@ static int ufs_mtk_pre_pwr_change(struct ufs_hba *hba, }if (ufs_mtk_pmc_via_fastauto (hba, dev_req_params)) { +ufs_mtk_adjust_sync_length (hba); +ufshcd_dme_set (hba,UIC_ARG_MIB (PA_TXTERMINATION ), true);ufshcd_dme_set (hba,UIC_ARG_MIB (PA_TXGEAR ),UFS_HS_G1 );
include/ufs/unipro.h +6 -1
@@ -111,6 +111,9 @@#define PA_TXLINKSTARTUPHS 0x1544#define PA_AVAILRXDATALANES 0x1540#define PA_MINRXTRAILINGCLOCKS 0x1543 +#define PA_TXHSG1SYNCLENGTH 0x1552 +#define PA_TXHSG2SYNCLENGTH 0x1554 +#define PA_TXHSG3SYNCLENGTH 0x1556#define PA_LOCAL_TX_LCC_ENABLE 0x155E#define PA_ACTIVETXDATALANES 0x1560#define PA_CONNECTEDTXDATALANES 0x1561
@@ -160,7 +163,9 @@#define PA_PACPFRAMECOUNT 0x15C0#define PA_PACPERRORCOUNT 0x15C1#define PA_PHYTESTCONTROL 0x15C2 -#define PA_TXHSADAPTTYPE 0x15D4 +#define PA_TXHSG4SYNCLENGTH 0x15D0 +#define PA_TXHSADAPTTYPE 0x15D4 +#define PA_TXHSG5SYNCLENGTH 0x15D6/* Adpat type for PA_TXHSADAPTTYPE attribute */ #define PA_REFRESH_ADAPT 0x00
Signature · 1 line
2.45.2
Re: [PATCH v2 4/8] ufs: host: mediatek: Adjust sync length for FASTAUTO mode
Quoted 4 lines · On 9/24/25 2:43 AM, [email protected] wrote:
Set the sync length for FASTAUTO G1 mode in the UFS Mediatek driver. This ensures the sync length meets minimum values for high-speed gears, improving stability during power mode changes.
[email protected]
maintainerPATCH v2 5/8 ufs: host: mediatek: Fix shutdown/suspend race condition
In reply to [email protected]From: Peter Wang <[email protected]>
Address a race condition between shutdown and suspend operations in the UFS Mediatek driver. Before entering suspend, check if a shutdown is in progress to prevent conflicts and ensure system stability.
--- drivers/ufs/host/ufs-mediatek.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/ufs/host/ufs-mediatek.c +5 -0
@@ -2425,6 +2425,11 @@ static int ufs_mtk_system_suspend(struct device *dev)struct arm_smccc_res res;int ret; +if (hba->shutting_down) { + ret = -EBUSY ; + goto out; + } + ret =ufshcd_system_suspend (dev);if (ret) goto out;
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 6/8 ufs: host: mediatek: Remove duplicate function
In reply to [email protected]From: Peter Wang <[email protected]>
Remove the duplicate ufs_mtk_us_to_ahit function in the UFS Mediatek driver and export the existing ufshcd_us_to_ahit function for shared use. This change reduces redundancy and maintains consistency across the codebase.
--- drivers/ufs/core/ufs-sysfs.c | 3 ++- drivers/ufs/host/ufs-mediatek.c | 14 +------------- include/ufs/ufshcd.h | 1 + 3 files changed, 4 insertions(+), 14 deletions(-)
drivers/ufs/core/ufs-sysfs.c +2 -1
@@ -235,7 +235,7 @@ static int ufshcd_ahit_to_us(u32 ahit) }/* Convert microseconds to Auto-Hibernate Idle Timer register value */ -static u32 ufshcd_us_to_ahit (unsigned int timer) +u32 ufshcd_us_to_ahit (unsigned int timer) {unsigned int scale;
@@ -245,6 +245,7 @@ static u32 ufshcd_us_to_ahit(unsigned int timer)return FIELD_PREP (UFSHCI_AHIBERN8_TIMER_MASK , timer) |FIELD_PREP (UFSHCI_AHIBERN8_SCALE_MASK , scale); } +EXPORT_SYMBOL_GPL (ufshcd_us_to_ahit);static int ufshcd_read_hci_reg (struct ufs_hba *hba,u32 *val,unsigned int reg) {
drivers/ufs/host/ufs-mediatek.c +1 -13
@@ -1109,18 +1109,6 @@ static void ufs_mtk_setup_clk_gating(struct ufs_hba *hba) } } -/* Convert microseconds to Auto-Hibernate Idle Timer register value */ -static u32 ufs_mtk_us_to_ahit (unsigned int timer) -{ -unsigned int scale; - -for (scale =0 ; timer >UFSHCI_AHIBERN8_TIMER_MASK ; ++scale) - timer /=UFSHCI_AHIBERN8_SCALE_FACTOR ; - -return FIELD_PREP (UFSHCI_AHIBERN8_TIMER_MASK , timer) | -FIELD_PREP (UFSHCI_AHIBERN8_SCALE_MASK , scale); -} -static void ufs_mtk_fix_ahit (struct ufs_hba *hba) {unsigned int us;
@@ -1143,7 +1131,7 @@ static void ufs_mtk_fix_ahit(struct ufs_hba *hba)break ; } - hba->ahit =ufs_mtk_us_to_ahit (us); + hba->ahit =ufshcd_us_to_ahit (us); }ufs_mtk_setup_clk_gating (hba);
include/ufs/ufshcd.h +1 -0
@@ -1484,5 +1484,6 @@ int ufshcd_update_ee_control(struct ufs_hba *hba, u16 *mask, const u16 *other_mask, u16 set, u16 clr);void ufshcd_force_error_recovery (struct ufs_hba *hba);void ufshcd_pm_qos_update (struct ufs_hba *hba,bool on); +u32 ufshcd_us_to_ahit (unsigned int timer);#endif /* End of Header */
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 7/8 ufs: host: mediatek: Add support for new platform with MMIO_OTSD_CTR
In reply to [email protected]From: Peter Wang <[email protected]>
Introduce support for a new UFS Mediatek platform by adding the REG_UFS_UFS_MMIO_OTSD_CTRL register. This update includes checks for legacy platforms and uses the new register to replace debug selection and handle specific operations. The changes ensure compatibility across different hardware versions and prevent potential issues with debug usage on newer platforms.
Additional updates include error logging improvements during link setup for newer and legacy platforms, ensuring proper event logging and debugging.
--- drivers/ufs/host/ufs-mediatek.c | 42 +++++++++++++++++++++++++++------ drivers/ufs/host/ufs-mediatek.h | 1 + 2 files changed, 36 insertions(+), 7 deletions(-)
drivers/ufs/host/ufs-mediatek.c +35 -7
@@ -280,6 +280,9 @@ static int ufs_mtk_hce_enable_notify(struct ufs_hba *hba,ufshcd_readl (hba,REG_UFS_XOUFS_CTRL ) |0x80 , REG_UFS_XOUFS_CTRL); +if (host->legacy_ip_ver) +return 0 ; +/* DDR_EN setting */ if (host->ip_ver >=IP_VER_MT6989 ) { ufshcd_rmwl(hba, UFS_MASK(0x7FFF, 8),
@@ -405,7 +408,7 @@ static void ufs_mtk_dbg_sel(struct ufs_hba *hba) {struct ufs_mtk_host *host =ufshcd_get_variant (hba); -if (((host->ip_ver >>16 ) &0xFF ) >=0x36 ) { +if (!host->legacy_ip_ver && host->ip_ver >=IP_VER_MT6983 ) {ufshcd_writel (hba,0x820820 ,REG_UFS_DEBUG_SEL );ufshcd_writel (hba,0x0 ,REG_UFS_DEBUG_SEL_B0 );ufshcd_writel (hba,0x55555555 ,REG_UFS_DEBUG_SEL_B1 );
@@ -422,6 +425,7 @@ static int ufs_mtk_wait_idle_state(struct ufs_hba *hba,u64 timeout, time_checked;u32 val, sm;bool wait_idle; +struct ufs_mtk_host *host =ufshcd_get_variant (hba);/* cannot use plain ktime_get() in suspend */ timeout =ktime_get_mono_fast_ns () + retry_ms *1000000UL ;
@@ -432,8 +436,13 @@ static int ufs_mtk_wait_idle_state(struct ufs_hba *hba, do { time_checked = ktime_get_mono_fast_ns(); - ufs_mtk_dbg_sel(hba); - val = ufshcd_readl(hba, REG_UFS_PROBE); + if (host->legacy_ip_ver || host->ip_ver < IP_VER_MT6899) { + ufs_mtk_dbg_sel(hba); + val = ufshcd_readl(hba, REG_UFS_PROBE); + } else { + val = ufshcd_readl(hba, REG_UFS_UFS_MMIO_OTSD_CTRL); + val = val >> 16; + } sm = val & 0x1f;
@@ -465,13 +474,20 @@ static int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state, {ktime_t timeout, time_checked;u32 val; +struct ufs_mtk_host *host =ufshcd_get_variant (hba); timeout =ktime_add_ms (ktime_get (), max_wait_ms); do { time_checked = ktime_get(); - ufs_mtk_dbg_sel(hba); - val = ufshcd_readl(hba, REG_UFS_PROBE); - val = val >> 28; + + if (host->legacy_ip_ver || host->ip_ver < IP_VER_MT6899) { + ufs_mtk_dbg_sel(hba); + val = ufshcd_readl(hba, REG_UFS_PROBE); + val = val >> 28; + } else { + val = ufshcd_readl(hba, REG_UFS_UFS_MMIO_OTSD_CTRL); + val = val >> 24; + } if (val == state) return 0;
@@ -1639,14 +1655,26 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)static int ufs_mtk_link_set_hpm (struct ufs_hba *hba) {int err; +u32 val; +struct ufs_mtk_host *host =ufshcd_get_variant (hba); err =ufshcd_hba_enable (hba);if (err)return err; err =ufs_mtk_unipro_set_lpm (hba, false); -if (err) +if (err) { +if (host->ip_ver <IP_VER_MT6899 ) { +ufs_mtk_dbg_sel (hba); + val =ufshcd_readl (hba,REG_UFS_PROBE ); + }else { + val =ufshcd_readl (hba,REG_UFS_UFS_MMIO_OTSD_CTRL ); + } +ufshcd_update_evt_hist (hba,UFS_EVT_RESUME_ERR , (u32 )val); + val =ufshcd_readl (hba,REG_INTERRUPT_STATUS ); +ufshcd_update_evt_hist (hba,UFS_EVT_RESUME_ERR , (u32 )val);return err; + } err =ufshcd_uic_hibern8_exit (hba);if (err)
drivers/ufs/host/ufs-mediatek.h +1 -0
@@ -28,6 +28,7 @@*/ #define REG_UFS_XOUFS_CTRL 0x140#define REG_UFS_REFCLK_CTRL 0x144 +#define REG_UFS_UFS_MMIO_OTSD_CTRL 0x14C#define REG_UFS_MMIO_OPT_CTRL_0 0x160#define REG_UFS_EXTREG 0x2100#define REG_UFS_MPHYCTRL 0x2200
Signature · 1 line
2.45.2
[email protected]
maintainerPATCH v2 8/8 ufs: host: mediatek: Support new feature for MT6991
In reply to [email protected]From: Naomi Chu <[email protected]>
Add support for the MT6991 platform by enabling MRTT settings and random performance improvements. These enhancements aim to optimize performance and efficiency on the MT6991 hardware.
Enable multi-Round Trip Time (MRTT) for improved data handling. Enable random performance improvement features to boost overall system responsiveness.
--- drivers/ufs/host/ufs-mediatek.c | 6 ++++++ drivers/ufs/host/ufs-mediatek.h | 3 +++ 2 files changed, 9 insertions(+)
drivers/ufs/host/ufs-mediatek.c +6 -0
@@ -289,6 +289,12 @@ static int ufs_mtk_hce_enable_notify(struct ufs_hba *hba, 0x453000, REG_UFS_MMIO_OPT_CTRL_0); } +if (host->ip_ver >=IP_VER_MT6991_A0 ) { +/* Enable multi-rtt */ +ufshcd_rmwl (hba,MRTT_EN ,MRTT_EN ,REG_UFS_MMIO_OPT_CTRL_0 ); +/* Enable random performance improvement */ +ufshcd_rmwl (hba,RDN_PFM_IMPV_DIS ,0 ,REG_UFS_MMIO_OPT_CTRL_0 ); + } }return 0 ;
drivers/ufs/host/ufs-mediatek.h +3 -0
@@ -20,6 +20,9 @@#define MCQ_MULTI_INTR_EN BIT(2)#define MCQ_CMB_INTR_EN BIT(3)#define MCQ_AH8 BIT(4) +#define MON_EN BIT(5) +#define MRTT_EN BIT(25) +#define RDN_PFM_IMPV_DIS BIT(28)#define MCQ_INTR_EN_MSK (MCQ_MULTI_INTR_EN | MCQ_CMB_INTR_EN)
Signature · 1 line
2.45.2
Quoted 29 lines · On Wed, 2025-09-24 at 17:43 +0800, [email protected] wrote:
From: Peter Wang <[email protected]>
Improves the UFS Mediatek driver by correcting clock scaling with PM QoS, and adjusting power management flows. It addresses shutdown/suspend race conditions, and removes redundant functions. Support for new platforms is added with the
MMIO_OTSD_CTRLregister, and MT6991 performance is optimized with MRTT and random improvements. These changes collectively enhance driver performance, stability, and compatibility.Changes since v1:
1. Remove two patches that will be fixed in UFS core.
ufs: host: mediatek: Fix runtime suspend error deadlock
ufs: host: mediatek: Enable interrupts for MCQ mode
2. Usehba->shutting_downinstead ofufshcd_is_user_access_allowedPeter Wang (7):
ufs: host: mediatek: Correct clock scaling with PM QoS flow
ufs: host: mediatek: Adjust clock scaling for PM flow
ufs: host: mediatek: Handle clock scaling for high gear in PM flow
ufs: host: mediatek: Adjust sync length for FASTAUTO mode
ufs: host: mediatek: Fix shutdown/suspend race condition
ufs: host: mediatek: Remove duplicate function
ufs: host: mediatek: Add support for new platform withMMIO_OTSD_CTRNaomi Chu (1):
ufs: host: mediatek: Support new feature for MT6991
Quoted 9 lines
drivers/ufs/core/ufs-sysfs.c | 3 +- drivers/ufs/core/ufshcd.c | 3 +-
drivers/ufs/host/ufs-mediatek.c| 119 ++++++++++++++++++++++++++---- --
drivers/ufs/host/ufs-mediatek.h | 4 ++ include/ufs/ufshcd.h | 2 + include/ufs/unipro.h | 7 +-6 files changed, 115 insertions(+), 23 deletions(-)
Peter Wang (王信友)
maintainerQuoted 29 lines · On Wed, 2025-09-24 at 17:43 +0800, [email protected] wrote:
From: Peter Wang <[email protected]>
Improves the UFS Mediatek driver by correcting clock scaling with PM QoS, and adjusting power management flows. It addresses shutdown/suspend race conditions, and removes redundant functions. Support for new platforms is added with the
MMIO_OTSD_CTRLregister, and MT6991 performance is optimized with MRTT and random improvements. These changes collectively enhance driver performance, stability, and compatibility.Changes since v1:
1. Remove two patches that will be fixed in UFS core.
ufs: host: mediatek: Fix runtime suspend error deadlock
ufs: host: mediatek: Enable interrupts for MCQ mode
2. Usehba->shutting_downinstead ofufshcd_is_user_access_allowedPeter Wang (7):
ufs: host: mediatek: Correct clock scaling with PM QoS flow
ufs: host: mediatek: Adjust clock scaling for PM flow
ufs: host: mediatek: Handle clock scaling for high gear in PM flow
ufs: host: mediatek: Adjust sync length for FASTAUTO mode
ufs: host: mediatek: Fix shutdown/suspend race condition
ufs: host: mediatek: Remove duplicate function
ufs: host: mediatek: Add support for new platform withMMIO_OTSD_CTRNaomi Chu (1):
ufs: host: mediatek: Support new feature for MT6991
Quoted 9 lines
drivers/ufs/core/ufs-sysfs.c | 3 +- drivers/ufs/core/ufshcd.c | 3 +-
drivers/ufs/host/ufs-mediatek.c| 119 ++++++++++++++++++++++++++---- --
drivers/ufs/host/ufs-mediatek.h | 4 ++ include/ufs/ufshcd.h | 2 + include/ufs/unipro.h | 7 +-6 files changed, 115 insertions(+), 23 deletions(-)
Hi Martin,
Just a gentle ping to consider merging this patch series.
Thanks.
Peter
Bart Van Assche
reviewerQuoted 1 line · Peter Wang (王信友)
Just a gentle ping to consider merging this patch series.
We are in the middle of the merge window. Please rebase, retest and repost this patch series after the merge window has closed (next Monday?).
Thanks,
Bart.
Martin K. Petersen
AppliedPeter,
Quoted 7 lines
Improves the UFS Mediatek driver by correcting clock scaling with PM QoS, and adjusting power management flows. It addresses shutdown/suspend race conditions, and removes redundant functions. Support for new platforms is added with the
MMIO_OTSD_CTRLregister, and MT6991 performance is optimized with MRTT and random improvements. These changes collectively enhance driver performance, stability, and compatibility.
Applied to 6.19/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen