Skip to contentSkip to conversation

drm/xe/xe_late_bind_fw: Fix missing initialization of variable offset

PATCH Superseded Colin Ian King 1 participant 1 message Sep 24, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/xe/xe_late_bind_fw: Fix missing initialization of variable offset

The variable offset is not being initialized, and it is only set inside a for-loop if entry->name is the same as manifest_entry. In the case where it is not initialized a non-zero check on offset is potentialy checking a bogus uninitalized value. Fix this by initializing offset to zero.

Fixes efa29317a553 ("drm/xe/xe_late_bind_fw: Extract and print version info")
---
 drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_late_bind_fw.c +1 -1
index 38f3feb2aecd..4f0a529caf20 100644
@@ -60,7 +60,7 @@ static int parse_cpd_header(struct xe_late_bind_fw *lb_fw,
 	const struct gsc_manifest_header *manifest;
 	const struct gsc_cpd_entry *entry;
 	size_t min_size = sizeof(*header);
-	u32 offset;
+	u32 offset = 0;
 	int i;
 
 	/* manifest_entry is mandatory */
Signature · 1 line
2.51.0