Skip to contentSkip to conversation

omap3: evm: Drop old musb omap3 driver

PATCH In review Peter Robinson 2 participants 4 messages Jun 29, 2025 – Sep 25, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 omap3: evm: Drop old musb omap3 driver

The USB_OMAP3 driver was (re)added in commit e74e9f620a6 as part of migrating to DM_USB but the config already had MUSB_OMAP2PLUS which is the newer musb driver and what other omap3 devices use. So drop it so we can drop the old driver.

---
 configs/omap3_evm_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/omap3_evm_defconfig +0 -1
index 42c6aadea97..25c2fe532c2 100644
@@ -78,7 +78,6 @@ CONFIG_OMAP3_SPI=y
 CONFIG_USB=y
 # CONFIG_SPL_DM_USB is not set
 CONFIG_USB_EHCI_HCD=y
-CONFIG_USB_OMAP3=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_OMAP2PLUS=y
 CONFIG_USB_HOST_ETHER=y
Signature · 1 line
2.50.0
#1 lore raw

PATCH 2/3 am33xx: am3517 evm: Drop old musb AM35X driver

The USB_AM35X is a legacy driver with one remaining user. The rest of the am33xx devices use the USB_MUSB_TI driver for DM_USB so move the last user USB_MUSB_TI which is the newer musb driver So move to the newer driver so we can drop the old driver.

---
 configs/am3517_evm_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/am3517_evm_defconfig +1 -1
index 244a39cd88f..ba8552948b0 100644
@@ -92,6 +92,6 @@ CONFIG_OMAP3_SPI=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_HOST=y
-CONFIG_USB_MUSB_AM35X=y
+CONFIG_USB_MUSB_TI=y
 CONFIG_BCH=y
 CONFIG_SPL_TINY_MEMSET=y
Signature · 1 line
2.50.0
#2 lore raw

Re: [PATCH 2/3] am33xx: am3517 evm: Drop old musb AM35X driver

Quoted 15 lines · Peter Robinson

The USB_AM35X is a legacy driver with one remaining user. The rest of the am33xx devices use the USB_MUSB_TI driver for DM_USB so move the last user USB_MUSB_TI which is the newer musb driver So move to the newer driver so we can drop the old driver.

---
 configs/am3517_evm_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/am3517_evm_defconfig +0 -0
index 244a39cd88f..ba8552948b0 100644

configs/am3517_evm_defconfig CONFIG_OMAP3_SPI=y · line 97

Quoted 7 lines
configs/am3517_evm_defconfig +1 -1
@@ -92,6 +92,6 @@ CONFIG_OMAP3_SPI=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_MUSB_HOST=y
-CONFIG_USB_MUSB_AM35X=y
+CONFIG_USB_MUSB_TI=y
 CONFIG_BCH=y
 CONFIG_SPL_TINY_MEMSET=y

This patch is wrong, CONFIG_USB_MUSB_AM35X is the right symbol for the correct "musb-new" glue code for this platform.

Signature · 1 line
Tom
#3 lore raw

PATCH 3/3 usb: musb: drop musb legacy drivers

In reply to Peter Robinson

The last of the users of the legacy musb drivers have been migrated so now remove the old musb stack, all users should now be using the new musb stack if they need this functionality.

---
 drivers/usb/Kconfig           |    2 -
 drivers/usb/musb/Kconfig      |   20 -
 drivers/usb/musb/Makefile     |    9 -
 drivers/usb/musb/am35x.c      |  138 ----
 drivers/usb/musb/am35x.h      |   81 ---
 drivers/usb/musb/musb_core.c  |  150 -----
 drivers/usb/musb/musb_core.h  |  343 ----------
 drivers/usb/musb/musb_debug.h |  191 ------
 drivers/usb/musb/musb_hcd.c   | 1161 ---------------------------------
 drivers/usb/musb/musb_hcd.h   |   93 ---
 drivers/usb/musb/musb_udc.c   |  953 ---------------------------
 drivers/usb/musb/omap3.c      |  129 ----
 drivers/usb/musb/omap3.h      |   38 --
 13 files changed, 3308 deletions(-)
 delete mode 100644 drivers/usb/musb/Kconfig
 delete mode 100644 drivers/usb/musb/Makefile
 delete mode 100644 drivers/usb/musb/am35x.c
 delete mode 100644 drivers/usb/musb/am35x.h
 delete mode 100644 drivers/usb/musb/musb_core.c
 delete mode 100644 drivers/usb/musb/musb_core.h
 delete mode 100644 drivers/usb/musb/musb_debug.h
 delete mode 100644 drivers/usb/musb/musb_hcd.c
 delete mode 100644 drivers/usb/musb/musb_hcd.h
 delete mode 100644 drivers/usb/musb/musb_udc.c
 delete mode 100644 drivers/usb/musb/omap3.c
 delete mode 100644 drivers/usb/musb/omap3.h
drivers/usb/Kconfig +0 -2
index 99c6649e417..77e4bbd1b09 100644
@@ -78,8 +78,6 @@ source "drivers/usb/dwc3/Kconfig"
 
 source "drivers/usb/mtu3/Kconfig"
 
-source "drivers/usb/musb/Kconfig"
-
 source "drivers/usb/musb-new/Kconfig"
 
 source "drivers/usb/emul/Kconfig"
drivers/usb/musb/Kconfig deleted +0 -20
deleted file mode 100644
index 2508b6ed0d1..00000000000
@@ -1,20 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-#
-# (C) Copyright 2017
-# Adam Ford, Logic PD, [email protected]
-
-comment "Legacy MUSB Support"
-
-config USB_MUSB_HCD
-	bool "Legacy MUSB Host Controller"
-
-config USB_MUSB_UDC
-	bool "Legacy USB Device Controller"
-
-config USB_OMAP3
-	bool "Legacy MUSB OMAP3 / OMAP4"
-	depends on ARCH_OMAP2PLUS
-
-config USB_AM35X
-	bool"Legacy MUSB AM35x"
-	depends on ARCH_OMAP2PLUS && !USB_OMAP3
drivers/usb/musb/Makefile deleted +0 -9
deleted file mode 100644
index 744f2cfaa29..00000000000
@@ -1,9 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-#
-# (C) Copyright 2000-2007
-# Wolfgang Denk, DENX Software Engineering, [email protected].
-
-obj-$(CONFIG_USB_MUSB_HCD) += musb_hcd.o musb_core.o
-obj-$(CONFIG_USB_MUSB_UDC) += musb_udc.o musb_core.o
-obj-$(CONFIG_USB_OMAP3) += omap3.o
-obj-$(CONFIG_USB_AM35X) += am35x.o
drivers/usb/musb/am35x.c deleted +0 -138

138 lines not on this page · raw message

drivers/usb/musb/am35x.h deleted +0 -81

81 lines not on this page · raw message

drivers/usb/musb/musb_core.c deleted +0 -150

150 lines not on this page · raw message

drivers/usb/musb/musb_core.h deleted +0 -343

343 lines not on this page · raw message

drivers/usb/musb/musb_debug.h deleted +0 -191

191 lines not on this page · raw message

drivers/usb/musb/musb_hcd.c deleted +0 -1161

1,161 lines not on this page · raw message

drivers/usb/musb/musb_hcd.h deleted +0 -93

93 lines not on this page · raw message

drivers/usb/musb/musb_udc.c deleted +0 -953

806 lines not on this page · raw message

drivers/usb/musb/omap3.c deleted +0 -129

129 lines not on this page · raw message

drivers/usb/musb/omap3.h deleted +0 -38
deleted file mode 100644
index 78fdb2959bb..00000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.50.0

Part of the diff is not shown here. View the raw message.